summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>2020-02-12 23:32:22 +0000
committerAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>2020-02-12 23:32:22 +0000
commit36af5d03196ce1ce41c753cdd63931072d2044ea (patch)
tree861aeab62263d1682d6b1528c06fc0b94a697510
parentaca92198a127bb8a7d2e0ba9edcb52954bffcc24 (diff)
parente4e7b91ec85c3b3bdeb74994a68f4bff0f26aefc (diff)
downloadframeworks_av-36af5d03196ce1ce41c753cdd63931072d2044ea.tar.gz
frameworks_av-36af5d03196ce1ce41c753cdd63931072d2044ea.tar.bz2
frameworks_av-36af5d03196ce1ce41c753cdd63931072d2044ea.zip
Revert "BnCrypto: fix use-before-init in CREATE_PLUGIN" am: e4e7b91ec8
Change-Id: Ic58cdb7f33d8eb4acbae84a1fb6885341d177869
-rw-r--r--drm/libmediadrm/ICrypto.cpp13
1 files changed, 2 insertions, 11 deletions
diff --git a/drm/libmediadrm/ICrypto.cpp b/drm/libmediadrm/ICrypto.cpp
index fe94044875..ee5ea936c4 100644
--- a/drm/libmediadrm/ICrypto.cpp
+++ b/drm/libmediadrm/ICrypto.cpp
@@ -264,12 +264,8 @@ status_t BnCrypto::onTransact(
{
CHECK_INTERFACE(ICrypto, data, reply);
- uint8_t uuid[16] = {0};
- if (data.read(uuid, sizeof(uuid)) != NO_ERROR) {
- android_errorWriteLog(0x534e4554, "144767096");
- reply->writeInt32(BAD_VALUE);
- return OK;
- }
+ uint8_t uuid[16];
+ data.read(uuid, sizeof(uuid));
size_t opaqueSize = data.readInt32();
void *opaqueData = NULL;
@@ -285,11 +281,6 @@ status_t BnCrypto::onTransact(
}
data.read(opaqueData, opaqueSize);
- if (data.read(opaqueData, opaqueSize) != NO_ERROR) {
- android_errorWriteLog(0x534e4554, "144767096");
- reply->writeInt32(BAD_VALUE);
- return OK;
- }
reply->writeInt32(createPlugin(uuid, opaqueData, opaqueSize));
free(opaqueData);