From d8aa39d1c31389fffee933f94057a1c9dc4160b2 Mon Sep 17 00:00:00 2001 From: Dan Willemsen Date: Mon, 27 Aug 2018 15:01:03 -0700 Subject: Support turning phony warnings into errors These still default to warnings, but if a board decides to set BOARD_BROKEN_PHONY_TARGETS := false, they'll turn into errors. More likely I'll just be marking the broken targets as broken, then switching the logic here to be like the dup rules warnings/errors. Test: On a build with warnings, try , "false", and "true" Change-Id: I041e1ff4618c4114ec43015b6c0ae1b49b36b6f8 --- ui/build/kati.go | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'ui/build/kati.go') diff --git a/ui/build/kati.go b/ui/build/kati.go index de8dbf4b..b54872c1 100644 --- a/ui/build/kati.go +++ b/ui/build/kati.go @@ -93,6 +93,10 @@ func runKati(ctx Context, config Config) { args = append(args, "--werror_overriding_commands") } + if !config.BuildBrokenPhonyTargets() { + args = append(args, "--werror_real_to_phony", "--werror_phony_looks_real") + } + if !config.Environment().IsFalse("KATI_EMULATE_FIND") { args = append(args, "--use_find_emulator") } -- cgit v1.2.3