diff options
Diffstat (limited to 'cc')
| -rw-r--r-- | cc/config/clang.go | 14 |
1 files changed, 5 insertions, 9 deletions
diff --git a/cc/config/clang.go b/cc/config/clang.go index 4ec787f5..bfa7873a 100644 --- a/cc/config/clang.go +++ b/cc/config/clang.go @@ -97,9 +97,8 @@ func init() { pctx.StaticVariable("ClangExtraCflags", strings.Join([]string{ "-D__compiler_offsetof=__builtin_offsetof", - // Make implicit fallthrough an error in the future. + // -Wimplicit-fallthrough is not enabled by -Wall. "-Wimplicit-fallthrough", - "-Wno-error=implicit-fallthrough", // Help catch common 32/64-bit errors. "-Werror=int-conversion", @@ -164,11 +163,6 @@ func init() { "-Wno-tautological-unsigned-enum-zero-compare", "-Wno-tautological-unsigned-zero-compare", - // http://b/72330874 Disable -Wenum-compare until the instances detected by this new - // warning are fixed. - "-Wno-enum-compare", - "-Wno-enum-compare-switch", - // Disable c++98-specific warning since Android is not concerned with C++98 // compatibility. "-Wno-c++98-compat-extra-semi", @@ -177,9 +171,11 @@ func init() { "-Wno-return-std-move-in-c++11", }, " ")) - // Extra cflags for projects under external/ directory + // Extra cflags for projects under external/ directory to disable warnings that are infeasible + // to fix in all the external projects and their upstream repos. pctx.StaticVariable("ClangExtraExternalCflags", strings.Join([]string{ - // TODO(yikong): Move -Wno flags here + "-Wno-enum-compare", + "-Wno-enum-compare-switch", // http://b/72331524 Allow null pointer arithmetic until the instances detected by // this new warning are fixed. |