diff options
author | Nan Zhang <nanzhang@google.com> | 2018-01-26 18:30:36 -0800 |
---|---|---|
committer | Nan Zhang <nanzhang@google.com> | 2018-02-13 15:13:01 -0800 |
commit | 674dd932d8a60877b71147bd426d7b88a613f4ad (patch) | |
tree | 41e163d147e71c28de9076415580dba1a99d9140 /zip/zip_test.go | |
parent | 1d29875829712eb37d0a1808716c94126018e52d (diff) | |
download | build_soong-674dd932d8a60877b71147bd426d7b88a613f4ad.tar.gz build_soong-674dd932d8a60877b71147bd426d7b88a613f4ad.tar.bz2 build_soong-674dd932d8a60877b71147bd426d7b88a613f4ad.zip |
Add Respfile support for soong_zip.
Sometime the size of our command line passed to soong_zip go program
exceeds the cmdline size limit. So add an RespFile support with "@" special
character prefix.
The args in the cmdline will be considered together with the
args in RespFile during soong_zip running.
Test: real tests in my local machine, and compare the
res/libphonenumber.jar before and after changes.
./cmd -o test.zip '""'-C -> [./cmd,-o,test.zip,""-C]
./cmd -o test.zip '-C -f -> [./cmd,-o,test.zip,-C -f]
./cmd -o test.zip '\"'-C -f -> [./cmd,-o,test.zip,\"-C -f]
./cmd -o test.zip '\\'-C -f -> [./cmd,-o,test.zip,\\-C -f]
./cmd -o test.zip '\a'-C -f -> [./cmd,-o,test.zip,\a-C -f]
./cmd -o test.zip \'-C -> [./cmd,-o,test.zip,'-C]
./cmd -o test.zip \\-C -> [./cmd,-o,test.zip,\-C]
./cmd -o test.zip \"-C -> [./cmd,-o,test.zip,"-C]
./cmd -o test.zip "'"-C -> [./cmd,-o,test.zip,'-C]
./cmd -o test.zip "\\"-C -f -> [./cmd,-o,test.zip,\a-C -f]
./cmd -o test.zip "\""-C -f -> [./cmd,-o,test.zip,"a-C -f]
Bug: b/72484223
Change-Id: I83c3630b70c8396c8e8a3f266244d868d754c4e8
Diffstat (limited to 'zip/zip_test.go')
-rw-r--r-- | zip/zip_test.go | 87 |
1 files changed, 87 insertions, 0 deletions
diff --git a/zip/zip_test.go b/zip/zip_test.go new file mode 100644 index 00000000..03e7958f --- /dev/null +++ b/zip/zip_test.go @@ -0,0 +1,87 @@ +// Copyright 2018 Google Inc. All rights reserved. +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +package zip + +import ( + "reflect" + "testing" +) + +func TestReadRespFile(t *testing.T) { + testCases := []struct { + name, in string + out []string + }{ + { + name: "single quoting test case 1", + in: `./cmd '"'-C`, + out: []string{"./cmd", `"-C`}, + }, + { + name: "single quoting test case 2", + in: `./cmd '-C`, + out: []string{"./cmd", `-C`}, + }, + { + name: "single quoting test case 3", + in: `./cmd '\"'-C`, + out: []string{"./cmd", `\"-C`}, + }, + { + name: "single quoting test case 4", + in: `./cmd '\\'-C`, + out: []string{"./cmd", `\\-C`}, + }, + { + name: "none quoting test case 1", + in: `./cmd \'-C`, + out: []string{"./cmd", `'-C`}, + }, + { + name: "none quoting test case 2", + in: `./cmd \\-C`, + out: []string{"./cmd", `\-C`}, + }, + { + name: "none quoting test case 3", + in: `./cmd \"-C`, + out: []string{"./cmd", `"-C`}, + }, + { + name: "double quoting test case 1", + in: `./cmd "'"-C`, + out: []string{"./cmd", `'-C`}, + }, + { + name: "double quoting test case 2", + in: `./cmd "\\"-C`, + out: []string{"./cmd", `\-C`}, + }, + { + name: "double quoting test case 3", + in: `./cmd "\""-C`, + out: []string{"./cmd", `"-C`}, + }, + } + + for _, testCase := range testCases { + t.Run(testCase.name, func(t *testing.T) { + got := ReadRespFile([]byte(testCase.in)) + if !reflect.DeepEqual(got, testCase.out) { + t.Errorf("expected %q got %q", testCase.out, got) + } + }) + } +} |