diff options
| author | Dan Willemsen <dwillemsen@google.com> | 2019-01-24 15:53:06 -0800 |
|---|---|---|
| committer | Dan Willemsen <dwillemsen@google.com> | 2019-01-24 15:53:06 -0800 |
| commit | cc628908667c2722ac2ee9f132f3f08ec2333756 (patch) | |
| tree | 7c8a958cf6673fb348cdd17540b96c356d7ace1f /ui | |
| parent | 7788c1283fcfe00b59d500fdc3b01ff39049e7ed (diff) | |
| download | build_soong-cc628908667c2722ac2ee9f132f3f08ec2333756.tar.gz build_soong-cc628908667c2722ac2ee9f132f3f08ec2333756.tar.bz2 build_soong-cc628908667c2722ac2ee9f132f3f08ec2333756.zip | |
Add --top_level_phony to catch more real-to-phony problems
As more phony rules move either to the packaging kati run, or soong, the
existing real-to-phony check failed to notice that they were phony
rules.
So I added --top_level_phony to Make that assumes that all leaf nodes
(source files, or nodes generated by another ninja file generator) that
do not have a '/' in them are phony targets.
The existing phony-looks-real check in Kati should prevent these from
being real generated files, and our source tree shouldn't have any
source files used at the root level.
Test: build_test on downstream branches
Change-Id: I77cff84b536c6cd6402307a9aa5a9c273e72c71f
Diffstat (limited to 'ui')
| -rw-r--r-- | ui/build/kati.go | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/ui/build/kati.go b/ui/build/kati.go index 439c928e..f924b9cc 100644 --- a/ui/build/kati.go +++ b/ui/build/kati.go @@ -81,6 +81,7 @@ func runKati(ctx Context, config Config, extraSuffix string, args []string, envF "--werror_suffix_rules", "--warn_real_to_phony", "--warn_phony_looks_real", + "--top_level_phony", "--kati_stats", }, args...) |