aboutsummaryrefslogtreecommitdiffstats
path: root/python
diff options
context:
space:
mode:
authorNan Zhang <nanzhang@google.com>2018-05-22 14:50:18 -0700
committerNan Zhang <nanzhang@google.com>2018-05-23 03:33:36 +0000
commitf0c4e4339ab460f47f431baf44cfb4fea41d9b14 (patch)
tree1c37a006c020846909d18985744e3f5fc7694b50 /python
parentd0ce8e8aabe7445377fe7307572df89394df21c9 (diff)
downloadbuild_soong-f0c4e4339ab460f47f431baf44cfb4fea41d9b14.tar.gz
build_soong-f0c4e4339ab460f47f431baf44cfb4fea41d9b14.tar.bz2
build_soong-f0c4e4339ab460f47f431baf44cfb4fea41d9b14.zip
Fix Protobuf importing issue for embedded Python
As I mentioned in b/79751992 #4, when launcher loads __main__ as entry point, the module dict got set using absolute pkg path which was runfiles.google.protobuf which caused the type checking failed (expected: google.protobuf for type()). After then, starting with non entrypoint python files, the importing module dict would be set with from...import... So remove dir:runfiles/ from zip section so that during entrypoint Python file importing the proto files using from...import..., the type checking can be passed. Bug: b/79751992 Test: m clean && m out/host/linux-x86/bin/perf_proto_stack; And execute it: usage: perf_proto_stack [-h] [--syms SYMS] [--json-out JSON_OUT] [--print-samples] [--skip-kernel-syms] [--print-pid-histogram] [--print-sym-histogram] [--print-dso-histogram] [--parallel PARALLEL] file [file ...] perf_proto_stack: error: too few arguments Change-Id: I95a4a9ee95ce7f90d893ea0529c384d7b944abe4
Diffstat (limited to 'python')
-rw-r--r--python/proto.go14
-rw-r--r--python/python.go16
2 files changed, 20 insertions, 10 deletions
diff --git a/python/proto.go b/python/proto.go
index 42987fab..2370cd26 100644
--- a/python/proto.go
+++ b/python/proto.go
@@ -30,14 +30,14 @@ var (
blueprint.RuleParams{
Command: `rm -rf $out.tmp && mkdir -p $out.tmp && ` +
`$protocCmd --python_out=$out.tmp --dependency_out=$out.d -I $protoBase $protoFlags $in && ` +
- `$parCmd -o $out -P $pkgPath -C $out.tmp -D $out.tmp && rm -rf $out.tmp`,
+ `$parCmd -o $out $pkgPathArgs -C $out.tmp -D $out.tmp && rm -rf $out.tmp`,
CommandDeps: []string{
"$protocCmd",
"$parCmd",
},
Depfile: "${out}.d",
Deps: blueprint.DepsGCC,
- }, "protoBase", "protoFlags", "pkgPath")
+ }, "protoBase", "protoFlags", "pkgPathArgs")
)
func genProto(ctx android.ModuleContext, p *android.ProtoProperties,
@@ -53,15 +53,19 @@ func genProto(ctx android.ModuleContext, p *android.ProtoProperties,
protoBase = strings.TrimSuffix(protoFile.String(), protoFile.Rel())
}
+ var pkgPathArgs string
+ if pkgPath != "" {
+ pkgPathArgs = "-P " + pkgPath
+ }
ctx.Build(pctx, android.BuildParams{
Rule: proto,
Description: "protoc " + protoFile.Rel(),
Output: srcJarFile,
Input: protoFile,
Args: map[string]string{
- "protoBase": protoBase,
- "protoFlags": strings.Join(protoFlags, " "),
- "pkgPath": pkgPath,
+ "protoBase": protoBase,
+ "protoFlags": strings.Join(protoFlags, " "),
+ "pkgPathArgs": pkgPathArgs,
},
})
diff --git a/python/python.go b/python/python.go
index a2779886..65e3efd4 100644
--- a/python/python.go
+++ b/python/python.go
@@ -420,16 +420,20 @@ func (p *Module) GeneratePythonBuildActions(ctx android.ModuleContext) {
// pkg_path starts from "internal/" implicitly.
pkgPath = filepath.Join(internal, pkgPath)
} else {
- // pkg_path starts from "runfiles/" implicitly.
- pkgPath = filepath.Join(runFiles, pkgPath)
+ if !p.isEmbeddedLauncherEnabled(p.properties.Actual_version) {
+ // pkg_path starts from "runfiles/" implicitly.
+ pkgPath = filepath.Join(runFiles, pkgPath)
+ }
}
} else {
if p.properties.Is_internal != nil && *p.properties.Is_internal {
// pkg_path starts from "runfiles/" implicitly.
pkgPath = internal
} else {
- // pkg_path starts from "runfiles/" implicitly.
- pkgPath = runFiles
+ if !p.isEmbeddedLauncherEnabled(p.properties.Actual_version) {
+ // pkg_path starts from "runfiles/" implicitly.
+ pkgPath = runFiles
+ }
}
}
@@ -520,7 +524,9 @@ func (p *Module) createSrcsZip(ctx android.ModuleContext, pkgPath string) androi
sort.Strings(keys)
parArgs := []string{}
- parArgs = append(parArgs, `-P `+pkgPath)
+ if pkgPath != "" {
+ parArgs = append(parArgs, `-P `+pkgPath)
+ }
implicits := android.Paths{}
for _, k := range keys {
parArgs = append(parArgs, `-C `+k)