diff options
author | Colin Cross <ccross@android.com> | 2015-10-29 15:25:03 -0700 |
---|---|---|
committer | Colin Cross <ccross@android.com> | 2015-11-03 15:46:08 -0800 |
commit | 6362e278481ea0cb14d31cd7fd3760116b6d7643 (patch) | |
tree | 16221aa2499c2e6ec896c3a87645b441a57c07e8 /java | |
parent | 06a931bdb6228bdbe425696b01e27522f4b00d71 (diff) | |
download | build_soong-6362e278481ea0cb14d31cd7fd3760116b6d7643.tar.gz build_soong-6362e278481ea0cb14d31cd7fd3760116b6d7643.tar.bz2 build_soong-6362e278481ea0cb14d31cd7fd3760116b6d7643.zip |
Remove EarlyMutators and DynamicDependencies
EarlyMutators are identical to BottomUpMutators, except they run before
DynamicDependencies. DynamicDependencies can be replaced with a
BottomUpMutator. Replace both EarlyMutators and DynamicDependencies
with BottomUpMutators, which allows setting the order between all
mutators through registration order.
Change-Id: Id1305d798d3d2da592061c89d7c10a71780b71a3
Diffstat (limited to 'java')
-rw-r--r-- | java/app.go | 4 | ||||
-rw-r--r-- | java/java.go | 12 |
2 files changed, 10 insertions, 6 deletions
diff --git a/java/app.go b/java/app.go index a6e651d8..74e32699 100644 --- a/java/app.go +++ b/java/app.go @@ -67,8 +67,8 @@ type AndroidApp struct { exportPackage string } -func (a *AndroidApp) JavaDynamicDependencies(ctx common.AndroidDynamicDependerModuleContext) []string { - deps := a.javaBase.JavaDynamicDependencies(ctx) +func (a *AndroidApp) JavaDependencies(ctx AndroidJavaModuleContext) []string { + deps := a.javaBase.JavaDependencies(ctx) if !a.properties.No_standard_libraries { switch a.properties.Sdk_version { // TODO: Res_sdk_version? diff --git a/java/java.go b/java/java.go index 8b50eff4..2bd5bffa 100644 --- a/java/java.go +++ b/java/java.go @@ -145,9 +145,11 @@ type javaBase struct { installFile string } +type AndroidJavaModuleContext common.AndroidBaseContext + type JavaModuleType interface { GenerateJavaBuildActions(ctx common.AndroidModuleContext) - JavaDynamicDependencies(ctx common.AndroidDynamicDependerModuleContext) []string + JavaDependencies(ctx AndroidJavaModuleContext) []string } type JavaDependency interface { @@ -191,11 +193,13 @@ func (j *javaBase) BootClasspath(ctx common.AndroidBaseContext) string { var defaultJavaLibraries = []string{"core-libart", "core-junit", "ext", "framework"} -func (j *javaBase) AndroidDynamicDependencies(ctx common.AndroidDynamicDependerModuleContext) []string { - return j.module.JavaDynamicDependencies(ctx) +func javaDepsMutator(ctx common.AndroidBottomUpMutatorContext) { + if j, ok := ctx.Module().(JavaModuleType); ok { + ctx.AddDependency(ctx.Module(), j.JavaDependencies(ctx)...) + } } -func (j *javaBase) JavaDynamicDependencies(ctx common.AndroidDynamicDependerModuleContext) []string { +func (j *javaBase) JavaDependencies(ctx AndroidJavaModuleContext) []string { var deps []string if !j.properties.No_standard_libraries { |