diff options
author | Colin Cross <ccross@android.com> | 2017-06-23 15:06:31 -0700 |
---|---|---|
committer | Colin Cross <ccross@android.com> | 2017-06-30 21:08:36 +0000 |
commit | 36242850fdad11b4e6fbe061ef30f62e7e8c08d8 (patch) | |
tree | a3ca380533afd39e733c658560f87effb1ee0a46 /java | |
parent | 48173891485a22c9cab0e48f90a3a23be212f44a (diff) | |
download | build_soong-36242850fdad11b4e6fbe061ef30f62e7e8c08d8.tar.gz build_soong-36242850fdad11b4e6fbe061ef30f62e7e8c08d8.tar.bz2 build_soong-36242850fdad11b4e6fbe061ef30f62e7e8c08d8.zip |
Refactor factories
Change module factories from returning a blueprint.Module and a list
of property structs to returning an android.Module, which holds the
list of property structs.
Test: build.ninja identical except for Factory: comment lines
Change-Id: Ica1d823f009db812c518f271a386fbff39c9766f
Diffstat (limited to 'java')
-rw-r--r-- | java/app.go | 7 | ||||
-rw-r--r-- | java/java.go | 47 |
2 files changed, 37 insertions, 17 deletions
diff --git a/java/app.go b/java/app.go index f6ccd344..2f2b899d 100644 --- a/java/app.go +++ b/java/app.go @@ -274,13 +274,16 @@ func (a *AndroidApp) aaptFlags(ctx android.ModuleContext) ([]string, android.Pat return aaptFlags, aaptDeps, hasResources } -func AndroidAppFactory() (blueprint.Module, []interface{}) { +func AndroidAppFactory() android.Module { module := &AndroidApp{} module.deviceProperties.Dex = true - return android.InitAndroidArchModule(module, android.DeviceSupported, android.MultilibCommon, + module.AddProperties( &module.Module.properties, &module.Module.deviceProperties, &module.appProperties) + + android.InitAndroidArchModule(module, android.DeviceSupported, android.MultilibCommon) + return module } diff --git a/java/java.go b/java/java.go index 20661c47..3cc552f0 100644 --- a/java/java.go +++ b/java/java.go @@ -418,21 +418,26 @@ func (j *JavaLibrary) DepsMutator(ctx android.BottomUpMutatorContext) { j.deps(ctx) } -func JavaLibraryFactory() (blueprint.Module, []interface{}) { +func JavaLibraryFactory() android.Module { module := &JavaLibrary{} module.deviceProperties.Dex = true - return android.InitAndroidArchModule(module, android.HostAndDeviceSupported, android.MultilibCommon, + module.AddProperties( &module.Module.properties, &module.Module.deviceProperties) + + android.InitAndroidArchModule(module, android.HostAndDeviceSupported, android.MultilibCommon) + return module } -func JavaLibraryHostFactory() (blueprint.Module, []interface{}) { +func JavaLibraryHostFactory() android.Module { module := &JavaLibrary{} - return android.InitAndroidArchModule(module, android.HostSupported, android.MultilibCommon, - &module.Module.properties) + module.AddProperties(&module.Module.properties) + + android.InitAndroidArchModule(module, android.HostSupported, android.MultilibCommon) + return module } // @@ -463,24 +468,30 @@ func (j *JavaBinary) DepsMutator(ctx android.BottomUpMutatorContext) { j.deps(ctx) } -func JavaBinaryFactory() (blueprint.Module, []interface{}) { +func JavaBinaryFactory() android.Module { module := &JavaBinary{} module.deviceProperties.Dex = true - return android.InitAndroidArchModule(module, android.HostAndDeviceSupported, android.MultilibCommon, + module.AddProperties( &module.Module.properties, &module.Module.deviceProperties, &module.binaryProperties) + + android.InitAndroidArchModule(module, android.HostAndDeviceSupported, android.MultilibCommon) + return module } -func JavaBinaryHostFactory() (blueprint.Module, []interface{}) { +func JavaBinaryHostFactory() android.Module { module := &JavaBinary{} - return android.InitAndroidArchModule(module, android.HostSupported, android.MultilibCommon, + module.AddProperties( &module.Module.properties, &module.Module.deviceProperties, &module.binaryProperties) + + android.InitAndroidArchModule(module, android.HostSupported, android.MultilibCommon) + return module } // @@ -536,11 +547,13 @@ func (j *JavaPrebuilt) AidlIncludeDirs() android.Paths { return nil } -func JavaPrebuiltFactory() (blueprint.Module, []interface{}) { +func JavaPrebuiltFactory() android.Module { module := &JavaPrebuilt{} - return android.InitAndroidArchModule(module, android.HostAndDeviceSupported, - android.MultilibCommon, &module.properties) + module.AddProperties(&module.properties) + + android.InitAndroidArchModule(module, android.HostAndDeviceSupported, android.MultilibCommon) + return module } // @@ -576,11 +589,15 @@ func (j *sdkPrebuilt) AidlPreprocessed() android.OptionalPath { return j.aidlPreprocessed } -func SdkPrebuiltFactory() (blueprint.Module, []interface{}) { +func SdkPrebuiltFactory() android.Module { module := &sdkPrebuilt{} - return android.InitAndroidArchModule(module, android.HostAndDeviceSupported, - android.MultilibCommon, &module.properties, &module.sdkProperties) + module.AddProperties( + &module.properties, + &module.sdkProperties) + + android.InitAndroidArchModule(module, android.HostAndDeviceSupported, android.MultilibCommon) + return module } func inList(s string, l []string) bool { |