aboutsummaryrefslogtreecommitdiffstats
path: root/dexpreopt
diff options
context:
space:
mode:
authorUlyana Trafimovich <skvadrik@google.com>2019-11-26 13:03:00 +0000
committerUlyana Trafimovich <skvadrik@google.com>2019-11-26 13:06:38 +0000
commit01f6b0a6564bc1d5d890c8626b722120cf6efda2 (patch)
tree9c88ffabb925dd8fffc0a56e0ed014470c7b3250 /dexpreopt
parent61c325ebcce0a1e2ac9149d28ae00e69a269dd93 (diff)
downloadbuild_soong-01f6b0a6564bc1d5d890c8626b722120cf6efda2.tar.gz
build_soong-01f6b0a6564bc1d5d890c8626b722120cf6efda2.tar.bz2
build_soong-01f6b0a6564bc1d5d890c8626b722120cf6efda2.zip
Revert "Do not dexpreopt system server jars from updatable modules."
This reverts commit 61c325ebcce0a1e2ac9149d28ae00e69a269dd93. Reason for revert: broken build git_master/cf_x86_phone-userdebug_coverage (likely caused by these changes). Exempt-From-Owner-Approval: revert. Change-Id: I88ddd3af3a6c4ffdaa1fbb881d965356c5c75ad3
Diffstat (limited to 'dexpreopt')
-rw-r--r--dexpreopt/dexpreopt.go17
1 files changed, 0 insertions, 17 deletions
diff --git a/dexpreopt/dexpreopt.go b/dexpreopt/dexpreopt.go
index 18a38fbd..46e0f0a0 100644
--- a/dexpreopt/dexpreopt.go
+++ b/dexpreopt/dexpreopt.go
@@ -102,13 +102,6 @@ func dexpreoptDisabled(global GlobalConfig, module ModuleConfig) bool {
return true
}
- // Don't preopt system server jars that are updatable.
- for _, p := range global.UpdatableSystemServerJars {
- if _, jar := SplitApexJarPair(p); jar == module.Name {
- return true
- }
- }
-
// If OnlyPreoptBootImageAndSystemServer=true and module is not in boot class path skip
// Also preopt system server jars since selinux prevents system server from loading anything from
// /data. If we don't do this they will need to be extracted which is not favorable for RAM usage
@@ -544,16 +537,6 @@ func makefileMatch(pattern, s string) bool {
}
}
-// Expected format for apexJarValue = <apex name>:<jar name>
-func SplitApexJarPair(apexJarValue string) (string, string) {
- var apexJarPair []string = strings.SplitN(apexJarValue, ":", 2)
- if apexJarPair == nil || len(apexJarPair) != 2 {
- panic(fmt.Errorf("malformed apexJarValue: %q, expected format: <apex>:<jar>",
- apexJarValue))
- }
- return apexJarPair[0], apexJarPair[1]
-}
-
func contains(l []string, s string) bool {
for _, e := range l {
if e == s {