diff options
author | Colin Cross <ccross@android.com> | 2017-08-10 17:00:19 -0700 |
---|---|---|
committer | Colin Cross <ccross@android.com> | 2017-08-11 15:24:11 -0700 |
commit | a18e9cfa29d22949d2c005fe2b51c5ffa2bf6379 (patch) | |
tree | fd4733237ef52794c6a0d2e5b63e617b93613b06 /cc | |
parent | 91825d2279fb9066ec6ffd4ce2070eb070ce38cf (diff) | |
download | build_soong-a18e9cfa29d22949d2c005fe2b51c5ffa2bf6379.tar.gz build_soong-a18e9cfa29d22949d2c005fe2b51c5ffa2bf6379.tar.bz2 build_soong-a18e9cfa29d22949d2c005fe2b51c5ffa2bf6379.zip |
Remove error from AndroidMkDataProvider.AndroidMk
It's never anything except nil, and it unnecessarily complicates
the implementations.
Test: m -j checkbuild
Change-Id: I3e3b7251f32ffa84dbdfd0448faf248c306ca808
Diffstat (limited to 'cc')
-rw-r--r-- | cc/androidmk.go | 47 |
1 files changed, 26 insertions, 21 deletions
diff --git a/cc/androidmk.go b/cc/androidmk.go index 561a0a31..4421b1c4 100644 --- a/cc/androidmk.go +++ b/cc/androidmk.go @@ -49,29 +49,34 @@ func (c *Module) subAndroidMk(data *android.AndroidMkData, obj interface{}) { } } -func (c *Module) AndroidMk() (ret android.AndroidMkData, err error) { +func (c *Module) AndroidMk() android.AndroidMkData { if c.Properties.HideFromMake { - ret.Disabled = true - return ret, nil + return android.AndroidMkData{ + Disabled: true, + } } - ret.OutputFile = c.outputFile - ret.Extra = append(ret.Extra, func(w io.Writer, outputFile android.Path) { - fmt.Fprintln(w, "LOCAL_SANITIZE := never") - if len(c.Properties.AndroidMkSharedLibs) > 0 { - fmt.Fprintln(w, "LOCAL_SHARED_LIBRARIES := "+strings.Join(c.Properties.AndroidMkSharedLibs, " ")) - } - if c.Target().Os == android.Android && c.Properties.Sdk_version != "" && !c.vndk() { - fmt.Fprintln(w, "LOCAL_SDK_VERSION := "+c.Properties.Sdk_version) - fmt.Fprintln(w, "LOCAL_NDK_STL_VARIANT := none") - } else { - // These are already included in LOCAL_SHARED_LIBRARIES - fmt.Fprintln(w, "LOCAL_CXX_STL := none") - } - if c.vndk() { - fmt.Fprintln(w, "LOCAL_USE_VNDK := true") - } - }) + ret := android.AndroidMkData{ + OutputFile: c.outputFile, + Extra: []android.AndroidMkExtraFunc{ + func(w io.Writer, outputFile android.Path) { + fmt.Fprintln(w, "LOCAL_SANITIZE := never") + if len(c.Properties.AndroidMkSharedLibs) > 0 { + fmt.Fprintln(w, "LOCAL_SHARED_LIBRARIES := "+strings.Join(c.Properties.AndroidMkSharedLibs, " ")) + } + if c.Target().Os == android.Android && c.Properties.Sdk_version != "" && !c.vndk() { + fmt.Fprintln(w, "LOCAL_SDK_VERSION := "+c.Properties.Sdk_version) + fmt.Fprintln(w, "LOCAL_NDK_STL_VARIANT := none") + } else { + // These are already included in LOCAL_SHARED_LIBRARIES + fmt.Fprintln(w, "LOCAL_CXX_STL := none") + } + if c.vndk() { + fmt.Fprintln(w, "LOCAL_USE_VNDK := true") + } + }, + }, + } for _, feature := range c.features { c.subAndroidMk(&ret, feature) @@ -90,7 +95,7 @@ func (c *Module) AndroidMk() (ret android.AndroidMkData, err error) { ret.SubName += vendorSuffix } - return ret, nil + return ret } func androidMkWriteTestData(data android.Paths, ctx AndroidMkContext, ret *android.AndroidMkData) { |