diff options
| author | Pirama Arumuga Nainar <pirama@google.com> | 2017-08-28 21:50:17 -0700 |
|---|---|---|
| committer | Pirama Arumuga Nainar <pirama@google.com> | 2017-11-02 23:37:28 -0700 |
| commit | bdb17f068c35c48370f3c3b7a564128d66c466ff (patch) | |
| tree | 72f490188dbe246bd12c58229e82fd77b29f8ed3 /cc | |
| parent | f9e621603b769401732adfdfda1d509d27190cc7 (diff) | |
| download | build_soong-bdb17f068c35c48370f3c3b7a564128d66c466ff.tar.gz build_soong-bdb17f068c35c48370f3c3b7a564128d66c466ff.tar.bz2 build_soong-bdb17f068c35c48370f3c3b7a564128d66c466ff.zip | |
Remove CFI-related WARs that seem no longer necessary
Bug: http://b/33678192
Clang has been updated past the revisions mentioned in the work arounds.
So these seem no longer necessary.
Test: Build
Change-Id: I08fee0db7c5785836a1ad0104688245435865cb7
Diffstat (limited to 'cc')
| -rw-r--r-- | cc/sanitize.go | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/cc/sanitize.go b/cc/sanitize.go index 9e1f02f7..5d7f617e 100644 --- a/cc/sanitize.go +++ b/cc/sanitize.go @@ -34,9 +34,8 @@ var ( cfiCflags = []string{"-flto", "-fsanitize-cfi-cross-dso", "-fsanitize-blacklist=external/compiler-rt/lib/cfi/cfi_blacklist.txt"} - // FIXME: revert the __cfi_check flag when clang is updated to r280031. cfiLdflags = []string{"-flto", "-fsanitize-cfi-cross-dso", "-fsanitize=cfi", - "-Wl,-plugin-opt,O1 -Wl,-export-dynamic-symbol=__cfi_check"} + "-Wl,-plugin-opt,O1"} cfiArflags = []string{"--plugin ${config.ClangBin}/../lib64/LLVMgold.so"} cfiExportsMapPath = "build/soong/cc/config/cfi_exports.map" cfiExportsMap android.Path @@ -364,9 +363,6 @@ func (sanitize *sanitize) flags(ctx ModuleContext, flags Flags) Flags { // __cfi_check needs to be built as Thumb (see the code in linker_cfi.cpp). LLVM is not set up // to do this on a function basis, so force Thumb on the entire module. flags.RequiredInstructionSet = "thumb" - // Workaround for b/33678192. CFI jumptables need Thumb2 codegen. Revert when - // Clang is updated past r290384. - flags.LdFlags = append(flags.LdFlags, "-march=armv7-a") } sanitizers = append(sanitizers, "cfi") |