diff options
| author | Jayant Chowdhary <jchowdhary@google.com> | 2017-09-06 13:10:03 -0700 |
|---|---|---|
| committer | Jayant Chowdhary <jchowdhary@google.com> | 2017-09-11 17:36:46 -0700 |
| commit | a4fce191baa9828792f8ddac5b2f65ea65d737a5 (patch) | |
| tree | 957a10ef68ab4d14e02412918c1d7ad2c1103768 /cc/sabi.go | |
| parent | 4f26bc0263fb15d8edabe938337e3cfad6ee6862 (diff) | |
| download | build_soong-a4fce191baa9828792f8ddac5b2f65ea65d737a5.tar.gz build_soong-a4fce191baa9828792f8ddac5b2f65ea65d737a5.tar.bz2 build_soong-a4fce191baa9828792f8ddac5b2f65ea65d737a5.zip | |
Dump abi for vendor variants of VNDK libraries.
Currently, abi is dumped for platform variants of system libraries.
Dump them for vendor variants since they are the ones which need to be abi
stable on security updates. This also ties abi dumping to BOARD_VNDK_VERSION.
Test: For libfoo:
1) Added a source file with a dummy function for the core
variant.
2) Excluded the source file from the vendor variant.
3) BOARD_VNDK_VERSION=current mm -j64 produces libfoo.so.lsdump with no
dummy_function since the source file was not included in the vendor
variant.
Test: Inspected build.ninja and confirmed that all of a library's abi
dump dependencies (.sdump files are dependencies of the final .lsdump files) are
from vendor variants.
Change-Id: Ie0bf91fcd81606c131845d9872261166b5db72aa
Diffstat (limited to 'cc/sabi.go')
| -rw-r--r-- | cc/sabi.go | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -79,7 +79,7 @@ func (sabimod *sabi) flags(ctx ModuleContext, flags Flags) Flags { func sabiDepsMutator(mctx android.TopDownMutatorContext) { if c, ok := mctx.Module().(*Module); ok && - (c.isVndk() || inList(c.Name(), llndkLibraries) || + ((c.isVndk() && c.vndk()) || inList(c.Name(), llndkLibraries) || (c.sabi != nil && c.sabi.Properties.CreateSAbiDumps)) { mctx.VisitDirectDeps(func(m blueprint.Module) { tag := mctx.OtherModuleDependencyTag(m) |