aboutsummaryrefslogtreecommitdiffstats
path: root/androidmk
diff options
context:
space:
mode:
authorJeff Gaston <jeffrygaston@google.com>2017-05-23 17:24:53 -0700
committerJeff Gaston <jeffrygaston@google.com>2017-05-24 13:06:35 -0700
commit7fd905ae26ac2cb9333a81feb928df339c5b4bc4 (patch)
treede02ef8c49daeb401ad2bdb2463ca4df2dea28ea /androidmk
parentde4b0463f220c069af1aa10d594b39ceafdfa78b (diff)
downloadbuild_soong-7fd905ae26ac2cb9333a81feb928df339c5b4bc4.tar.gz
build_soong-7fd905ae26ac2cb9333a81feb928df339c5b4bc4.tar.bz2
build_soong-7fd905ae26ac2cb9333a81feb928df339c5b4bc4.zip
Run bpfix at the end of androidmk
Bug: 38351765 Test: androidmk Android.mk > Android.bp Change-Id: Iefcae1b01f4e915ec20782b302ba4350a20d0f1a
Diffstat (limited to 'androidmk')
-rw-r--r--androidmk/Android.bp1
-rw-r--r--androidmk/cmd/androidmk/androidmk.go14
2 files changed, 13 insertions, 2 deletions
diff --git a/androidmk/Android.bp b/androidmk/Android.bp
index 67baf0ae..442452f8 100644
--- a/androidmk/Android.bp
+++ b/androidmk/Android.bp
@@ -29,6 +29,7 @@ blueprint_go_binary {
deps: [
"androidmk-parser",
"blueprint-parser",
+ "bpfix-lib",
],
}
diff --git a/androidmk/cmd/androidmk/androidmk.go b/androidmk/cmd/androidmk/androidmk.go
index 1d94b65e..d26643ae 100644
--- a/androidmk/cmd/androidmk/androidmk.go
+++ b/androidmk/cmd/androidmk/androidmk.go
@@ -8,6 +8,8 @@ import (
"strings"
"text/scanner"
+ "android/soong/bpfix/bpfix"
+
mkparser "android/soong/androidmk/parser"
bpparser "github.com/google/blueprint/parser"
@@ -176,10 +178,18 @@ func convertFile(filename string, buffer *bytes.Buffer) (string, []error) {
}
}
- out, err := bpparser.Print(&bpparser.File{
+ tree := &bpparser.File{
Defs: file.defs,
Comments: file.comments,
- })
+ }
+
+ // check for common supported but undesirable structures and clean them up
+ fixed, err := bpfix.FixTree(tree, bpfix.NewFixRequest().AddAll())
+ if err != nil {
+ return "", []error{err}
+ }
+
+ out, err := bpparser.Print(fixed)
if err != nil {
return "", []error{err}
}