diff options
author | Jaewoong Jung <jungjw@google.com> | 2019-03-27 16:13:22 -0700 |
---|---|---|
committer | android-build-merger <android-build-merger@google.com> | 2019-03-27 16:13:22 -0700 |
commit | a4edf844da9991a9584f612cbe220458b7cb4574 (patch) | |
tree | 931a28ea41b478e8309aa9e5ea3059da28d7c134 /android | |
parent | 1093f63255c192024f82bf072b9ee14e95991578 (diff) | |
parent | ac24969630a0bbc67c593784cc6070cb11be7070 (diff) | |
download | build_soong-a4edf844da9991a9584f612cbe220458b7cb4574.tar.gz build_soong-a4edf844da9991a9584f612cbe220458b7cb4574.tar.bz2 build_soong-a4edf844da9991a9584f612cbe220458b7cb4574.zip |
Merge "Fix an override_module bug." am: 044ead6b1a am: 5ce95f2eaf
am: ac24969630
Change-Id: I352a380486600c0b48a61daa0457eff09ceb8f66
Diffstat (limited to 'android')
-rw-r--r-- | android/override_module.go | 14 |
1 files changed, 6 insertions, 8 deletions
diff --git a/android/override_module.go b/android/override_module.go index 02db359f..119bca1c 100644 --- a/android/override_module.go +++ b/android/override_module.go @@ -134,10 +134,15 @@ func (b *OverridableModuleBase) setOverridesProperty(overridesProperty *[]string // Overrides a base module with the given OverrideModule. func (b *OverridableModuleBase) override(ctx BaseModuleContext, o OverrideModule) { + // Adds the base module to the overrides property, if exists, of the overriding module. See the + // comment on OverridableModuleBase.overridesProperty for details. + if b.overridesProperty != nil { + *b.overridesProperty = append(*b.overridesProperty, b.Name()) + } for _, p := range b.overridableProperties { for _, op := range o.getOverridingProperties() { if proptools.TypeEqual(p, op) { - err := proptools.PrependProperties(p, op, nil) + err := proptools.AppendProperties(p, op, nil) if err != nil { if propertyErr, ok := err.(*proptools.ExtendPropertyError); ok { ctx.PropertyErrorf(propertyErr.Property, "%s", propertyErr.Err.Error()) @@ -148,13 +153,6 @@ func (b *OverridableModuleBase) override(ctx BaseModuleContext, o OverrideModule } } } - // Adds the base module to the overrides property, if exists, of the overriding module. See the - // comment on OverridableModuleBase.overridesProperty for details. - if b.overridesProperty != nil { - *b.overridesProperty = append(*b.overridesProperty, b.Name()) - } - // The base module name property has to be updated separately for Name() to work as intended. - b.module.base().nameProperties.Name = proptools.StringPtr(o.Name()) } // Mutators for override/overridable modules. All the fun happens in these functions. It is critical |