diff options
author | Kimberly Kreider <kkreider@google.com> | 2019-12-18 21:51:36 +0000 |
---|---|---|
committer | Kimberly Kreider <kkreider@google.com> | 2019-12-19 23:57:58 +0000 |
commit | 67e2fce5937430e2384a984fa98f77b79218fe96 (patch) | |
tree | 141c67c0178f9a7755042bf2de1b97a3d6fda5d7 | |
parent | 853f5c9edd4bf1e7888bc9504661a28ebeace861 (diff) | |
download | build_soong-67e2fce5937430e2384a984fa98f77b79218fe96.tar.gz build_soong-67e2fce5937430e2384a984fa98f77b79218fe96.tar.bz2 build_soong-67e2fce5937430e2384a984fa98f77b79218fe96.zip |
Revert submission 9919844-manual r1 merge
Reason for revert: broke tests b/146476630
Bug: 146476630
Reverted Changes:
Change-Id: I66b0f86dfc6336fa0dd88e6e4c340744a4791efd
-rw-r--r-- | Android.bp | 1 | ||||
-rw-r--r-- | java/java.go | 8 | ||||
-rw-r--r-- | java/tradefed.go | 37 |
3 files changed, 1 insertions, 45 deletions
@@ -280,7 +280,6 @@ bootstrap_go_package { "java/support_libraries.go", "java/system_modules.go", "java/testing.go", - "java/tradefed.go", ], testSrcs: [ "java/app_test.go", diff --git a/java/java.go b/java/java.go index 480518e7..bf738c4d 100644 --- a/java/java.go +++ b/java/java.go @@ -1465,8 +1465,6 @@ func (j *Module) CompilerDeps() []string { type Library struct { Module - - InstallMixin func(ctx android.ModuleContext, installPath android.Path) (extraInstallDeps android.Paths) } func shouldUncompressDex(ctx android.ModuleContext, dexpreopter *dexpreopter) bool { @@ -1496,12 +1494,8 @@ func (j *Library) GenerateAndroidBuildActions(ctx android.ModuleContext) { j.compile(ctx) if (Bool(j.properties.Installable) || ctx.Host()) && !android.DirectlyInAnyApex(ctx, ctx.ModuleName()) { - var extraInstallDeps android.Paths - if j.InstallMixin != nil { - extraInstallDeps = j.InstallMixin(ctx, j.outputFile) - } j.installFile = ctx.InstallFile(android.PathForModuleInstall(ctx, "framework"), - ctx.ModuleName()+".jar", j.outputFile, extraInstallDeps...) + ctx.ModuleName()+".jar", j.outputFile) } } diff --git a/java/tradefed.go b/java/tradefed.go deleted file mode 100644 index ebbdec13..00000000 --- a/java/tradefed.go +++ /dev/null @@ -1,37 +0,0 @@ -// Copyright 2019 Google Inc. All rights reserved. -// -// Licensed under the Apache License, Version 2.0 (the "License"); -// you may not use this file except in compliance with the License. -// You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, software -// distributed under the License is distributed on an "AS IS" BASIS, -// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -// See the License for the specific language governing permissions and -// limitations under the License. - -package java - -import ( - "android/soong/android" -) - -func init() { - android.RegisterModuleType("tradefed_java_library_host", tradefedJavaLibraryFactory) -} - -// tradefed_java_library_factory wraps java_library and installs an additional -// copy of the output jar to $HOST_OUT/tradefed. -func tradefedJavaLibraryFactory() android.Module { - module := LibraryHostFactory().(*Library) - module.InstallMixin = tradefedJavaLibraryInstall - return module -} - -func tradefedJavaLibraryInstall(ctx android.ModuleContext, path android.Path) android.Paths { - installedPath := ctx.InstallFile(android.PathForModuleInstall(ctx, "tradefed"), - ctx.ModuleName()+".jar", path) - return android.Paths{installedPath} -} |