diff options
author | Dan Willemsen <dwillemsen@google.com> | 2016-11-18 14:54:24 -0800 |
---|---|---|
committer | Dan Willemsen <dwillemsen@google.com> | 2016-11-28 13:45:24 -0800 |
commit | d2ede879b5027413b288be92bdc4f320124c5d3c (patch) | |
tree | fad2da22ce685b05ff4042ab86941b260e69b801 | |
parent | 112fd2b9b1ad51d5a7c17a4859fda75592d6ef93 (diff) | |
download | build_soong-d2ede879b5027413b288be92bdc4f320124c5d3c.tar.gz build_soong-d2ede879b5027413b288be92bdc4f320124c5d3c.tar.bz2 build_soong-d2ede879b5027413b288be92bdc4f320124c5d3c.zip |
Add basic VNDK support in Soong
Export a list of libraries in the VNDK, which is currently empty.
Take in Make's global BOARD_VNDK_VERSION, and use that as the SDK
version for modules that specify use_vndk: true.
Modules that use the vndk have some configuration as if they were
building against the NDK (the absence of globally defined headers), but
in other cases look like platform modules (using the platform libc++,
for now).
This change does not attempt to enforce any linking constraints, that
will come in a later patch.
Test: out/soong/build.ninja doesn't change
Change-Id: I3be206b67015ac5177b7eef4a451c579e3dc903f
-rw-r--r-- | android/config.go | 7 | ||||
-rw-r--r-- | android/variable.go | 1 | ||||
-rw-r--r-- | androidmk/cmd/androidmk/android.go | 1 | ||||
-rw-r--r-- | cc/androidmk.go | 3 | ||||
-rw-r--r-- | cc/binary.go | 2 | ||||
-rw-r--r-- | cc/cc.go | 31 | ||||
-rw-r--r-- | cc/compiler.go | 6 | ||||
-rw-r--r-- | cc/config/global.go | 4 | ||||
-rw-r--r-- | cc/library.go | 2 | ||||
-rw-r--r-- | cc/makevars.go | 7 |
10 files changed, 57 insertions, 7 deletions
diff --git a/android/config.go b/android/config.go index 725f43de..fdc7375e 100644 --- a/android/config.go +++ b/android/config.go @@ -424,3 +424,10 @@ func (c *deviceConfig) Arches() []Arch { } return arches } + +func (c *deviceConfig) VndkVersion() string { + if c.config.ProductVariables.DeviceVndkVersion == nil { + return "" + } + return *c.config.ProductVariables.DeviceVndkVersion +} diff --git a/android/variable.go b/android/variable.go index c1948b0b..3436a75e 100644 --- a/android/variable.go +++ b/android/variable.go @@ -87,6 +87,7 @@ type productVariables struct { DeviceCpuVariant *string `json:",omitempty"` DeviceAbi *[]string `json:",omitempty"` DeviceUsesClang *bool `json:",omitempty"` + DeviceVndkVersion *string `json:",omitempty"` DeviceSecondaryArch *string `json:",omitempty"` DeviceSecondaryArchVariant *string `json:",omitempty"` diff --git a/androidmk/cmd/androidmk/android.go b/androidmk/cmd/androidmk/android.go index 6387ff1b..5d9f1b41 100644 --- a/androidmk/cmd/androidmk/android.go +++ b/androidmk/cmd/androidmk/android.go @@ -77,6 +77,7 @@ var standardProperties = map[string]struct { "LOCAL_NO_STANDARD_LIBRARIES": {"no_standard_libraries", bpparser.BoolType}, "LOCAL_PACK_MODULE_RELOCATIONS": {"pack_relocations", bpparser.BoolType}, "LOCAL_TIDY": {"tidy", bpparser.BoolType}, + "LOCAL_USE_VNDK": {"use_vndk", bpparser.BoolType}, "LOCAL_EXPORT_PACKAGE_RESOURCES": {"export_package_resources", bpparser.BoolType}, } diff --git a/cc/androidmk.go b/cc/androidmk.go index 50c183e9..709ac59b 100644 --- a/cc/androidmk.go +++ b/cc/androidmk.go @@ -59,6 +59,9 @@ func (c *Module) AndroidMk() (ret android.AndroidMkData, err error) { if c.Target().Os == android.Android && c.Properties.Sdk_version != "" { fmt.Fprintln(w, "LOCAL_SDK_VERSION := "+c.Properties.Sdk_version) fmt.Fprintln(w, "LOCAL_NDK_STL_VARIANT := none") + } else if c.Target().Os == android.Android && c.Properties.Use_vndk { + fmt.Fprintln(w, "LOCAL_USE_VNDK := true") + fmt.Fprintln(w, "LOCAL_NDK_STL_VARIANT := none") } else { // These are already included in LOCAL_SHARED_LIBRARIES fmt.Fprintln(w, "LOCAL_CXX_STL := none") diff --git a/cc/binary.go b/cc/binary.go index 2b775149..1aba6eb6 100644 --- a/cc/binary.go +++ b/cc/binary.go @@ -93,7 +93,7 @@ func (binary *binaryDecorator) linkerDeps(ctx BaseModuleContext, deps Deps) Deps deps = binary.baseLinker.linkerDeps(ctx, deps) if ctx.toolchain().Bionic() { if !Bool(binary.baseLinker.Properties.Nocrt) { - if !ctx.sdk() { + if !ctx.sdk() && !ctx.vndk() { if binary.static() { deps.CrtBegin = "crtbegin_static" } else { @@ -125,6 +125,9 @@ type BaseProperties struct { // Minimum sdk version supported when compiling against the ndk Sdk_version string + // Whether to compile against the VNDK + Use_vndk bool + // don't insert default compiler flags into asflags, cflags, // cppflags, conlyflags, ldflags, or include_dirs No_default_compiler_flags *bool @@ -132,6 +135,7 @@ type BaseProperties struct { AndroidMkSharedLibs []string `blueprint:"mutated"` HideFromMake bool `blueprint:"mutated"` PreventInstall bool `blueprint:"mutated"` + Vndk_version string `blueprint:"mutated"` } type UnusedProperties struct { @@ -147,6 +151,7 @@ type ModuleContextIntf interface { noDefaultCompilerFlags() bool sdk() bool sdkVersion() string + vndk() bool selectedStl() string baseModuleName() string } @@ -345,11 +350,22 @@ func (ctx *moduleContextImpl) sdk() bool { func (ctx *moduleContextImpl) sdkVersion() string { if ctx.ctx.Device() { - return ctx.mod.Properties.Sdk_version + if ctx.mod.Properties.Use_vndk { + return ctx.mod.Properties.Vndk_version + } else { + return ctx.mod.Properties.Sdk_version + } } return "" } +func (ctx *moduleContextImpl) vndk() bool { + if ctx.ctx.Device() { + return ctx.mod.Properties.Use_vndk + } + return false +} + func (ctx *moduleContextImpl) selectedStl() string { if stl := ctx.mod.stl; stl != nil { return stl.Properties.SelectedStl @@ -493,11 +509,22 @@ func (c *Module) begin(ctx BaseModuleContext) { feature.begin(ctx) } if ctx.sdk() { + if ctx.vndk() { + ctx.PropertyErrorf("use_vndk", + "sdk_version and use_vndk cannot be used at the same time") + } + version, err := normalizeNdkApiLevel(ctx.sdkVersion(), ctx.Arch()) if err != nil { ctx.PropertyErrorf("sdk_version", err.Error()) } c.Properties.Sdk_version = version + } else if ctx.vndk() { + version, err := normalizeNdkApiLevel(ctx.DeviceConfig().VndkVersion(), ctx.Arch()) + if err != nil { + ctx.ModuleErrorf("Bad BOARD_VNDK_VERSION: %s", err.Error()) + } + c.Properties.Vndk_version = version } } @@ -579,7 +606,7 @@ func (c *Module) DepsMutator(actx android.BottomUpMutatorContext) { variantNdkLibs := []string{} variantLateNdkLibs := []string{} - if ctx.sdk() { + if ctx.sdk() || ctx.vndk() { version := ctx.sdkVersion() // Rewrites the names of shared libraries into the names of the NDK diff --git a/cc/compiler.go b/cc/compiler.go index 285bb692..def8d58c 100644 --- a/cc/compiler.go +++ b/cc/compiler.go @@ -160,7 +160,7 @@ func (compiler *baseCompiler) compilerFlags(ctx ModuleContext, flags Flags) Flag } if !ctx.noDefaultCompilerFlags() { - if !ctx.sdk() || ctx.Host() { + if !(ctx.sdk() || ctx.vndk()) || ctx.Host() { flags.GlobalFlags = append(flags.GlobalFlags, "${config.CommonGlobalIncludes}", "${config.CommonGlobalSystemIncludes}", @@ -171,7 +171,7 @@ func (compiler *baseCompiler) compilerFlags(ctx ModuleContext, flags Flags) Flag flags.GlobalFlags = append(flags.GlobalFlags, "-I"+android.PathForModuleSrc(ctx).String()) } - if ctx.sdk() { + if ctx.sdk() || ctx.vndk() { // The NDK headers are installed to a common sysroot. While a more // typical Soong approach would be to only make the headers for the // library you're using available, we're trying to emulate the NDK @@ -354,7 +354,7 @@ func (compiler *baseCompiler) hasSrcExt(ext string) bool { var gnuToCReplacer = strings.NewReplacer("gnu", "c") func ndkPathDeps(ctx ModuleContext) android.Paths { - if ctx.sdk() { + if ctx.sdk() || ctx.vndk() { // The NDK sysroot timestamp file depends on all the NDK sysroot files // (headers and libraries). return android.Paths{getNdkSysrootTimestampFile(ctx)} diff --git a/cc/config/global.go b/cc/config/global.go index e454c16a..71c0da41 100644 --- a/cc/config/global.go +++ b/cc/config/global.go @@ -163,3 +163,7 @@ func bionicHeaders(bionicArch, kernelArch string) string { "-isystem bionic/libc/kernel/android/uapi", }, " ") } + +func VndkLibraries() []string { + return []string{} +} diff --git a/cc/library.go b/cc/library.go index 35d0089e..7b7ac952 100644 --- a/cc/library.go +++ b/cc/library.go @@ -331,7 +331,7 @@ func (library *libraryDecorator) linkerDeps(ctx BaseModuleContext, deps Deps) De deps.SharedLibs = append(deps.SharedLibs, library.Properties.Static.Shared_libs...) } else { if ctx.toolchain().Bionic() && !Bool(library.baseLinker.Properties.Nocrt) { - if !ctx.sdk() { + if !ctx.sdk() && !ctx.vndk() { deps.CrtBegin = "crtbegin_so" deps.CrtEnd = "crtend_so" } else { diff --git a/cc/makevars.go b/cc/makevars.go index 7f1063f3..fe3440c3 100644 --- a/cc/makevars.go +++ b/cc/makevars.go @@ -45,6 +45,13 @@ func makeVarsProvider(ctx android.MakeVarsContext) { ctx.Strict("GLOBAL_CLANG_CPPFLAGS_NO_OVERRIDE", "") ctx.Strict("NDK_PREBUILT_SHARED_LIBRARIES", strings.Join(ndkPrebuiltSharedLibs, " ")) + if ctx.Config().ProductVariables.DeviceVndkVersion != nil { + ctx.Strict("BOARD_VNDK_VERSION", *ctx.Config().ProductVariables.DeviceVndkVersion) + } else { + ctx.Strict("BOARD_VNDK_VERSION", "") + } + ctx.Strict("VNDK_LIBRARIES", strings.Join(config.VndkLibraries(), " ")) + ctx.Strict("ADDRESS_SANITIZER_CONFIG_EXTRA_CFLAGS", asanCflags) ctx.Strict("ADDRESS_SANITIZER_CONFIG_EXTRA_LDFLAGS", asanLdflags) ctx.Strict("ADDRESS_SANITIZER_CONFIG_EXTRA_STATIC_LIBRARIES", asanLibs) |