diff options
author | Julien Desprez <jdesprez@google.com> | 2019-03-02 00:44:54 +0000 |
---|---|---|
committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | 2019-03-02 00:44:54 +0000 |
commit | afbddd8ddd1af593fbb4978f89d967d45b1a2c5c (patch) | |
tree | 3e338ae6b0c540a6cb1036d4123367f73f6b74bd | |
parent | 29496d750b00cca2426a51c224d92fa7541ad5ff (diff) | |
parent | eb7398ea79b5a480c46ae0c3bba87ba3e1953fdc (diff) | |
download | build_soong-afbddd8ddd1af593fbb4978f89d967d45b1a2c5c.tar.gz build_soong-afbddd8ddd1af593fbb4978f89d967d45b1a2c5c.tar.bz2 build_soong-afbddd8ddd1af593fbb4978f89d967d45b1a2c5c.zip |
Merge "Autogenerate some extra_options based on some build properties"
-rw-r--r-- | cc/test.go | 7 | ||||
-rw-r--r-- | tradefed/autogen.go | 52 |
2 files changed, 42 insertions, 17 deletions
@@ -243,8 +243,13 @@ func (test *testBinary) linkerFlags(ctx ModuleContext, flags Flags) Flags { func (test *testBinary) install(ctx ModuleContext, file android.Path) { test.data = ctx.ExpandSources(test.Properties.Data, nil) + optionsMap := map[string]string{} + if Bool(test.testDecorator.Properties.Isolated) { + optionsMap["not-shardable"] = "true" + } test.testConfig = tradefed.AutoGenNativeTestConfig(ctx, test.Properties.Test_config, - test.Properties.Test_config_template, test.Properties.Test_suites) + test.Properties.Test_config_template, + test.Properties.Test_suites, optionsMap) test.binaryDecorator.baseInstaller.dir = "nativetest" test.binaryDecorator.baseInstaller.dir64 = "nativetest64" diff --git a/tradefed/autogen.go b/tradefed/autogen.go index cfa7164b..6d9c2003 100644 --- a/tradefed/autogen.go +++ b/tradefed/autogen.go @@ -15,7 +15,12 @@ package tradefed import ( + "fmt" + "sort" + "strings" + "github.com/google/blueprint" + "github.com/google/blueprint/proptools" "android/soong/android" ) @@ -34,9 +39,9 @@ func getTestConfig(ctx android.ModuleContext, prop *string) android.Path { } var autogenTestConfig = pctx.StaticRule("autogenTestConfig", blueprint.RuleParams{ - Command: "sed 's&{MODULE}&${name}&g' $template > $out", + Command: "sed 's&{MODULE}&${name}&g;s&{EXTRA_OPTIONS}&'${extraOptions}'&g' $template > $out", CommandDeps: []string{"$template"}, -}, "name", "template") +}, "name", "template", "extraOptions") func testConfigPath(ctx android.ModuleContext, prop *string, testSuites []string) (path android.Path, autogenPath android.WritablePath) { if p := getTestConfig(ctx, prop); p != nil { @@ -52,30 +57,45 @@ func testConfigPath(ctx android.ModuleContext, prop *string, testSuites []string } } -func autogenTemplate(ctx android.ModuleContext, output android.WritablePath, template string) { +func autogenTemplate(ctx android.ModuleContext, output android.WritablePath, template string, optionsMap map[string]string) { + // If no test option found, delete {EXTRA_OPTIONS} line. + var options []string + for optionName, value := range optionsMap { + if value != "" { + options = append(options, fmt.Sprintf(`<option name="%s" value="%s" />`, optionName, value)) + } + } + sort.Strings(options) + extraOptions := strings.Join(options, "\n ") + extraOptions = proptools.NinjaAndShellEscape([]string{extraOptions})[0] + ctx.Build(pctx, android.BuildParams{ Rule: autogenTestConfig, Description: "test config", Output: output, Args: map[string]string{ - "name": ctx.ModuleName(), - "template": template, + "name": ctx.ModuleName(), + "template": template, + "extraOptions": extraOptions, }, }) } func AutoGenNativeTestConfig(ctx android.ModuleContext, testConfigProp *string, - testConfigTemplateProp *string, testSuites []string) android.Path { + testConfigTemplateProp *string, testSuites []string, + optionsMap map[string]string) android.Path { path, autogenPath := testConfigPath(ctx, testConfigProp, testSuites) if autogenPath != nil { templatePath := getTestConfigTemplate(ctx, testConfigTemplateProp) if templatePath.Valid() { - autogenTemplate(ctx, autogenPath, templatePath.String()) + autogenTemplate(ctx, autogenPath, templatePath.String(), optionsMap) } else { if ctx.Device() { - autogenTemplate(ctx, autogenPath, "${NativeTestConfigTemplate}") + autogenTemplate(ctx, autogenPath, "${NativeTestConfigTemplate}", + optionsMap) } else { - autogenTemplate(ctx, autogenPath, "${NativeHostTestConfigTemplate}") + autogenTemplate(ctx, autogenPath, "${NativeHostTestConfigTemplate}", + optionsMap) } } return autogenPath @@ -89,9 +109,9 @@ func AutoGenNativeBenchmarkTestConfig(ctx android.ModuleContext, testConfigProp if autogenPath != nil { templatePath := getTestConfigTemplate(ctx, testConfigTemplateProp) if templatePath.Valid() { - autogenTemplate(ctx, autogenPath, templatePath.String()) + autogenTemplate(ctx, autogenPath, templatePath.String(), nil) } else { - autogenTemplate(ctx, autogenPath, "${NativeBenchmarkTestConfigTemplate}") + autogenTemplate(ctx, autogenPath, "${NativeBenchmarkTestConfigTemplate}", nil) } return autogenPath } @@ -103,12 +123,12 @@ func AutoGenJavaTestConfig(ctx android.ModuleContext, testConfigProp *string, te if autogenPath != nil { templatePath := getTestConfigTemplate(ctx, testConfigTemplateProp) if templatePath.Valid() { - autogenTemplate(ctx, autogenPath, templatePath.String()) + autogenTemplate(ctx, autogenPath, templatePath.String(), nil) } else { if ctx.Device() { - autogenTemplate(ctx, autogenPath, "${JavaTestConfigTemplate}") + autogenTemplate(ctx, autogenPath, "${JavaTestConfigTemplate}", nil) } else { - autogenTemplate(ctx, autogenPath, "${JavaHostTestConfigTemplate}") + autogenTemplate(ctx, autogenPath, "${JavaHostTestConfigTemplate}", nil) } } return autogenPath @@ -123,9 +143,9 @@ func AutoGenPythonBinaryHostTestConfig(ctx android.ModuleContext, testConfigProp if autogenPath != nil { templatePath := getTestConfigTemplate(ctx, testConfigTemplateProp) if templatePath.Valid() { - autogenTemplate(ctx, autogenPath, templatePath.String()) + autogenTemplate(ctx, autogenPath, templatePath.String(), nil) } else { - autogenTemplate(ctx, autogenPath, "${PythonBinaryHostTestConfigTemplate}") + autogenTemplate(ctx, autogenPath, "${PythonBinaryHostTestConfigTemplate}", nil) } return autogenPath } |