diff options
author | Colin Cross <ccross@android.com> | 2019-02-28 11:00:01 -0800 |
---|---|---|
committer | Colin Cross <ccross@android.com> | 2019-03-04 18:11:53 +0000 |
commit | 0b9f31fb0834fd84bc4d5e3b99d67e80e6e2224d (patch) | |
tree | 822385829aba1ce8d913e4c8d9637cf7320015f7 | |
parent | 7abf560cb0028bf8413a35f2fa71a4d528b6da67 (diff) | |
download | build_soong-0b9f31fb0834fd84bc4d5e3b99d67e80e6e2224d.tar.gz build_soong-0b9f31fb0834fd84bc4d5e3b99d67e80e6e2224d.tar.bz2 build_soong-0b9f31fb0834fd84bc4d5e3b99d67e80e6e2224d.zip |
Replace *Escape with *EscapeList
Follow the change to blueprint to make *Escape take and return a string
and add *EscapeList that take and return slices of strings. Fix up
a few places that were unnecessarily converting a string to a slice
and back to a string.
Test: m nothing
Change-Id: I3fa87de175522205f36544ef76aa2f04aef1b936
-rw-r--r-- | android/module.go | 12 | ||||
-rw-r--r-- | android/rule_builder.go | 2 | ||||
-rw-r--r-- | cc/compiler.go | 2 | ||||
-rw-r--r-- | cc/linker.go | 2 | ||||
-rw-r--r-- | cc/tidy.go | 2 | ||||
-rw-r--r-- | cmd/pom2bp/pom2bp.go | 2 | ||||
-rw-r--r-- | cmd/pom2mk/pom2mk.go | 2 | ||||
-rw-r--r-- | genrule/genrule.go | 2 | ||||
-rw-r--r-- | java/aar.go | 2 | ||||
-rw-r--r-- | java/app_builder.go | 2 | ||||
-rw-r--r-- | java/builder.go | 2 | ||||
-rw-r--r-- | java/dexpreopt_bootjars.go | 2 | ||||
-rw-r--r-- | java/jacoco.go | 2 | ||||
-rw-r--r-- | java/java.go | 2 | ||||
-rw-r--r-- | tradefed/autogen.go | 2 |
15 files changed, 20 insertions, 20 deletions
diff --git a/android/module.go b/android/module.go index 2fa7d316..516fa787 100644 --- a/android/module.go +++ b/android/module.go @@ -931,12 +931,12 @@ func convertBuildParams(params BuildParams) blueprint.BuildParams { bparams.Implicits = append(bparams.Implicits, params.Implicit.String()) } - bparams.Outputs = proptools.NinjaEscape(bparams.Outputs) - bparams.ImplicitOutputs = proptools.NinjaEscape(bparams.ImplicitOutputs) - bparams.Inputs = proptools.NinjaEscape(bparams.Inputs) - bparams.Implicits = proptools.NinjaEscape(bparams.Implicits) - bparams.OrderOnly = proptools.NinjaEscape(bparams.OrderOnly) - bparams.Depfile = proptools.NinjaEscape([]string{bparams.Depfile})[0] + bparams.Outputs = proptools.NinjaEscapeList(bparams.Outputs) + bparams.ImplicitOutputs = proptools.NinjaEscapeList(bparams.ImplicitOutputs) + bparams.Inputs = proptools.NinjaEscapeList(bparams.Inputs) + bparams.Implicits = proptools.NinjaEscapeList(bparams.Implicits) + bparams.OrderOnly = proptools.NinjaEscapeList(bparams.OrderOnly) + bparams.Depfile = proptools.NinjaEscapeList([]string{bparams.Depfile})[0] return bparams } diff --git a/android/rule_builder.go b/android/rule_builder.go index ff43e224..178a481f 100644 --- a/android/rule_builder.go +++ b/android/rule_builder.go @@ -240,7 +240,7 @@ func (r *RuleBuilder) Build(pctx PackageContext, ctx BuilderContext, name string if len(r.Commands()) > 0 { ctx.Build(pctx, BuildParams{ Rule: ctx.Rule(pctx, name, blueprint.RuleParams{ - Command: strings.Join(proptools.NinjaEscape(r.Commands()), " && "), + Command: strings.Join(proptools.NinjaEscapeList(r.Commands()), " && "), CommandDeps: r.Tools().Strings(), }), Implicits: r.Inputs(), diff --git a/cc/compiler.go b/cc/compiler.go index 0aee0bdb..53a60c7f 100644 --- a/cc/compiler.go +++ b/cc/compiler.go @@ -269,7 +269,7 @@ func (compiler *baseCompiler) compilerFlags(ctx ModuleContext, flags Flags, deps CheckBadCompilerFlags(ctx, "vendor.cflags", compiler.Properties.Target.Vendor.Cflags) CheckBadCompilerFlags(ctx, "recovery.cflags", compiler.Properties.Target.Recovery.Cflags) - esc := proptools.NinjaAndShellEscape + esc := proptools.NinjaAndShellEscapeList flags.CFlags = append(flags.CFlags, esc(compiler.Properties.Cflags)...) flags.CppFlags = append(flags.CppFlags, esc(compiler.Properties.Cppflags)...) diff --git a/cc/linker.go b/cc/linker.go index 25aedd00..9d4a0e8f 100644 --- a/cc/linker.go +++ b/cc/linker.go @@ -392,7 +392,7 @@ func (linker *baseLinker) linkerFlags(ctx ModuleContext, flags Flags) Flags { CheckBadLinkerFlags(ctx, "ldflags", linker.Properties.Ldflags) - flags.LdFlags = append(flags.LdFlags, proptools.NinjaAndShellEscape(linker.Properties.Ldflags)...) + flags.LdFlags = append(flags.LdFlags, proptools.NinjaAndShellEscapeList(linker.Properties.Ldflags)...) if ctx.Host() { rpath_prefix := `\$$ORIGIN/` @@ -69,7 +69,7 @@ func (tidy *tidyFeature) flags(ctx ModuleContext, flags Flags) Flags { if len(withTidyFlags) > 0 { flags.TidyFlags = append(flags.TidyFlags, withTidyFlags) } - esc := proptools.NinjaAndShellEscape + esc := proptools.NinjaAndShellEscapeList flags.TidyFlags = append(flags.TidyFlags, esc(tidy.Properties.Tidy_flags)...) // If TidyFlags is empty, add default header filter. if len(flags.TidyFlags) == 0 { diff --git a/cmd/pom2bp/pom2bp.go b/cmd/pom2bp/pom2bp.go index a79c84f4..a399b283 100644 --- a/cmd/pom2bp/pom2bp.go +++ b/cmd/pom2bp/pom2bp.go @@ -605,7 +605,7 @@ Usage: %s [--rewrite <regex>=<replace>] [-exclude <module>] [--extra-deps <modul buf := &bytes.Buffer{} fmt.Fprintln(buf, "// Automatically generated with:") - fmt.Fprintln(buf, "// pom2bp", strings.Join(proptools.ShellEscape(os.Args[1:]), " ")) + fmt.Fprintln(buf, "// pom2bp", strings.Join(proptools.ShellEscapeList(os.Args[1:]), " ")) for _, pom := range poms { var err error diff --git a/cmd/pom2mk/pom2mk.go b/cmd/pom2mk/pom2mk.go index fc836411..94e56194 100644 --- a/cmd/pom2mk/pom2mk.go +++ b/cmd/pom2mk/pom2mk.go @@ -483,7 +483,7 @@ Usage: %s [--rewrite <regex>=<replace>] [-exclude <module>] [--extra-deps <modul } fmt.Println("# Automatically generated with:") - fmt.Println("# pom2mk", strings.Join(proptools.ShellEscape(os.Args[1:]), " ")) + fmt.Println("# pom2mk", strings.Join(proptools.ShellEscapeList(os.Args[1:]), " ")) fmt.Println("LOCAL_PATH := $(call my-dir)") for _, pom := range poms { diff --git a/genrule/genrule.go b/genrule/genrule.go index 7695ffbd..47d88c33 100644 --- a/genrule/genrule.go +++ b/genrule/genrule.go @@ -453,7 +453,7 @@ func NewGenSrcs() *Module { } // escape the command in case for example it contains '#', an odd number of '"', etc - command = fmt.Sprintf("bash -c %v", proptools.ShellEscape([]string{command})[0]) + command = fmt.Sprintf("bash -c %v", proptools.ShellEscape(command)) commands = append(commands, command) } fullCommand := strings.Join(commands, " && ") diff --git a/java/aar.go b/java/aar.go index 9eb2b279..c30632ea 100644 --- a/java/aar.go +++ b/java/aar.go @@ -168,7 +168,7 @@ func (a *aapt) aapt2Flags(ctx android.ModuleContext, sdkContext sdkContext, mani } else { versionName = ctx.Config().AppsDefaultVersionName() } - versionName = proptools.NinjaEscape([]string{versionName})[0] + versionName = proptools.NinjaEscape(versionName) linkFlags = append(linkFlags, "--version-name ", versionName) } diff --git a/java/app_builder.go b/java/app_builder.go index 6cc21595..bc91d55e 100644 --- a/java/app_builder.go +++ b/java/app_builder.go @@ -224,7 +224,7 @@ func TransformJniLibsToJar(ctx android.ModuleContext, outputFile android.Writabl Output: outputFile, Implicits: deps, Args: map[string]string{ - "jarArgs": strings.Join(proptools.NinjaAndShellEscape(jarArgs), " "), + "jarArgs": strings.Join(proptools.NinjaAndShellEscapeList(jarArgs), " "), }, }) } diff --git a/java/builder.go b/java/builder.go index aa61a85e..d8b303e4 100644 --- a/java/builder.go +++ b/java/builder.go @@ -300,7 +300,7 @@ func TransformResourcesToJar(ctx android.ModuleContext, outputFile android.Writa Output: outputFile, Implicits: deps, Args: map[string]string{ - "jarArgs": strings.Join(proptools.NinjaAndShellEscape(jarArgs), " "), + "jarArgs": strings.Join(proptools.NinjaAndShellEscapeList(jarArgs), " "), }, }) } diff --git a/java/dexpreopt_bootjars.go b/java/dexpreopt_bootjars.go index ca688326..64de21a4 100644 --- a/java/dexpreopt_bootjars.go +++ b/java/dexpreopt_bootjars.go @@ -281,7 +281,7 @@ func buildBootImageRuleForArch(ctx android.SingletonContext, image *bootImage, cmd.Flag(extraFlags) } - cmd.Textf(`|| ( echo %s ; false )`, proptools.ShellEscape([]string{failureMessage})[0]) + cmd.Textf(`|| ( echo %s ; false )`, proptools.ShellEscape(failureMessage)) installDir := filepath.Join("/system/framework", arch.String()) vdexInstallDir := filepath.Join("/system/framework") diff --git a/java/jacoco.go b/java/jacoco.go index 541a84af..8b6d4ac8 100644 --- a/java/jacoco.go +++ b/java/jacoco.go @@ -106,7 +106,7 @@ func jacocoFiltersToSpecs(filters []string) ([]string, error) { return nil, err } } - return proptools.NinjaAndShellEscape(specs), nil + return proptools.NinjaAndShellEscapeList(specs), nil } func jacocoFilterToSpec(filter string) (string, error) { diff --git a/java/java.go b/java/java.go index d230810d..52d97c9e 100644 --- a/java/java.go +++ b/java/java.go @@ -1152,7 +1152,7 @@ func (j *Module) compile(ctx android.ModuleContext, extraSrcJars ...android.Path Output: servicesJar, Implicits: services, Args: map[string]string{ - "jarArgs": "-P META-INF/services/ " + strings.Join(proptools.NinjaAndShellEscape(zipargs), " "), + "jarArgs": "-P META-INF/services/ " + strings.Join(proptools.NinjaAndShellEscapeList(zipargs), " "), }, }) jars = append(jars, servicesJar) diff --git a/tradefed/autogen.go b/tradefed/autogen.go index 6d9c2003..da5dabe6 100644 --- a/tradefed/autogen.go +++ b/tradefed/autogen.go @@ -67,7 +67,7 @@ func autogenTemplate(ctx android.ModuleContext, output android.WritablePath, tem } sort.Strings(options) extraOptions := strings.Join(options, "\n ") - extraOptions = proptools.NinjaAndShellEscape([]string{extraOptions})[0] + extraOptions = proptools.NinjaAndShellEscape(extraOptions) ctx.Build(pctx, android.BuildParams{ Rule: autogenTestConfig, |