aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorColin Cross <ccross@android.com>2017-07-20 01:37:43 +0000
committerandroid-build-merger <android-build-merger@google.com>2017-07-20 01:37:43 +0000
commite1f13d112fcb0ac6a980ff3177247c20a289a04c (patch)
treefb9bb806c1ea2e0cc5f7f7b2a4b2852754285589
parentace97fa176959d92b98406aa00568c98d80d33d5 (diff)
parent38b2f41edc03c4712bad11bacef3c008760cbec3 (diff)
downloadbuild_soong-e1f13d112fcb0ac6a980ff3177247c20a289a04c.tar.gz
build_soong-e1f13d112fcb0ac6a980ff3177247c20a289a04c.tar.bz2
build_soong-e1f13d112fcb0ac6a980ff3177247c20a289a04c.zip
Rename java module and property names for consistency am: e8dc34a372
am: 38b2f41edc Change-Id: I3555566b0c72be117fa1d3f3ba72015e4cba5310
-rw-r--r--androidmk/cmd/androidmk/android.go6
-rw-r--r--java/java.go20
-rw-r--r--java/java_test.go14
3 files changed, 20 insertions, 20 deletions
diff --git a/androidmk/cmd/androidmk/android.go b/androidmk/cmd/androidmk/android.go
index 78395c33..194b2c93 100644
--- a/androidmk/cmd/androidmk/android.go
+++ b/androidmk/cmd/androidmk/android.go
@@ -102,11 +102,11 @@ func init() {
"LOCAL_RENDERSCRIPT_INCLUDES": "renderscript.include_dirs",
"LOCAL_RENDERSCRIPT_FLAGS": "renderscript.flags",
- "LOCAL_JAVA_RESOURCE_DIRS": "java_resource_dirs",
+ "LOCAL_JAVA_RESOURCE_DIRS": "resource_dirs",
"LOCAL_JAVACFLAGS": "javacflags",
"LOCAL_DX_FLAGS": "dxflags",
- "LOCAL_JAVA_LIBRARIES": "java_libs",
- "LOCAL_STATIC_JAVA_LIBRARIES": "java_static_libs",
+ "LOCAL_JAVA_LIBRARIES": "libs",
+ "LOCAL_STATIC_JAVA_LIBRARIES": "static_libs",
"LOCAL_AIDL_INCLUDES": "aidl.include_dirs",
"LOCAL_AAPT_FLAGS": "aaptflags",
"LOCAL_PACKAGE_SPLITS": "package_splits",
diff --git a/java/java.go b/java/java.go
index 73490650..3d2e9609 100644
--- a/java/java.go
+++ b/java/java.go
@@ -35,8 +35,8 @@ func init() {
android.RegisterModuleType("java_library_host", JavaLibraryHostFactory)
android.RegisterModuleType("java_binary", JavaBinaryFactory)
android.RegisterModuleType("java_binary_host", JavaBinaryHostFactory)
- android.RegisterModuleType("prebuilt_java_library", JavaPrebuiltFactory)
- android.RegisterModuleType("prebuilt_sdk", SdkPrebuiltFactory)
+ android.RegisterModuleType("java_prebuilt_library", JavaPrebuiltFactory)
+ android.RegisterModuleType("android_prebuilt_sdk", SdkPrebuiltFactory)
android.RegisterModuleType("android_app", AndroidAppFactory)
android.RegisterSingletonType("logtags", LogtagsSingleton)
@@ -65,10 +65,10 @@ type compilerProperties struct {
Exclude_srcs []string `android:"arch_variant"`
// list of directories containing Java resources
- Java_resource_dirs []string `android:"arch_variant"`
+ Resource_dirs []string `android:"arch_variant"`
- // list of directories that should be excluded from java_resource_dirs
- Exclude_java_resource_dirs []string `android:"arch_variant"`
+ // list of directories that should be excluded from resource_dirs
+ Exclude_resource_dirs []string `android:"arch_variant"`
// don't build against the default libraries (legacy-test, core-junit,
// ext, and framework for device targets)
@@ -78,10 +78,10 @@ type compilerProperties struct {
Javacflags []string `android:"arch_variant"`
// list of of java libraries that will be in the classpath
- Java_libs []string `android:"arch_variant"`
+ Libs []string `android:"arch_variant"`
// list of java libraries that will be compiled into the resulting jar
- Java_static_libs []string `android:"arch_variant"`
+ Static_libs []string `android:"arch_variant"`
// manifest file to be included in resulting jar
Manifest *string
@@ -185,8 +185,8 @@ func (j *Module) deps(ctx android.BottomUpMutatorContext) {
ctx.AddDependency(ctx.Module(), javaLibTag, config.DefaultLibraries...)
}
}
- ctx.AddDependency(ctx.Module(), javaLibTag, j.properties.Java_libs...)
- ctx.AddDependency(ctx.Module(), javaStaticLibTag, j.properties.Java_static_libs...)
+ ctx.AddDependency(ctx.Module(), javaLibTag, j.properties.Libs...)
+ ctx.AddDependency(ctx.Module(), javaStaticLibTag, j.properties.Static_libs...)
}
func (j *Module) aidlFlags(ctx android.ModuleContext, aidlPreprocess android.OptionalPath,
@@ -320,7 +320,7 @@ func (j *Module) compile(ctx android.ModuleContext) {
classJarSpecs = append([]jarSpec{classes}, classJarSpecs...)
}
- resourceJarSpecs = append(ResourceDirsToJarSpecs(ctx, j.properties.Java_resource_dirs, j.properties.Exclude_java_resource_dirs),
+ resourceJarSpecs = append(ResourceDirsToJarSpecs(ctx, j.properties.Resource_dirs, j.properties.Exclude_resource_dirs),
resourceJarSpecs...)
manifest := android.OptionalPathForModuleSrc(ctx, j.properties.Manifest)
diff --git a/java/java_test.go b/java/java_test.go
index 91b1506a..bd6451cb 100644
--- a/java/java_test.go
+++ b/java/java_test.go
@@ -55,7 +55,7 @@ func testJava(t *testing.T, bp string) *android.TestContext {
ctx := android.NewTestContext()
ctx.RegisterModuleType("android_app", android.ModuleFactoryAdaptor(AndroidAppFactory))
ctx.RegisterModuleType("java_library", android.ModuleFactoryAdaptor(JavaLibraryFactory))
- ctx.RegisterModuleType("prebuilt_java_library", android.ModuleFactoryAdaptor(JavaPrebuiltFactory))
+ ctx.RegisterModuleType("java_prebuilt_library", android.ModuleFactoryAdaptor(JavaPrebuiltFactory))
ctx.Register()
extraModules := []string{"core-libart", "frameworks", "sdk_v14"}
@@ -91,8 +91,8 @@ func TestSimple(t *testing.T) {
java_library {
name: "foo",
srcs: ["a.java"],
- java_libs: ["bar"],
- java_static_libs: ["baz"],
+ libs: ["bar"],
+ static_libs: ["baz"],
}
java_library {
@@ -201,16 +201,16 @@ func TestPrebuilts(t *testing.T) {
java_library {
name: "foo",
srcs: ["a.java"],
- java_libs: ["bar"],
- java_static_libs: ["baz"],
+ libs: ["bar"],
+ static_libs: ["baz"],
}
- prebuilt_java_library {
+ java_prebuilt_library {
name: "bar",
srcs: ["a.jar"],
}
- prebuilt_java_library {
+ java_prebuilt_library {
name: "baz",
srcs: ["b.jar"],
}