From 74c070440e9c3f362cd0e9e13754bc8693ed9073 Mon Sep 17 00:00:00 2001 From: Sebastien Hertz Date: Fri, 17 May 2013 14:04:12 +0200 Subject: Help inline LogMessage::stream method. A very simple method that should be safely inlined by compiler. Change-Id: I7a2fa41d566e36b30b1afd6a2f6b0c2f986dc46f --- src/base/logging.cc | 4 ---- src/base/logging.h | 6 +++++- 2 files changed, 5 insertions(+), 5 deletions(-) (limited to 'src') diff --git a/src/base/logging.cc b/src/base/logging.cc index c9f28c81d..a19580cbd 100644 --- a/src/base/logging.cc +++ b/src/base/logging.cc @@ -139,10 +139,6 @@ LogMessage::~LogMessage() { delete data_; } -std::ostream& LogMessage::stream() { - return data_->buffer; -} - HexDump::HexDump(const void* address, size_t byte_count, bool show_actual_addresses) : address_(address), byte_count_(byte_count), show_actual_addresses_(show_actual_addresses) { } diff --git a/src/base/logging.h b/src/base/logging.h index f250ce01b..8d89e4d0c 100644 --- a/src/base/logging.h +++ b/src/base/logging.h @@ -184,8 +184,12 @@ class LogMessage { LogMessage(const char* file, int line, LogSeverity severity, int error) : data_(new LogMessageData(file, line, severity, error)) { } + ~LogMessage() LOCKS_EXCLUDED(Locks::logging_lock_); - std::ostream& stream(); + + std::ostream& stream() { + return data_->buffer; + } private: static void LogLine(const LogMessageData& data, const char*); -- cgit v1.2.3