diff options
| author | Nicolas Geoffray <ngeoffray@google.com> | 2014-11-07 16:36:02 +0000 |
|---|---|---|
| committer | Nicolas Geoffray <ngeoffray@google.com> | 2014-11-07 16:36:02 +0000 |
| commit | dadf3173e1070ccab89b86b2ef2ab9fb7030856f (patch) | |
| tree | 023f19e8ef5d6c1f0eb5b85a6d4b46b6db145d3d /compiler/optimizing/builder.cc | |
| parent | 10d543c44ba878ba2037b0b945ce259b0a5dd605 (diff) | |
| download | art-dadf3173e1070ccab89b86b2ef2ab9fb7030856f.tar.gz art-dadf3173e1070ccab89b86b2ef2ab9fb7030856f.tar.bz2 art-dadf3173e1070ccab89b86b2ef2ab9fb7030856f.zip | |
Silent cpplint on dex instruction switch.
Change-Id: I57a2307c80d38ba29a16cac729bcf3a491549c30
Diffstat (limited to 'compiler/optimizing/builder.cc')
| -rw-r--r-- | compiler/optimizing/builder.cc | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/compiler/optimizing/builder.cc b/compiler/optimizing/builder.cc index 05213a18b..3d492cde0 100644 --- a/compiler/optimizing/builder.cc +++ b/compiler/optimizing/builder.cc @@ -775,8 +775,7 @@ bool HGraphBuilder::AnalyzeDexInstruction(const Instruction& instruction, uint32 break; } - // TODO: these instructions are also used to move floating point values, so what is - // the type (int or float)? + // Note that the SSA building will refine the types. case Instruction::MOVE: case Instruction::MOVE_FROM16: case Instruction::MOVE_16: { @@ -785,8 +784,7 @@ bool HGraphBuilder::AnalyzeDexInstruction(const Instruction& instruction, uint32 break; } - // TODO: these instructions are also used to move floating point values, so what is - // the type (long or double)? + // Note that the SSA building will refine the types. case Instruction::MOVE_WIDE: case Instruction::MOVE_WIDE_FROM16: case Instruction::MOVE_WIDE_16: { @@ -859,7 +857,8 @@ bool HGraphBuilder::AnalyzeDexInstruction(const Instruction& instruction, uint32 uint32_t number_of_vreg_arguments = instruction.VRegA_35c(); uint32_t args[5]; instruction.GetVarArgs(args); - if (!BuildInvoke(instruction, dex_offset, method_idx, number_of_vreg_arguments, false, args, -1)) { + if (!BuildInvoke(instruction, dex_offset, method_idx, + number_of_vreg_arguments, false, args, -1)) { return false; } break; @@ -1309,7 +1308,7 @@ bool HGraphBuilder::AnalyzeDexInstruction(const Instruction& instruction, uint32 return false; } return true; -} +} // NOLINT(readability/fn_size) HIntConstant* HGraphBuilder::GetIntConstant0() { if (constant0_ != nullptr) { |