diff options
author | Dan Pasanen <dan.pasanen@gmail.com> | 2017-04-05 07:28:02 -0500 |
---|---|---|
committer | Dan Pasanen <dan.pasanen@gmail.com> | 2017-04-05 07:28:02 -0500 |
commit | 4bc1c8f28efe30ce4d4b4e3207781607faf65aca (patch) | |
tree | 140878dbcc21ef6e88bdbf23bec07cddf278abbd | |
parent | 25ea9c383abd988258e34ae932dbcb5593b12d84 (diff) | |
parent | e74c3ea1e2dfb81eeef00ecc399ef78c37fe7868 (diff) | |
download | android_system_vold-staging/cm-14.1_android-7.1.2_r2.tar.gz android_system_vold-staging/cm-14.1_android-7.1.2_r2.tar.bz2 android_system_vold-staging/cm-14.1_android-7.1.2_r2.zip |
Merge tag 'android-7.1.2_r2' into cm-14.1staging/cm-14.1_android-7.1.2_r2
Android 7.1.2 Release 2 (N2G47E)
# gpg: Signature made Mon 03 Apr 2017 01:41:52 AM CDT
# gpg: using DSA key E8AD3F819AB10E78
# gpg: Can't check signature: No public key
-rw-r--r-- | main.cpp | 17 |
1 files changed, 11 insertions, 6 deletions
@@ -41,7 +41,7 @@ #include <dirent.h> #include <fs_mgr.h> -static int process_config(VolumeManager *vm); +static int process_config(VolumeManager *vm, bool* has_adoptable); static void coldboot(const char *path); static void parse_args(int argc, char** argv); @@ -118,7 +118,9 @@ extern "C" int vold_main(int argc, char** argv) { exit(1); } - if (process_config(vm)) { + bool has_adoptable; + + if (process_config(vm, &has_adoptable)) { PLOG(ERROR) << "Error reading configuration... continuing anyways"; } @@ -145,6 +147,10 @@ extern "C" int vold_main(int argc, char** argv) { } #endif + // This call should go after listeners are started to avoid + // a deadlock between vold and init (see b/34278978 for details) + property_set("vold.has_adoptable", has_adoptable ? "1" : "0"); + // Eventually we'll become the monitoring thread while(1) { sleep(1000); @@ -221,7 +227,7 @@ static void coldboot(const char *path) { } } -static int process_config(VolumeManager *vm) { +static int process_config(VolumeManager *vm, bool* has_adoptable) { std::string path(android::vold::DefaultFstabPath()); fstab = fs_mgr_read_fstab(path.c_str()); if (!fstab) { @@ -230,7 +236,7 @@ static int process_config(VolumeManager *vm) { } /* Loop through entries looking for ones that vold manages */ - bool has_adoptable = false; + *has_adoptable = false; for (int i = 0; i < fstab->num_entries; i++) { if (fs_mgr_is_voldmanaged(&fstab->recs[i])) { std::string sysPattern(fstab->recs[i].blk_device); @@ -248,7 +254,7 @@ static int process_config(VolumeManager *vm) { if (fs_mgr_is_encryptable(&fstab->recs[i])) { flags |= android::vold::Disk::Flags::kAdoptable; - has_adoptable = true; + *has_adoptable = true; } if (fs_mgr_is_noemulatedsd(&fstab->recs[i]) || property_get_bool("vold.debug.default_primary", false)) { @@ -263,6 +269,5 @@ static int process_config(VolumeManager *vm) { fstype, mntopts))); } } - property_set("vold.has_adoptable", has_adoptable ? "1" : "0"); return 0; } |