From d21bfee0d45a5eb8ffb09eaae3c6d81f3dd292f7 Mon Sep 17 00:00:00 2001 From: Christopher Wiley Date: Fri, 29 Jan 2016 15:11:38 -0800 Subject: Fully separate AIDL and Java type namespaces For android::aidl::ValidatableType, rename: - QualifiedName() -> CanonicalName() - Name() -> ShortName() For android::aidl::java::Type, add a new JavaType() method. Use that method exclusively when generating Java. Bug: 26875320 Test: unit and integration tests pass Change-Id: Ib1d09f4f84d3270634e611f0911f60a2e685cefc --- generate_java_binder.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'generate_java_binder.cpp') diff --git a/generate_java_binder.cpp b/generate_java_binder.cpp index 237b993..b692637 100644 --- a/generate_java_binder.cpp +++ b/generate_java_binder.cpp @@ -65,7 +65,7 @@ StubClass::StubClass(const Type* type, const InterfaceType* interfaceType, Field* descriptor = new Field(STATIC | FINAL | PRIVATE, new Variable(types->StringType(), "DESCRIPTOR")); - descriptor->value = "\"" + interfaceType->QualifiedName() + "\""; + descriptor->value = "\"" + interfaceType->JavaType() + "\""; this->elements.push_back(descriptor); // ctor @@ -125,7 +125,7 @@ void StubClass::make_as_interface(const InterfaceType* interfaceType, Method* m = new Method; m->comment = "/**\n * Cast an IBinder object into an "; - m->comment += interfaceType->QualifiedName(); + m->comment += interfaceType->JavaType(); m->comment += " interface,\n"; m->comment += " * generating a proxy if needed.\n */"; m->modifiers = PUBLIC | STATIC; @@ -158,7 +158,7 @@ void StubClass::make_as_interface(const InterfaceType* interfaceType, Comparison* iinNotNull = new Comparison(iin, "!=", NULL_VALUE); Comparison* instOfCheck = new Comparison(iin, " instanceof ", - new LiteralExpression(interfaceType->QualifiedName())); + new LiteralExpression(interfaceType->JavaType())); IfStatement* instOfStatement = new IfStatement(); instOfStatement->expression = new Comparison(iinNotNull, "&&", instOfCheck); instOfStatement->statements = new StatementBlock; -- cgit v1.2.3