diff options
author | Yi Kong <yikong@google.com> | 2018-07-30 15:53:23 -0700 |
---|---|---|
committer | Yi Kong <yikong@google.com> | 2018-07-30 15:54:04 -0700 |
commit | 3712b27403be88e4bd693e26c10a31724b5e19ce (patch) | |
tree | d749fe06b47eb3b49bbf12cf6590b28af3e5205f /tests | |
parent | a2040e8bcde6f0984321d62750aaa9b01024f534 (diff) | |
download | android_system_keymaster-3712b27403be88e4bd693e26c10a31724b5e19ce.tar.gz android_system_keymaster-3712b27403be88e4bd693e26c10a31724b5e19ce.tar.bz2 android_system_keymaster-3712b27403be88e4bd693e26c10a31724b5e19ce.zip |
Modernize codebase by replacing NULL with nullptr
Fixes -Wzero-as-null-pointer-constant warning.
Test: m
Bug: 68236239
Change-Id: Ieea37d3d09bfcc88603ea691dacd264f4066cfa7
Diffstat (limited to 'tests')
-rw-r--r-- | tests/android_keymaster_messages_test.cpp | 4 | ||||
-rw-r--r-- | tests/android_keymaster_test_utils.cpp | 12 | ||||
-rw-r--r-- | tests/android_keymaster_test_utils.h | 16 |
3 files changed, 16 insertions, 16 deletions
diff --git a/tests/android_keymaster_messages_test.cpp b/tests/android_keymaster_messages_test.cpp index a933cf8..7dcffbe 100644 --- a/tests/android_keymaster_messages_test.cpp +++ b/tests/android_keymaster_messages_test.cpp @@ -35,7 +35,7 @@ Message* round_trip(int32_t ver, const Message& message, size_t expected_size) { size_t size = message.SerializedSize(); EXPECT_EQ(expected_size, size); if (size == 0) - return NULL; + return nullptr; UniquePtr<uint8_t[]> buf(new uint8_t[size]); EXPECT_EQ(buf.get() + size, message.Serialize(buf.get(), buf.get() + size)); @@ -669,7 +669,7 @@ template <typename Message> void parse_garbage() { } } - time_t now = time(NULL); + time_t now = time(nullptr); std::cout << "Seeding rand() with " << now << " for fuzz test." << std::endl; srand(now); diff --git a/tests/android_keymaster_test_utils.cpp b/tests/android_keymaster_test_utils.cpp index 917e95e..b031d26 100644 --- a/tests/android_keymaster_test_utils.cpp +++ b/tests/android_keymaster_test_utils.cpp @@ -107,7 +107,7 @@ bool operator==(const keymaster_key_param_t& a, const keymaster_key_param_t& b) return a.boolean == b.boolean; case KM_BIGNUM: case KM_BYTES: - if ((a.blob.data == NULL || b.blob.data == NULL) && a.blob.data != b.blob.data) + if ((a.blob.data == nullptr || b.blob.data == nullptr) && a.blob.data != b.blob.data) return false; return a.blob.data_length == b.blob.data_length && (memcmp(a.blob.data, b.blob.data, a.blob.data_length) == 0); @@ -359,7 +359,7 @@ keymaster_error_t Keymaster2Test::UpgradeKey(const AuthorizationSet& upgrade_par } string Keymaster2Test::ProcessMessage(keymaster_purpose_t purpose, const string& message) { - EXPECT_EQ(KM_ERROR_OK, BeginOperation(purpose, client_params(), NULL /* output_params */)); + EXPECT_EQ(KM_ERROR_OK, BeginOperation(purpose, client_params(), nullptr /* output_params */)); string result; EXPECT_EQ(KM_ERROR_OK, FinishOperation(message, "" /* signature */, &result)); @@ -390,7 +390,7 @@ string Keymaster2Test::ProcessMessage(keymaster_purpose_t purpose, const string& string Keymaster2Test::ProcessMessage(keymaster_purpose_t purpose, const string& message, const string& signature) { - EXPECT_EQ(KM_ERROR_OK, BeginOperation(purpose, client_params(), NULL /* output_params */)); + EXPECT_EQ(KM_ERROR_OK, BeginOperation(purpose, client_params(), nullptr /* output_params */)); string result; EXPECT_EQ(KM_ERROR_OK, FinishOperation(message, signature, &result)); @@ -608,14 +608,14 @@ string Keymaster2Test::DecryptMessageWithParams(const string& message, keymaster_error_t Keymaster2Test::GetCharacteristics() { FreeCharacteristics(); - return device()->get_key_characteristics(device(), &blob_, &client_id_, NULL /* app_data */, + return device()->get_key_characteristics(device(), &blob_, &client_id_, nullptr /* app_data */, &characteristics_); } keymaster_error_t Keymaster2Test::ExportKey(keymaster_key_format_t format, string* export_data) { keymaster_blob_t export_tmp; keymaster_error_t error = device()->export_key(device(), format, &blob_, &client_id_, - NULL /* app_data */, &export_tmp); + nullptr /* app_data */, &export_tmp); if (error != KM_ERROR_OK) return error; @@ -691,7 +691,7 @@ void Keymaster2Test::FreeCharacteristics() { void Keymaster2Test::FreeKeyBlob() { free(const_cast<uint8_t*>(blob_.key_material)); - blob_.key_material = NULL; + blob_.key_material = nullptr; } void Keymaster2Test::corrupt_key_blob() { diff --git a/tests/android_keymaster_test_utils.h b/tests/android_keymaster_test_utils.h index c6a1641..a1965be 100644 --- a/tests/android_keymaster_test_utils.h +++ b/tests/android_keymaster_test_utils.h @@ -196,7 +196,7 @@ class Keymaster2Test : public testing::TestWithParam<InstanceCreatorPtr> { keymaster_error_t BeginOperation(keymaster_purpose_t purpose); keymaster_error_t BeginOperation(keymaster_purpose_t purpose, const AuthorizationSet& input_set, - AuthorizationSet* output_set = NULL); + AuthorizationSet* output_set = nullptr); keymaster_error_t UpdateOperation(const std::string& message, std::string* output, size_t* input_consumed); @@ -229,11 +229,11 @@ class Keymaster2Test : public testing::TestWithParam<InstanceCreatorPtr> { std::string ProcessMessage(keymaster_purpose_t purpose, const std::string& message, const AuthorizationSet& begin_params, const AuthorizationSet& update_params, - AuthorizationSet* output_params = NULL); + AuthorizationSet* output_params = nullptr); std::string ProcessMessage(keymaster_purpose_t purpose, const std::string& message, const std::string& signature, const AuthorizationSet& begin_params, const AuthorizationSet& update_params, - AuthorizationSet* output_params = NULL); + AuthorizationSet* output_params = nullptr); std::string ProcessMessage(keymaster_purpose_t purpose, const std::string& message, const std::string& signature); @@ -249,17 +249,17 @@ class Keymaster2Test : public testing::TestWithParam<InstanceCreatorPtr> { void VerifyMac(const std::string& message, const std::string& signature); std::string EncryptMessage(const std::string& message, keymaster_padding_t padding, - std::string* generated_nonce = NULL); + std::string* generated_nonce = nullptr); std::string EncryptMessage(const std::string& message, keymaster_digest_t digest, - keymaster_padding_t padding, std::string* generated_nonce = NULL); + keymaster_padding_t padding, std::string* generated_nonce = nullptr); std::string EncryptMessage(const std::string& message, keymaster_block_mode_t block_mode, - keymaster_padding_t padding, std::string* generated_nonce = NULL); + keymaster_padding_t padding, std::string* generated_nonce = nullptr); std::string EncryptMessage(const AuthorizationSet& update_params, const std::string& message, keymaster_digest_t digest, keymaster_padding_t padding, - std::string* generated_nonce = NULL); + std::string* generated_nonce = nullptr); std::string EncryptMessage(const AuthorizationSet& update_params, const std::string& message, keymaster_block_mode_t block_mode, keymaster_padding_t padding, - std::string* generated_nonce = NULL); + std::string* generated_nonce = nullptr); std::string EncryptMessageWithParams(const std::string& message, const AuthorizationSet& begin_params, const AuthorizationSet& update_params, |