diff options
| author | TreeHugger Robot <treehugger-gerrit@google.com> | 2016-04-29 23:22:37 +0000 |
|---|---|---|
| committer | Android (Google) Code Review <android-gerrit@google.com> | 2016-04-29 23:22:37 +0000 |
| commit | 32fabdcc35dfd138e01e39803b98ecf34a314244 (patch) | |
| tree | b3ab2929999aa7c11e39f4aa6dc9978e2ac4df80 | |
| parent | eabae3005e170c757d779ef83813644f3fdd3e35 (diff) | |
| parent | df1adeba7fdff6ae1556f647efb155c71918fa76 (diff) | |
| download | android_system_keymaster-32fabdcc35dfd138e01e39803b98ecf34a314244.tar.gz android_system_keymaster-32fabdcc35dfd138e01e39803b98ecf34a314244.tar.bz2 android_system_keymaster-32fabdcc35dfd138e01e39803b98ecf34a314244.zip | |
Merge "Reject too-large key attestation challenges." into nyc-dev
| -rw-r--r-- | soft_keymaster_device.cpp | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/soft_keymaster_device.cpp b/soft_keymaster_device.cpp index d6c9e6b..eddbc5d 100644 --- a/soft_keymaster_device.cpp +++ b/soft_keymaster_device.cpp @@ -73,6 +73,7 @@ struct keystore_module soft_keymaster2_device_module = { namespace keymaster { +const size_t kMaximumAttestationChallengeLength = 128; const size_t kOperationTableSize = 16; template <typename T> std::vector<T> make_vector(const T* array, size_t len) { @@ -1060,6 +1061,14 @@ keymaster_error_t SoftKeymasterDevice::attest_key(const keymaster2_device_t* dev request.SetKeyMaterial(*key_to_attest); request.attest_params.Reinitialize(*attest_params); + keymaster_blob_t attestation_challenge = {}; + request.attest_params.GetTagValue(TAG_ATTESTATION_CHALLENGE, &attestation_challenge); + if (attestation_challenge.data_length > kMaximumAttestationChallengeLength) { + LOG_E("%d-byte attestation challenge; only %d bytes allowed", + attestation_challenge.data_length, kMaximumAttestationChallengeLength); + return KM_ERROR_INVALID_INPUT_LENGTH; + } + AttestKeyResponse response; convert_device(dev)->impl_->AttestKey(request, &response); if (response.error != KM_ERROR_OK) |