From 9500dc3a19466dae5269bf337364396b0a48309c Mon Sep 17 00:00:00 2001 From: Jorge Ruesga Date: Fri, 7 Nov 2014 01:25:20 +0100 Subject: photophase: restart lwp service on bad egl context This patch contains some fixes for bad egl context detection and other NPE and lint fixes Change-Id: I47c4348770dc72f768df4bea27c7817d1ec10c42 Signed-off-by: Jorge Ruesga --- .../wallpapers/photophase/AndroidHelper.java | 18 ++++++++++++++++++ .../wallpapers/photophase/PhotoPhaseRenderer.java | 18 ++++++++++++++++++ .../photophase/preferences/ChoosePicturesFragment.java | 2 +- 3 files changed, 37 insertions(+), 1 deletion(-) (limited to 'src') diff --git a/src/org/cyanogenmod/wallpapers/photophase/AndroidHelper.java b/src/org/cyanogenmod/wallpapers/photophase/AndroidHelper.java index bf69cde..56e0563 100644 --- a/src/org/cyanogenmod/wallpapers/photophase/AndroidHelper.java +++ b/src/org/cyanogenmod/wallpapers/photophase/AndroidHelper.java @@ -17,10 +17,14 @@ package org.cyanogenmod.wallpapers.photophase; import android.app.Activity; +import android.app.WallpaperManager; +import android.content.ComponentName; import android.content.Context; +import android.content.Intent; import android.content.res.Configuration; import android.content.res.Resources; import android.provider.Settings; +import android.os.Process; import android.util.DisplayMetrics; import android.view.ViewConfiguration; @@ -109,4 +113,18 @@ public final class AndroidHelper { } return result; } + + /** + * Method that restart the wallpaper + * + * @param ctx The current context + */ + public static void restartWallpaper(Context ctx) { + // Restart the service + Process.killProcess(Process.myPid()); + Intent intent = new Intent(WallpaperManager.ACTION_CHANGE_LIVE_WALLPAPER); + intent.putExtra(WallpaperManager.EXTRA_LIVE_WALLPAPER_COMPONENT, + new ComponentName(ctx, PhotoPhaseWallpaper.class)); + ctx.startActivity(intent); + } } diff --git a/src/org/cyanogenmod/wallpapers/photophase/PhotoPhaseRenderer.java b/src/org/cyanogenmod/wallpapers/photophase/PhotoPhaseRenderer.java index bb9ed29..9358877 100644 --- a/src/org/cyanogenmod/wallpapers/photophase/PhotoPhaseRenderer.java +++ b/src/org/cyanogenmod/wallpapers/photophase/PhotoPhaseRenderer.java @@ -181,6 +181,14 @@ public class PhotoPhaseRenderer implements GLSurfaceView.Renderer { } }; + private final Runnable mEGLContextWatchDog = new Runnable() { + @Override + public void run() { + // Restart the wallpaper + AndroidHelper.restartWallpaper(mContext); + } + }; + /** * Constructor of PhotoPhaseRenderer * @@ -314,6 +322,11 @@ public class PhotoPhaseRenderer implements GLSurfaceView.Renderer { } else { mDispatcher.setRenderMode(GLSurfaceView.RENDERMODE_CONTINUOUSLY); } + + // Set a watchdog to detect EGL bad context and restart the wallpaper + if (!mIsPreview) { + mHandler.postDelayed(mEGLContextWatchDog, 1000L); + } } /** @@ -709,6 +722,11 @@ public class PhotoPhaseRenderer implements GLSurfaceView.Renderer { */ @Override public void onDrawFrame(GL10 glUnused) { + // Remove the EGL context watchdog + if (!mIsPreview) { + mHandler.removeCallbacks(mEGLContextWatchDog); + } + // Set the projection, view and model GLES20.glViewport(0, -mStatusBarHeight, mWidth, mHeight); Matrix.setLookAtM(mVMatrix, 0, 0.0f, 0.0f, -1.0f, 0.0f, 0.0f, 0.0f, 0.0f, 1.0f, 0.0f); diff --git a/src/org/cyanogenmod/wallpapers/photophase/preferences/ChoosePicturesFragment.java b/src/org/cyanogenmod/wallpapers/photophase/preferences/ChoosePicturesFragment.java index f83c392..fa9c637 100644 --- a/src/org/cyanogenmod/wallpapers/photophase/preferences/ChoosePicturesFragment.java +++ b/src/org/cyanogenmod/wallpapers/photophase/preferences/ChoosePicturesFragment.java @@ -478,7 +478,7 @@ public class ChoosePicturesFragment extends PreferenceFragment private void restoreData() { // Restore and the albums the selection mSelectedAlbums = new HashSet(mOriginalSelectedAlbums); - int count = mAlbums.size(); + int count = Math.min(mAlbums.size(), mOriginalAlbums.size()); for (int i = 0; i < count ; i++) { Album album = mAlbums.get(i); Album originalAlbum = mOriginalAlbums.get(i); -- cgit v1.2.3