From a89321ea04ced76d06f60f5909be203cb654a830 Mon Sep 17 00:00:00 2001 From: Steve Howard Date: Tue, 3 Aug 2010 12:39:35 -0700 Subject: Fix and test handling of null/empty download fields. Minor change to make title/description default to blank stings, and add test case covering all null/empty download fields. Change-Id: Id44344bc2e464f46589faed49c8f383a45a8d329 --- .../android/providers/downloads/PublicApiFunctionalTest.java | 12 ++++++++++++ 1 file changed, 12 insertions(+) (limited to 'tests/src/com/android/providers') diff --git a/tests/src/com/android/providers/downloads/PublicApiFunctionalTest.java b/tests/src/com/android/providers/downloads/PublicApiFunctionalTest.java index 6d604778..cf2b990c 100644 --- a/tests/src/com/android/providers/downloads/PublicApiFunctionalTest.java +++ b/tests/src/com/android/providers/downloads/PublicApiFunctionalTest.java @@ -482,6 +482,18 @@ public class PublicApiFunctionalTest extends AbstractPublicApiTest { download.getLongField(DownloadManager.COLUMN_ERROR_CODE)); } + public void testEmptyFields() throws Exception { + Download download = enqueueRequest(getRequest()); + assertNull(download.getStringField(DownloadManager.COLUMN_LOCAL_URI)); + assertEquals("", download.getStringField(DownloadManager.COLUMN_TITLE)); + assertEquals("", download.getStringField(DownloadManager.COLUMN_DESCRIPTION)); + assertNull(download.getStringField(DownloadManager.COLUMN_MEDIA_TYPE)); + assertEquals(0, download.getLongField(DownloadManager.COLUMN_BYTES_DOWNLOADED_SO_FAR)); + assertEquals(-1, download.getLongField(DownloadManager.COLUMN_TOTAL_SIZE_BYTES)); + // just ensure no exception is thrown + download.getLongField(DownloadManager.COLUMN_ERROR_CODE); + } + private void checkCompleteDownload(Download download) throws Exception { assertEquals(FILE_CONTENT.length(), download.getLongField(DownloadManager.COLUMN_BYTES_DOWNLOADED_SO_FAR)); -- cgit v1.2.3