From a8bbae54b9533d560dc3c81c0858de0f99fed0ee Mon Sep 17 00:00:00 2001 From: Robin Lee Date: Fri, 8 Apr 2016 12:01:19 +0100 Subject: Extra comments for multinetwork downloading Bug: 27074270 Change-Id: I7145fcdf0c8af0f0c299ca491f01eaef6204e2cb --- src/com/android/providers/downloads/DownloadThread.java | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'src/com/android/providers/downloads/DownloadThread.java') diff --git a/src/com/android/providers/downloads/DownloadThread.java b/src/com/android/providers/downloads/DownloadThread.java index 8d51909e..f6b0be6d 100644 --- a/src/com/android/providers/downloads/DownloadThread.java +++ b/src/com/android/providers/downloads/DownloadThread.java @@ -352,6 +352,8 @@ public class DownloadThread implements Runnable { throw new StopRequestException(STATUS_BAD_REQUEST, e); } + // Use the caller's default network to make this connection, since they might be subject to + // restrictions that we shouldn't let them circumvent. final Network network = mSystemFacade.getActiveNetwork(mInfo.mUid); if (network == null) { throw new StopRequestException(Downloads.Impl.STATUS_WAITING_FOR_NETWORK, @@ -374,6 +376,8 @@ public class DownloadThread implements Runnable { // response with body. HttpURLConnection conn = null; try { + // Check that the caller is allowed to make network connections. If so, make one on + // their behalf to open the url. checkConnectivity(); conn = (HttpURLConnection) network.openConnection(url); conn.setInstanceFollowRedirects(false); -- cgit v1.2.3