From e61798da80558450f580ed948d0d469bd6423d8e Mon Sep 17 00:00:00 2001 From: Steve Howard Date: Mon, 2 Aug 2010 11:52:16 -0700 Subject: Extend PublicApiAccessTest to exercise DownloadManager. This change adds a new test case to PublicApiAccessTest to enqueue a request through DownloadManager, ensuring that the values constructed by DownloadManager fit within the allowed bounds. It also fixes a bug with allowing http header values exposed by the new test. Change-Id: I94fec57d7a41298ac42ddaab338516e6a60c4e75 --- src/com/android/providers/downloads/DownloadProvider.java | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'src/com/android/providers/downloads/DownloadProvider.java') diff --git a/src/com/android/providers/downloads/DownloadProvider.java b/src/com/android/providers/downloads/DownloadProvider.java index 41b732f1..4fcae227 100644 --- a/src/com/android/providers/downloads/DownloadProvider.java +++ b/src/com/android/providers/downloads/DownloadProvider.java @@ -46,6 +46,7 @@ import com.google.common.annotations.VisibleForTesting; import java.io.File; import java.io.FileNotFoundException; import java.util.HashSet; +import java.util.Iterator; import java.util.Map; @@ -518,6 +519,13 @@ public final class DownloadProvider extends ContentProvider { values.remove(Downloads.Impl.COLUMN_NOTIFICATION_PACKAGE); // checked later in insert() values.remove(Downloads.Impl.COLUMN_ALLOWED_NETWORK_TYPES); values.remove(Downloads.Impl.COLUMN_ALLOW_ROAMING); + Iterator> iterator = values.valueSet().iterator(); + while (iterator.hasNext()) { + String key = iterator.next().getKey(); + if (key.startsWith(Downloads.Impl.RequestHeaders.INSERT_KEY_PREFIX)) { + iterator.remove(); + } + } // any extra columns are extraneous and disallowed if (values.size() > 0) { -- cgit v1.2.3