From f0fa1cdc1a36cbe0abd57ef9cf9a636fd1d3e2c8 Mon Sep 17 00:00:00 2001 From: Jean-Baptiste Queru Date: Wed, 1 Jul 2009 15:27:28 -0700 Subject: Fix crash in discardPurgeableFiles with proper selection syntax. The basic crash is that this codepath was doing a query to the download provider without properly quoting its selection arguments (which is mandated by the download provider). A secondary crash is that the DESTINATION column wasn't readable. This fixes bug 1941125. Tested by force-calling discardPurgeableFiles for each download to /cache, locally adding a few debugging statements to be sure that the codepath was getting executed, and doing a market download. --- docs/index.html | 1 + 1 file changed, 1 insertion(+) (limited to 'docs') diff --git a/docs/index.html b/docs/index.html index a073a004..0004b729 100644 --- a/docs/index.html +++ b/docs/index.html @@ -231,6 +231,7 @@ Here's the list of columns that can currently be read/queried, with comments: _DATA Probably should not be visible to applications. WARNING Security concern: This holds filenames, including those of private files. While file permissions are supposed to kick in and protect the files, hiding private filenames deeper in would probably be a reasonable idea. MIMETYPE Needs to be visible so that app can display the icon matching the mime type. Intended to be visible by 3rd-party download UIs. TODO Security TBD before we implement support for 3rd-party UIs. VISIBILITY Needs to be visible in case an app has both visible and invisible downloads. No obvious security concern. + DESTINATION Needs to be visible in case an app has multiple destinations and wants to distinguish between them. Also used internally by the download manager. No obvious security concern. STATUS Needs to be visible (1004). No obvious security concern. LAST_MODIFICATION Needs to be visible, e.g. so that apps can sort downloads by date of last activity, or discard old downloads. No obvious security concern. NOTIFICATION_PACKAGE Allows individual apps running under shared UIDs to identify their own downloads. No security concern: can be queried through package manager. -- cgit v1.2.3