From bb4439869f5fbc943a9b8159eadfc717d133983a Mon Sep 17 00:00:00 2001 From: Sudheer Shanka Date: Wed, 3 Jul 2019 15:31:32 -0700 Subject: Set FGS priority for download jobs with visible notifications. This is what DownloadProvider used to do pre-Q using PRIORITY_FOREGROUND_APP but in Q, we added a new priority to denote FGS but DownloadProvider was still using PRIORITY_FOREGROUND_APP which is now considered a lower priority than FGS and some jobs are getting preempted unnecessarily. So, update DownloadProvider to mark download jobs with FGS priority instead of BFGS priority. This still has some issues but at least this will be kind of reverting DownloadProvider to its pre-Q behavior. Bug: 135982638 Test: manual - Go through DO provisioning a few times and check admin app can be successfully downloaded. Test: atest DownloadProviderTests Test: atest cts/tests/app/src/android/app/cts/DownloadManagerTest.java Test: atest cts/tests/app/DownloadManagerLegacyTest/src/android/app/cts/DownloadManagerLegacyTest.java Test: atest cts/tests/app/DownloadManagerApi28Test/src/android/app/cts/DownloadManagerApi28Test.java Change-Id: I020e366845d768da271b860a7ace91318e67d8ae --- src/com/android/providers/downloads/DownloadJobService.java | 1 + src/com/android/providers/downloads/Helpers.java | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/com/android/providers/downloads/DownloadJobService.java b/src/com/android/providers/downloads/DownloadJobService.java index d09738c2..e1b20234 100644 --- a/src/com/android/providers/downloads/DownloadJobService.java +++ b/src/com/android/providers/downloads/DownloadJobService.java @@ -81,6 +81,7 @@ public class DownloadJobService extends JobService { @Override public boolean onStopJob(JobParameters params) { final int id = params.getJobId(); + Log.d(TAG, "onStopJob id=" + id + ", reason=" + params.getStopReason()); final DownloadThread thread; synchronized (mActiveThreads) { diff --git a/src/com/android/providers/downloads/Helpers.java b/src/com/android/providers/downloads/Helpers.java index 7b4cb4e9..565aa52e 100644 --- a/src/com/android/providers/downloads/Helpers.java +++ b/src/com/android/providers/downloads/Helpers.java @@ -161,7 +161,7 @@ public class Helpers { // When this download will show a notification, run with a higher // priority, since it's effectively a foreground service if (info.isVisible()) { - builder.setPriority(JobInfo.PRIORITY_FOREGROUND_APP); + builder.setPriority(JobInfo.PRIORITY_FOREGROUND_SERVICE); builder.setFlags(JobInfo.FLAG_WILL_BE_FOREGROUND); } -- cgit v1.2.3