summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix bug with deciding when to restart a download.Steve Howard2010-07-203-21/+36
| | | | | | | | | | | | | | In previous refactoring I had combined the code for starting a download (from DownloadService.insertDownload()) and restarting a download (from DownloadService.updateDownload()). I'd missed the fact that the former checks DownloadInfo.isReadyToStart() while the latter checks DownloadInfo.isReadyToRestart(). This cause a race condition where multiple startService() calls during a download would cause the service to try to spawn a second thread for the same running download. I've fixed the bug and added a test case to exercise this. Change-Id: Ia968331a030137daac7c8b5792a01e3e19065b38
* Support for max download size that may go over mobileSteve Howard2010-07-198-128/+139
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change introduces support for a maximum download size that may go over a mobile connection. Downloads above this limit will wait for a wifi connection. To accomplish this, I moved a lot of the logic for checking connectivity info into DownloadInfo itself. I then moved the code to call these checks from DownloadService, where it would call the checks before spawning a DownloadThread, into DownloadThread itself. This makes it simpler to check connectivity after we get Content-Length info. It also eliminates the risk of a race condition where connectivity changes between the check and the actual request execution. I realize this change reduces efficiency, because we now call into ConnectivityManager/TelephonyManager twice per DownloadThread, rather than once per DownloadService "tick". I feel that it's OK since its a small amount of computation running relatively infrequently. If we feel that it's a serious concern, and that the efficiency issues outweigh the race problem, I can go easily back to the old approach. I've left out the code to actually fetch the limit. I think this will come from system settings, but I want to double-check, so I'll put it in a separate change. Other changes: * simplify SystemFacade's interface to get connectivity info - rather than returning all connected types, just return the active type, since that should be all we care about * adding @LargeTest to PublicApiFunctionalTest Change-Id: Id1faa2c45bf2dade9fe779440721a1d42cbdfcd1
* Merge "Introduce a seam to ConnectivityManager and TelephonyManager" into ↵Steve Howard2010-07-1911-228/+145
|\ | | | | | | gingerbread
| * Introduce a seam to ConnectivityManager and TelephonyManagerSteve Howard2010-07-1511-228/+145
| | | | | | | | | | | | | | | | | | This change abstracts access to ConnectivityManager and TelephonyManager behind methods on SystemFacade, moving the code from Helpers into RealSystemFacade and adding fake implementations to FakeSystemFacade. This facilitates new connectivity tests. Change-Id: Id6c6b861e1d4ca45b3c1572bfb8ae0aa26af756b
* | Revert "fix permissons/targets in download provider tests"Guang Zhu2010-07-162-2/+3
|/ | | | This reverts commit c7717b4d1e6cf51ab8d8de03fe23dcad2dc97f52.
* Merge "Support for custom HTTP headers on download requests" into gingerbreadSteve Howard2010-07-155-175/+295
|\
| * Support for custom HTTP headers on download requestsSteve Howard2010-07-155-175/+295
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Provider changes: * new many-to-one DB table holding headers for each download. since there was no real migration logic in DownloadProvider, I implemented some. * DownloadProvider.insert() reads request headers out of the ContentValues and puts them into the new table * DownloadProvider.query() supports a new URI form, download/#/headers, to fetch the headers associated with a download * DownloadProvider.delete() removes request headers from this table Service changes: * made DownloadInfo store request headers upon initialization. While I was at it, I refactored the initialization logic into DownloadInfo to get rid of the massive 24-parameter constructor. The right next step would be to move the update logic into DownloadInfo and merge it with the initialization logic; however, I realized that headers don't need to be updatable, and in the future, we won't need the update logic at all, so i didn't bother touching the update code. * made DownloadThread read headers from the DownloadInfo and include them in the request; merged the custom Cookie and Referer logic into this logic Also added a couple new test cases for this stuff. Change-Id: I421ce1f0a694e815f2e099795182393650fcb3ff
* | Merge "fix permissons/targets in download provider tests" into gingerbreadGuang Zhu2010-07-152-3/+2
|\ \
| * | fix permissons/targets in download provider testsGuang Zhu2010-07-152-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | * permission tests package should be signed with the same cert as download provider itself * permission tests should not target on itself Change-Id: Ic4307119ed6c41cbffd98fe165ebc360e2b38c8e
* | | Cleanup whitespace in DownloadNotificationSteve Howard2010-07-151-24/+24
| |/ |/| | | | | Change-Id: I598ece9690649573d44d3089e473612e25f2974b
* | Support for file URI destinations + last modified timestampSteve Howard2010-07-144-64/+170
|/ | | | | | | | | | | | | File URI destinations: * permission checking in DownloadProvider * implementation in Helpers.generateSaveFile(). it's a fairly small amount of logic added here, but I did some significant method extraction to simplify this change and clean up the code in general. * added test case Last modified timestamp: * made DownloadProvider use a SystemFacade for getting system time, so I could properly test timestamps * updated test cases to cover last modified time + handle new ordering
* Improve error message when SQL parser gets illegal characterSteve Howard2010-07-131-1/+1
| | | | Change-Id: Ife165361ebd75d558b311710e62abdfbdc355f1b
* New functional test for download manager public API.Steve Howard2010-07-133-246/+535
| | | | | | | | | | I refactored a lot of the logic from DownloadManagerFunctionalTest into a new abstract class so that it could be shared with the new PublicApiFunctionalTest. There could be even more sharing, but it's not entirely clear it'd be worthwhile at this point. The new test covers most features of the new public API. Change-Id: I8c6859411f44b6430f8b348cf26a61225f5768cb
* Change AnimatedImageViews to ImageViews.Steve Howard2010-07-011-2/+2
| | | | | | | The AnimatedImageView class was private and should not have been used. When it was removed, the decision was made to change these to unanimated images. The first frame will show, which should be good enough, and it'll safe a bit of CPU.
* Stub out the system clock in the download manager, add testsSteve Howard2010-07-018-69/+181
| | | | | | | | | | | | | | Introduce SystemFacade, an interface that allows us to stub out the system clock for testing the download manager. This allows us to test retrying a failed download without having the test wait 60 seconds. This interface can include other dependencies in the future as well. I've also used this to add tests for 503 (retry-after) and 301 (redirect), and I've added a test for download to the cache partition. Other changes: * made MockWebServer capable of checking + rethrowing exceptions from child threads * refactoring + cleanup of DownloadManagerFunctionalTest
* Fix build in master - new method in FakeIConnectivityManagerSteve Howard2010-06-291-0/+4
| | | | Change-Id: I76996b9a7b6d0f725480cacb1da032cec2dade0b
* First pass at a functional test for the Download Manager.Steve Howard2010-06-287-27/+648
| | | | | | | | | | | | | | | | | | | | | This "Large" test sets up an HTTP server on the device using MockWebServer and then initiates downloads from that server through the download manager. It uses ServiceTestCase to control the construction and execution of the DownloadService, and it uses some logic from ProviderTestCase2 to construct a DownloadProvider and a ContentResolver that uses it. This setup gives us some ability to mock dependencies. This commit includes use of a fake ConnectivityManager to test responses to connectivity changes, and use of some customizations to MockWebServer to test resuming an interrupted download. This test is disabled, though, since it requires a very long sleep. Avoiding that, and achieving certain other things, will require changes to the Download Manager code itself to introduce new seams. I wanted to check this in before I started such changes. Change-Id: Iefb13b3c3cccdc13fabe5cc18703e13244805539
* am 8fed41c3: Merge "Don\'t inadvertantly include tests in the build." into ↵Steve Howard2010-06-211-1/+2
|\ | | | | | | | | | | | | | | | | kraken Merge commit '8fed41c37e52a3e186e8f36b18a0b6433278acd3' into gingerbread * commit '8fed41c37e52a3e186e8f36b18a0b6433278acd3': Don't inadvertantly include tests in the build.
| * Merge "Don't inadvertantly include tests in the build." into krakenSteve Howard2010-06-211-1/+2
| |\
| | * Don't inadvertantly include tests in the build.Steve Howard2010-06-211-1/+2
| | | | | | | | | | | | Change-Id: Ic57f0b66dd81da1b6acc7132f792b024e974f74c
* | | am 4c54154c: Check in copies of MockWebServer + friends.Steve Howard2010-06-213-0/+486
|\| | | | | | | | | | | | | | | | | | | | Merge commit '4c54154c83a5b3516d81903140b31349f196cbe2' into gingerbread * commit '4c54154c83a5b3516d81903140b31349f196cbe2': Check in copies of MockWebServer + friends.
| * | Check in copies of MockWebServer + friends.Steve Howard2010-06-213-0/+486
| |/ | | | | | | | | | | | | | | | | | | This commit includes unmodified copies of MockWebServer and its supporting classes, taken from dalvik-dev:libcore/support/src/tests/java. My test will require some changes, but I'm committing unchanged versions first so I can more easily track my changes and eventually merge them back over. Change-Id: Ic4b79c7a2cbd3bd439864ed94c43fe985eae8e78
* | am 09330001: Import revised translationsKenny Root2010-06-212-6/+6
|\ \ | |/ |/| | | | | | | | | Merge commit '09330001cc50f8a5ffe2ef527dbb5729080f52e2' into gingerbread * commit '09330001cc50f8a5ffe2ef527dbb5729080f52e2': Import revised translations
| * Import revised translationsKenny Root2010-06-202-6/+6
| | | | | | | | Change-Id: I012450adc3ff91ce5cfbd28e21eed1aa6833c56f
* | merge from open-source masterThe Android Open Source Project2010-05-101-1/+13
|\ \ | |/ |/| | | Change-Id: If84d4054324db6d10fd0cdbd2169c039c6675726
| * code left opened files behindusul2010-05-101-1/+13
| | | | | | | | | | | | | | verified with lsof DownloadProvider after downloading a file shows: ${proc} 338 10034 33w REG 179,0 167634 5 /sdcard/download/fw4-1.pdf Change-Id: I8e2412fe9a6348f5ece6f5ca3a9ebf99a4474bce
| * Merge "Show correct date for downloads in the statusbar"Jean-Baptiste Queru2010-05-101-2/+1
| |\
| | * Show correct date for downloads in the statusbarPer Edelberg2010-02-101-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The date was not set properly in notifications when the text for expanded view was created. This fix sets the displayed time to the download time for each individual file. The DownloadProvider recreates the notifications several times but don't set the time before the expanded message is created. The expanded message will therefore display the time the notification was created and not the time a file was downloaded. The displayed time will in most case be the time when the last file was downloaded. This fix sets the displayed time to the downloaded time for each individual file.
* | | Import revised translationsKenny Root2010-04-274-6/+6
| | | | | | | | | | | | Change-Id: I800cdf6e7d34180e13d7af74abfe0887e1f20316
* | | Adjust DownloadProvider's makefile so its tests get built.Brett Chabot2010-04-051-0/+3
| | | | | | | | | | | | | | | | | | Bug 2562721 Change-Id: I7dfd73d4e30fcc5dc80c9ed024432c0b833a011a
* | | Import revised translationsKenny Root2010-03-1720-40/+60
| | | | | | | | | | | | Change-Id: Iac9bc801179d35cf266b6398c2c6557f5abc524e
* | | Add an empty CleanSpec.mkJean-Baptiste Queru2010-03-081-0/+49
| | | | | | | | | | | | Change-Id: Idbb6ff1607b2885ed2da0749fc99b39f815fac15
* | | Import new translationsEric Fischer2010-03-041-4/+2
| | |
* | | Import new translations.Eric Fischer2010-02-2620-0/+42
| | |
* | | Update to reflect android-common no longer in framework.Dianne Hackborn2010-02-241-1/+1
| | |
* | | Supply a Context to AndroidHttpClient.newInstance(), to enableDan Egnor2010-02-101-1/+1
| | | | | | | | | | | | persistent SSL session caching.
* | | am 29ca9e3a: am 7f75be7e: reconcile main tree with open-source eclairThe Android Open Source Project2010-02-050-0/+0
|\| | | | | | | | | | | | | | | | | | | | Merge commit '29ca9e3a63b63f71b0c4ab9544d0bd5361386751' * commit '29ca9e3a63b63f71b0c4ab9544d0bd5361386751': android-2.1_r1 snapshot
| * | am 7f75be7e: reconcile main tree with open-source eclairThe Android Open Source Project2010-02-050-0/+0
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | Merge commit '7f75be7ea7027a2ad6e7564195333fd075c0b1a0' into eclair-plus-aosp * commit '7f75be7ea7027a2ad6e7564195333fd075c0b1a0': android-2.1_r1 snapshot
| | * \ reconcile main tree with open-source eclairThe Android Open Source Project2010-02-050-0/+0
| | |\ \
| | | * | reconcile android-2.1_r1 snapshotThe Android Open Source Project2010-01-290-0/+0
| | |/| |
| | | * | android-2.1_r1 snapshotThe Android Open Source Project2010-01-122-5/+5
| | | | |
* | | | | Create a new permission that allows apps to see downloads from otherLeon Scroggins2010-02-054-29/+52
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | applications to the SD card. Necessary for http://b/issue?id=2384554 Also create names for files by default, so they do not display as <Untitled>. Remove calls to createTitleFromFilename, which are no longer necessary. Requires a change to frameworks/base.
* | | | | Grant access to downloaded packages to default container.Suchi Amalapurapu2010-01-271-3/+33
| | | | | | | | | | | | | | | | | | | | | | | | | The package name is hardcoded for now but will eventually move to a separate gid guarded by a permission.
* | | | | b/2383073 Use new fine-grained download status codes.Attila Bodis2010-01-261-29/+36
| | | | | | | | | | | | | | | | | | | | | | | | | Takes advantage of two new download status codes (STATUS_DEVICE_NOT_FOUND_ERROR and STATUS_INSUFFICIENT_SPACE_ERROR) when reporting failed download attempts.
* | | | | Revert "Download files even if there is no activity to launch them."Leon Scroggins2010-01-223-11/+68
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 0f1aae327a9e4c68044d767e9bafbac747b6d985. I misunderstood the bug. We do not want to be able to download files for which there is currently no Activity to launch them.
* | | | | Update the title of the download based on the filename.Leon Scroggins2010-01-211-6/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now that the downloads page is not necessarily opened when a download starts, we need to provide a name even if the downloads page isn't shown. So when we create a notification, provide the title. Depends on a change to frameworks/base
* | | | | Download files even if there is no activity to launch them.Leon Scroggins2010-01-213-68/+11
| | | | | | | | | | | | | | | | | | | | Fixes http://b/issue?id=2367247
* | | | | Use the private legacy APIJean-Baptiste Queru2010-01-148-320/+336
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The public API is getting deeply reworked for forward compatibility, but since the Download Manager and the Browser need to continue using the old API, a separate copy is being kept on the side. Bug: 2245521 Change-Id: I85eff6ba9efc68600aa80e8dffa6720b0f2ed155
* | | | | Deprecate fill_parent and introduce match_parent.Romain Guy2010-01-081-10/+10
| | | | | | | | | | | | | | | | | | | | Bug: #2361749.
* | | | | Update with latest translations.Eric Fischer2010-01-0720-45/+5
| | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-04-18 04:35:12 +0000