| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In previous refactoring I had combined the code for starting a
download (from DownloadService.insertDownload()) and restarting a
download (from DownloadService.updateDownload()). I'd missed the fact
that the former checks DownloadInfo.isReadyToStart() while the latter
checks DownloadInfo.isReadyToRestart(). This cause a race condition
where multiple startService() calls during a download would cause the
service to try to spawn a second thread for the same running download.
I've fixed the bug and added a test case to exercise this.
Change-Id: Ia968331a030137daac7c8b5792a01e3e19065b38
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change introduces support for a maximum download size that may go
over a mobile connection. Downloads above this limit will wait for a
wifi connection.
To accomplish this, I moved a lot of the logic for checking
connectivity info into DownloadInfo itself. I then moved the code to
call these checks from DownloadService, where it would call the checks
before spawning a DownloadThread, into DownloadThread itself. This
makes it simpler to check connectivity after we get Content-Length
info. It also eliminates the risk of a race condition where
connectivity changes between the check and the actual request
execution.
I realize this change reduces efficiency, because we now call into
ConnectivityManager/TelephonyManager twice per DownloadThread, rather
than once per DownloadService "tick". I feel that it's OK since its a
small amount of computation running relatively infrequently. If we
feel that it's a serious concern, and that the efficiency issues
outweigh the race problem, I can go easily back to the old approach.
I've left out the code to actually fetch the limit. I think this will
come from system settings, but I want to double-check, so I'll put it
in a separate change.
Other changes:
* simplify SystemFacade's interface to get connectivity info - rather
than returning all connected types, just return the active type,
since that should be all we care about
* adding @LargeTest to PublicApiFunctionalTest
Change-Id: Id1faa2c45bf2dade9fe779440721a1d42cbdfcd1
|
|\
| |
| |
| | |
gingerbread
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This change abstracts access to ConnectivityManager and
TelephonyManager behind methods on SystemFacade, moving the code from
Helpers into RealSystemFacade and adding fake implementations to
FakeSystemFacade. This facilitates new connectivity tests.
Change-Id: Id6c6b861e1d4ca45b3c1572bfb8ae0aa26af756b
|
|/
|
|
| |
This reverts commit c7717b4d1e6cf51ab8d8de03fe23dcad2dc97f52.
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Provider changes:
* new many-to-one DB table holding headers for each download. since
there was no real migration logic in DownloadProvider, I implemented
some.
* DownloadProvider.insert() reads request headers out of the
ContentValues and puts them into the new table
* DownloadProvider.query() supports a new URI form,
download/#/headers, to fetch the headers associated with a download
* DownloadProvider.delete() removes request headers from this table
Service changes:
* made DownloadInfo store request headers upon initialization. While
I was at it, I refactored the initialization logic into DownloadInfo
to get rid of the massive 24-parameter constructor. The right next
step would be to move the update logic into DownloadInfo and merge
it with the initialization logic; however, I realized that headers
don't need to be updatable, and in the future, we won't need the
update logic at all, so i didn't bother touching the update code.
* made DownloadThread read headers from the DownloadInfo and include
them in the request; merged the custom Cookie and Referer logic into
this logic
Also added a couple new test cases for this stuff.
Change-Id: I421ce1f0a694e815f2e099795182393650fcb3ff
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* permission tests package should be signed with the same cert as
download provider itself
* permission tests should not target on itself
Change-Id: Ic4307119ed6c41cbffd98fe165ebc360e2b38c8e
|
| |/
|/|
| |
| | |
Change-Id: I598ece9690649573d44d3089e473612e25f2974b
|
|/
|
|
|
|
|
|
|
|
|
|
|
| |
File URI destinations:
* permission checking in DownloadProvider
* implementation in Helpers.generateSaveFile(). it's a fairly small
amount of logic added here, but I did some significant method
extraction to simplify this change and clean up the code in general.
* added test case
Last modified timestamp:
* made DownloadProvider use a SystemFacade for getting system time, so I could properly test timestamps
* updated test cases to cover last modified time + handle new ordering
|
|
|
|
| |
Change-Id: Ife165361ebd75d558b311710e62abdfbdc355f1b
|
|
|
|
|
|
|
|
|
|
| |
I refactored a lot of the logic from DownloadManagerFunctionalTest
into a new abstract class so that it could be shared with the new
PublicApiFunctionalTest. There could be even more sharing, but it's
not entirely clear it'd be worthwhile at this point. The new test
covers most features of the new public API.
Change-Id: I8c6859411f44b6430f8b348cf26a61225f5768cb
|
|
|
|
|
|
|
| |
The AnimatedImageView class was private and should not have been used.
When it was removed, the decision was made to change these to
unanimated images. The first frame will show, which should be good
enough, and it'll safe a bit of CPU.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Introduce SystemFacade, an interface that allows us to stub out the
system clock for testing the download manager. This allows us to test
retrying a failed download without having the test wait 60 seconds.
This interface can include other dependencies in the future as well.
I've also used this to add tests for 503 (retry-after) and 301
(redirect), and I've added a test for download to the cache partition.
Other changes:
* made MockWebServer capable of checking + rethrowing exceptions from child threads
* refactoring + cleanup of DownloadManagerFunctionalTest
|
|
|
|
| |
Change-Id: I76996b9a7b6d0f725480cacb1da032cec2dade0b
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This "Large" test sets up an HTTP server on the device using
MockWebServer and then initiates downloads from that server through
the download manager. It uses ServiceTestCase to control the
construction and execution of the DownloadService, and it uses some
logic from ProviderTestCase2 to construct a DownloadProvider and a
ContentResolver that uses it.
This setup gives us some ability to mock dependencies. This commit
includes use of a fake ConnectivityManager to test responses to
connectivity changes, and use of some customizations to MockWebServer
to test resuming an interrupted download. This test is disabled,
though, since it requires a very long sleep.
Avoiding that, and achieving certain other things, will require
changes to the Download Manager code itself to introduce new seams. I
wanted to check this in before I started such changes.
Change-Id: Iefb13b3c3cccdc13fabe5cc18703e13244805539
|
|\
| |
| |
| |
| |
| |
| |
| |
| | |
kraken
Merge commit '8fed41c37e52a3e186e8f36b18a0b6433278acd3' into gingerbread
* commit '8fed41c37e52a3e186e8f36b18a0b6433278acd3':
Don't inadvertantly include tests in the build.
|
| |\ |
|
| | |
| | |
| | |
| | | |
Change-Id: Ic57f0b66dd81da1b6acc7132f792b024e974f74c
|
|\| |
| | |
| | |
| | |
| | |
| | |
| | | |
Merge commit '4c54154c83a5b3516d81903140b31349f196cbe2' into gingerbread
* commit '4c54154c83a5b3516d81903140b31349f196cbe2':
Check in copies of MockWebServer + friends.
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This commit includes unmodified copies of MockWebServer and its
supporting classes, taken from
dalvik-dev:libcore/support/src/tests/java. My test will require some
changes, but I'm committing unchanged versions first so I can more
easily track my changes and eventually merge them back over.
Change-Id: Ic4b79c7a2cbd3bd439864ed94c43fe985eae8e78
|
|\ \
| |/
|/|
| |
| |
| |
| | |
Merge commit '09330001cc50f8a5ffe2ef527dbb5729080f52e2' into gingerbread
* commit '09330001cc50f8a5ffe2ef527dbb5729080f52e2':
Import revised translations
|
| |
| |
| |
| | |
Change-Id: I012450adc3ff91ce5cfbd28e21eed1aa6833c56f
|
|\ \
| |/
|/|
| | |
Change-Id: If84d4054324db6d10fd0cdbd2169c039c6675726
|
| |
| |
| |
| |
| |
| |
| | |
verified with lsof DownloadProvider after downloading a file shows:
${proc} 338 10034 33w REG 179,0 167634 5 /sdcard/download/fw4-1.pdf
Change-Id: I8e2412fe9a6348f5ece6f5ca3a9ebf99a4474bce
|
| |\ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The date was not set properly in notifications when the text for
expanded view was created.
This fix sets the displayed time to the download time for each
individual file. The DownloadProvider recreates the notifications
several times but don't set the time before the expanded message
is created. The expanded message will therefore display the time
the notification was created and not the time a file was downloaded.
The displayed time will in most case be the time when the last file
was downloaded. This fix sets the displayed time to the downloaded
time for each individual file.
|
| | |
| | |
| | |
| | | |
Change-Id: I800cdf6e7d34180e13d7af74abfe0887e1f20316
|
| | |
| | |
| | |
| | |
| | |
| | | |
Bug 2562721
Change-Id: I7dfd73d4e30fcc5dc80c9ed024432c0b833a011a
|
| | |
| | |
| | |
| | | |
Change-Id: Iac9bc801179d35cf266b6398c2c6557f5abc524e
|
| | |
| | |
| | |
| | | |
Change-Id: Idbb6ff1607b2885ed2da0749fc99b39f815fac15
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | | |
persistent SSL session caching.
|
|\| |
| | |
| | |
| | |
| | |
| | |
| | | |
Merge commit '29ca9e3a63b63f71b0c4ab9544d0bd5361386751'
* commit '29ca9e3a63b63f71b0c4ab9544d0bd5361386751':
android-2.1_r1 snapshot
|
| |\ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Merge commit '7f75be7ea7027a2ad6e7564195333fd075c0b1a0' into eclair-plus-aosp
* commit '7f75be7ea7027a2ad6e7564195333fd075c0b1a0':
android-2.1_r1 snapshot
|
| | |\ \ |
|
| | |/| | |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
applications to the SD card.
Necessary for http://b/issue?id=2384554
Also create names for files by default, so they do not display as
<Untitled>. Remove calls to createTitleFromFilename, which are
no longer necessary.
Requires a change to frameworks/base.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The package name is hardcoded for now but will eventually move to a separate gid
guarded by a permission.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Takes advantage of two new download status codes (STATUS_DEVICE_NOT_FOUND_ERROR
and STATUS_INSUFFICIENT_SPACE_ERROR) when reporting failed download attempts.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This reverts commit 0f1aae327a9e4c68044d767e9bafbac747b6d985.
I misunderstood the bug. We do not want to be able to download
files for which there is currently no Activity to launch them.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Now that the downloads page is not necessarily opened when a download
starts, we need to provide a name even if the downloads page isn't
shown. So when we create a notification, provide the title.
Depends on a change to frameworks/base
|
| | | | |
| | | | |
| | | | |
| | | | | |
Fixes http://b/issue?id=2367247
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The public API is getting deeply reworked for forward compatibility,
but since the Download Manager and the Browser need to continue using
the old API, a separate copy is being kept on the side.
Bug: 2245521
Change-Id: I85eff6ba9efc68600aa80e8dffa6720b0f2ed155
|
| | | | |
| | | | |
| | | | |
| | | | | |
Bug: #2361749.
|
| | | | | |
|