summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch 'gingerbread' of ↵cm-7.0.3cm-7.0.2.1cm-7.0.1cm-7.0.0Steve Kondik2011-02-2882-178/+2049
|\ | | | | | | git://android.git.kernel.org/platform/packages/providers/DownloadProvider into 233-merge
| * Import revised translations. DO NOT MERGEEric Fischer2011-02-071-2/+2
| | | | | | | | Change-Id: I974bf33097aaaad0a7e79ce36b45de2f22252f15
| * Import revised translations. DO NOT MERGEEric Fischer2011-01-281-2/+2
| | | | | | | | Change-Id: Ib81647ed5436d4949a0c81c9900baf407215b9f5
| * Merge "(GB/GBMR) (do not merge) delete file from disk when deleting from db" ↵Vasu Nori2011-01-162-16/+27
| |\ | | | | | | | | | into gingerbread
| | * (GB/GBMR) (do not merge) delete file from disk when deleting from dbVasu Nori2010-12-032-16/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | bug:3175143 sometimes mediaprovider doesn't delete the file from disk when it is deleted from its db. for example, audio files, pdf files. DownloadManager/DownloadApp should delete the file when it is deleted from downloads db. DO NOT MERGE this is esentially porting HC fix from DownloadService.java to GB Change-Id: I70f3a7ad968f82ccba00d664e9a2993d75a18d15
| * | (GB MR) bug:3351783 don't store redirectcount in dbVasu Nori2011-01-162-9/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | redirectcount shouldn't be stored in the db. say, you are downloading a large app and there are redirects involved inthe download. if network connectivity changes during download, then download is paused and resumed once connectivy is back on. when the download is resumed, it should start with redirectcount of 0 instead of redirectcount from the previous download session. Change-Id: I1acf2fb9491d24f5e109206a91dda3eea429e447
| * | Import translations for additional languages.Eric Fischer2011-01-0640-0/+1880
| | | | | | | | | | | | Change-Id: I1c05f11e064f34a04c021bfa0d2282956827eb51
| * | reconcile with open-source gingerbreadJean-Baptiste Queru2010-12-090-0/+0
| |\ \ | | |/ | |/| | | | Change-Id: I6a6553f8e89f576cf21ee0fb0cba62479f96f2b3
| * | downloads broken by Change-Id: I115b3ba6cfe0262269dbbc4c336b9e1d63c618e4Vasu Nori2010-12-031-1/+1
| | | | | | | | | | | | | | | | | | big typo in that CL broke the downloading functionality. Change-Id: If7dc0f86ea7a3c4394603416ca0fc33847f10fa7
| * | Merge "(GB MR) bug:3144642 temporary small fix in GB MR and real fix in HC" ↵Vasu Nori2010-12-021-1/+2
| |\ \ | | | | | | | | | | | | into gingerbread
| | * | (GB MR) bug:3144642 temporary small fix in GB MR and real fix in HCVasu Nori2010-12-021-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Real fix is in Change-Id: Ifea1544737023008eff44aef9acd976902a0c143 In the database, sometimes _data column in downloads is set to null and sometimes to empty string. this is inconsistent and causes bugs such as bug:3144642. This bug is caused by line# 793 in DownloadThread. state.mFileName is null sometimes and empty string sometimes - because the correspodning field is set inconsistentlt in downloads.db _data column. in GB MR, apply a bandaid because real fix could be too risky for GB. Change-Id: I115b3ba6cfe0262269dbbc4c336b9e1d63c618e4
| * | | Merge "Import revised translations. DO NOT MERGE" into gingerbreadEric Fischer2010-12-0138-150/+133
| |\ \ \ | | |/ / | |/| |
| | * | Import revised translations. DO NOT MERGEEric Fischer2010-12-0138-150/+133
| | | | | | | | | | | | | | | | | | | | | | | | Bug 3245452 Change-Id: Ie2e81528c7a16dce5350f5d6845c8b4c0da15f96
| * | | Don't filter by UID for apps with ACCESS_ALL_DOWNLOADSKenny Root2010-12-011-1/+3
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Old platform behavior of DownloadProvider would allow anyone with special access to access all the downloads. New behavior is to return /my_downloads/ on an .insert() call. For things that aren't using the new API where DownloadInfo.getAllDownloadsUri() is accessible, make any application with ACCESS_ALL_DOWNLOADS permission bypass the calling UID check for /my_downloads/ Bug: 3242328 Change-Id: I536fde4525dd74066879f7c7da7fa609ff344645
* | | Added support for downloading files with unicode charactersAndreas Sandblad2010-12-191-2/+52
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently only certain ASCII characters are allowed in a filename, all other characters are replaced with an underscore. This gives bad usability for foreign languages (e.g. japanese). This fix replaces the current regexp with a method which replaces only those characters unsafe to be used on VFAT filesystems (should work on most other filesystems as well). Change-Id: I114d47b4b35f28490e6b12493138355532fda499 Signed-off-by: Eddie Ringle <eddie.ringle@gmail.com>
* | | Merge "Don't try to purge the dalvik-cache directory on /cache." into ↵Keyan Mobli2010-12-192-4/+7
|\ \ \ | | | | | | | | | | | | gingerbread
| * | | Don't try to purge the dalvik-cache directory on /cache.Steve Kondik2010-12-192-4/+7
| | |/ | |/|
* | | Download any file typeEddie Ringle2010-12-191-37/+1
|/ / | | | | | | | | Change-Id: Ib1712eb3c4d0335e0822be53f9c6fd7b6ac9585e Signed-off-by: Eddie Ringle <eddie.ringle@gmail.com>
* | Don't filter by UID for apps with ACCESS_ALL_DOWNLOADSKenny Root2010-12-091-1/+3
|/ | | | | | | | | | | | Old platform behavior of DownloadProvider would allow anyone with special access to access all the downloads. New behavior is to return /my_downloads/ on an .insert() call. For things that aren't using the new API where DownloadInfo.getAllDownloadsUri() is accessible, make any application with ACCESS_ALL_DOWNLOADS permission bypass the calling UID check for /my_downloads/ Bug: 3242328 Change-Id: I4d7dae75c528d2803d594c5d79d19865ef37ed30
* Import revised translations. DO NOT MERGEEric Fischer2010-10-264-5/+5
| | | | Change-Id: Iadedcf076f8bbe43d1864baf989b21d9d30f13f7
* Import revised translations. DO NOT MERGEEric Fischer2010-10-2540-141/+178
| | | | Change-Id: Id9cdaf0062ee97f067b644bcc00d41182ff52934
* Replace shared storage with USB storage.Eric Fischer2010-10-201-1/+1
| | | | Change-Id: If3fb1c213f9f9c6f21bd1f13f633393a32d2509a
* bug:3083060 UI tweaks to DownloadManager screensVasu Nori2010-10-199-44/+46
| | | | Change-Id: I3c7ee819077d344072deee4cfd61f883c64da758
* Merge "Import revised translations DO NOT MERGE" into gingerbreadKenny Root2010-10-151-2/+2
|\
| * Import revised translations DO NOT MERGEKenny Root2010-10-151-2/+2
| | | | | | | | Change-Id: I21052e55a62dd3d9a9846dec30c3ac12cc9c25af
* | Merge "bug:3099994 NPE in DownloadManager when deleting non-media file" into ↵Vasu Nori2010-10-152-54/+73
|\ \ | |/ |/| | | gingerbread
| * bug:3099994 NPE in DownloadManager when deleting non-media fileVasu Nori2010-10-152-54/+73
| | | | | | | | | | | | | | | | | | | | DownloadService always scans files and assumes MediaProvider returns a valid Uri. But MediaProvider returns null for return param 'uri' if the file is not audio/video/image etc media type file (for example, pdf) Change-Id: If32bd1895b00b5406973a5e240ad3558d46f9f4a
* | Import revised translationsKenny Root2010-10-1440-380/+220
|/ | | | Change-Id: I03a58b6efd2e1a12054bc7dbb320368be6cfdd17
* fix broken build bug:3095237Vasu Nori2010-10-131-3/+1
| | | | Change-Id: I7e1fe99cc482fc270894a820049275fc0c64233e
* bug:3069735 in Download UI app, handle deletes correctlyVasu Nori2010-10-134-37/+157
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | gingerbread. High-level details 1. When a file is downloaded by DownloadManager, metadata about the file is stored in 2 databases: DownloadProvider and MediaProvider. 2. So, when it is to be deleted, its metadata needs to be cleaned up from both the databases. 3. But the 2 databases use differnt content-uri's as "primary keys" and DownloadProvider loses the "primary-key" of the row in MediaProvider database. 4. Easiest thing would have been to have DownloadProvider give filepath to MediaProvider and let MediaProvider linearly scan its database to locate the row and delete it. 5. The other - faster but more coding for now - option is to have DownloadProvider store the "primary-key" of the MediaProvider's row. implemented in this CL. Low-level details 1. add 2 new columns to downloads table in downloads.db: mediaprovider_uri = downloaded file's content_uri in mediaprovider db this column is null for downloads that finished before this column is added to the database. deleted = flag is set to true if a file is to be deleted 2. download UI app shows only those files whose 'deleted' flag is not set. 3. when the user deletes downloads from download UI app, 3.1. if mediaprovider_uri is NOT null, then the row is deleted from downloads table AND from the mediaprovider database. 3.2 if mediaprovider_uri is NULL, then its row in downloads database is marked 'tp be deleted' by setting 'deleted' column to '1'. 4. When DownloadService (in DownloadProvider) processes all rows from downloads table, if it sees any rows wth 'deleted' = 1, then it uses MediaScanner Service to re-scan the file, get the mediaprovider_uri from MediaProvider and update the row in downloads table with this mediaprovider_uri value and then delete the row by doing the following 1. delete it from MediaProvider database using mediaprovider_uri 2. delete it from DownloadProvider database Problem with this solution: There is a small window where it is deleted by the user on the Download app (and the row disappears from the display) but it is still present in Gallery app. Thats due to the following asynchronous operations 1. DownladService which processes rows-to-be-deleted is not always up 2. DownloadService uses asynchronous call to have the file re-scanned by MediaScanner to get mediaprovider_uri Change-Id: Ib90eb9e647f543312c865d3bbf9a06fb867a648b
* Merge "Make DownloadProvider use parameterized queries." into gingerbreadSteve Howard2010-10-081-39/+57
|\
| * Make DownloadProvider use parameterized queries.Steve Howard2010-10-081-39/+57
| | | | | | | | | | | | | | | | This avoids filling up the query cache unnecessary, but required some structural changes to ease the passing around of a selection along with its arguments. Change-Id: I724185763b94146d17573cab68f675c24e49634e
* | Import revised translations. DO NOT MERGEEric Fischer2010-10-0640-320/+180
|/ | | | Change-Id: I1f00b783250d0c4112cf7918f9ab05f83c209407
* Merge "Updated assets for downloads UI launcher icon" into gingerbreadSteve Howard2010-10-042-0/+0
|\
| * Updated assets for downloads UI launcher iconSteve Howard2010-09-282-0/+0
| | | | | | | | Change-Id: I0dc0ef687ebc33a19b3af070df2722840a20eba1
* | Merge "Seriously improve error reporting in DownloadThread." into gingerbreadSteve Howard2010-10-014-198/+164
|\ \
| * | Seriously improve error reporting in DownloadThread.Steve Howard2010-09-304-198/+164
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | My old error reporting strategy for DownloadThread was to log the stack trace for the exception, so we'd know exactly what conditions caused the StopRequest. hackbod suggested that we shouldn't log tracebacks as they clutter the log. Instead, we should just always include a little string tag explaining why the request is being stopped -- this is more concise and more useful to developers. There are three main changes here to acheive this goal: * make StopRequest require a short, log-friendly error message upon construction, and add such a message to all construction sites * make a similar change to GenerateSaveFileError, so that the variety of errors that originate with Helpers.generateSaveFile() get similarly fine-grained and concise error reporting * make network usable checking code return a distinct error code for each distinct negative condition, and add a utility to return a log-friendly error message for each such code. Finally, I cleaned up some of the ways errors/exceptions are handled in the process. Change-Id: Ie70cbf3f2960e260e97f8449258e25218d0f900f
* | | Avoid NPE when checking file URI in DownloadProviderSteve Howard2010-09-301-1/+2
|/ / | | | | | | Change-Id: Ic937b05308cecce244725e25767a3a1310a8463d
* | Merge "Handle null local URI when deleting a download." into gingerbreadSteve Howard2010-09-301-3/+5
|\ \
| * | Handle null local URI when deleting a download.Steve Howard2010-09-301-3/+5
| | | | | | | | | | | | | | | | | | | | | | | | I'd written this to assume a non-null local URI, but I forgot the legacy downloads can still have null local URI, so this handling needs to remain until the legacy API is dead and gone. Change-Id: Icfe8dc2a6fead03b09cabe684c713fb6f0e6c1ab
* | | Merge "Import revised translations. DO NOT MERGE" into gingerbreadEric Fischer2010-09-3040-121/+1161
|\ \ \
| * | | Import revised translations. DO NOT MERGEEric Fischer2010-09-2940-121/+1161
| | | | | | | | | | | | | | | | Change-Id: I27a5fc3ab9bd0fd3e6d9db674ef32077d623e7b6
* | | | Make downloads UI singleTop.Steve Howard2010-09-301-1/+2
| |/ / |/| | | | | | | | | | | | | | | | | | | | Browser downloads, when clicked, will launch the downloads UI. When clicked from the downloads UI (as opposed to a notification), we don't want to launch a second copy of the downloads UI activity. Change-Id: I0ae546bb423814f1bd1d6481085bf5f237d1213b
* | | Improve how the download manager reports paused statuses.Steve Howard2010-09-299-127/+105
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change makes the download manager report more detail when a download is paused. Rather than always reporting status RUNNING_PAUSED, there are now four different statuses: * paused by the app * waiting to retry after a network error * waiting for network connectivity * queued for wifi due to size limits This allows a few improvements: * code deciding when to run a download can be improved and cleaned up (I've taken some extra steps in cleaning up this particular code) * notification code no longer has to rely on the in-memory-only "mPausedReason" member of DownloadInfo; instead, it knows from the status that the download is queued for wifi, and can display the appropriate string. This moves the string fetching out into the UI-specific logic and is a sign that this is really the right way to do things. And finally, the real motivation for this change: I've changed the meaning of "Queued" in the downloads UI so it now means "Queued for WiFi'. This is what was originally intended, I'd misunderstood. What was formerly known as "Queued", a download that hadn't started, is now displayed as "In progress" (it's always a transient state so it's basically meaningless anyway). Otherwise it remains the same (in particular, downloads paused for other reasons are still reported as "In progress"). I've also increased some of the logging in DownloadThread a bit, as this change initally introduced some bugs that were impossible to track down without that logging. There have been other bug reports that were impossible to diagnose and these few extra log statements should really help, without cluttering logs too much. I've taken care to avoid potentially introducing any PII into the logs. Change-Id: Id0b8d65fc8e4406ad7ffa1439ffc22a0281b051f
* | Merge "Split strings with SD card references into variations." into gingerbreadEric Fischer2010-09-291-1/+3
|\ \
| * | Split strings with SD card references into variations.Eric Fischer2010-09-281-1/+3
| | | | | | | | | | | | Change-Id: I62562315a3b0691ee3a541e320b42463cff65265
* | | Merge "Trim the database & check spurious files off the UI thread." into ↵Brad Fitzpatrick2010-09-281-2/+3
|\ \ \ | |_|/ |/| | | | | gingerbread
| * | Trim the database & check spurious files off the UI thread.Brad Fitzpatrick2010-09-281-2/+3
| |/ | | | | | | Change-Id: I92180fc4344579b93361d5584243688a1cfdd091
* | Moved DownloadManager to android.app (DO NOT MERGE)Steve Howard2010-09-2710-10/+10
|/ | | | | | | I'll merge this manually, as there's some additional master-only code that will be to be simultaneously changed. Change-Id: Ifdb1740f32e228bc07f266585737b98a7b794685
* Ensure that downloads UI switches to/from empty view as neededSteve Howard2010-09-271-8/+33
| | | | | Change-Id: I0eef5efd7affc34c465ce04234713874c8d6937e Bug: 3038070