diff options
author | Steve Howard <showard@google.com> | 2010-08-02 11:52:16 -0700 |
---|---|---|
committer | Steve Howard <showard@google.com> | 2010-08-16 11:54:30 -0700 |
commit | e61798da80558450f580ed948d0d469bd6423d8e (patch) | |
tree | 76cbd7d08222baf2fdc2307f4821c2d7a8d7d631 /src | |
parent | 99de0992f03c5b4a1611d25db1df0773433dea7c (diff) | |
download | android_packages_providers_DownloadProvider-e61798da80558450f580ed948d0d469bd6423d8e.tar.gz android_packages_providers_DownloadProvider-e61798da80558450f580ed948d0d469bd6423d8e.tar.bz2 android_packages_providers_DownloadProvider-e61798da80558450f580ed948d0d469bd6423d8e.zip |
Extend PublicApiAccessTest to exercise DownloadManager.
This change adds a new test case to PublicApiAccessTest to enqueue a
request through DownloadManager, ensuring that the values constructed
by DownloadManager fit within the allowed bounds. It also fixes a bug
with allowing http header values exposed by the new test.
Change-Id: I94fec57d7a41298ac42ddaab338516e6a60c4e75
Diffstat (limited to 'src')
-rw-r--r-- | src/com/android/providers/downloads/DownloadProvider.java | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/src/com/android/providers/downloads/DownloadProvider.java b/src/com/android/providers/downloads/DownloadProvider.java index 41b732f1..4fcae227 100644 --- a/src/com/android/providers/downloads/DownloadProvider.java +++ b/src/com/android/providers/downloads/DownloadProvider.java @@ -46,6 +46,7 @@ import com.google.common.annotations.VisibleForTesting; import java.io.File; import java.io.FileNotFoundException; import java.util.HashSet; +import java.util.Iterator; import java.util.Map; @@ -518,6 +519,13 @@ public final class DownloadProvider extends ContentProvider { values.remove(Downloads.Impl.COLUMN_NOTIFICATION_PACKAGE); // checked later in insert() values.remove(Downloads.Impl.COLUMN_ALLOWED_NETWORK_TYPES); values.remove(Downloads.Impl.COLUMN_ALLOW_ROAMING); + Iterator<Map.Entry<String, Object>> iterator = values.valueSet().iterator(); + while (iterator.hasNext()) { + String key = iterator.next().getKey(); + if (key.startsWith(Downloads.Impl.RequestHeaders.INSERT_KEY_PREFIX)) { + iterator.remove(); + } + } // any extra columns are extraneous and disallowed if (values.size() > 0) { |