diff options
| author | Steve Howard <showard@google.com> | 2010-08-18 09:05:12 -0700 |
|---|---|---|
| committer | Android (Google) Code Review <android-gerrit@google.com> | 2010-08-18 09:05:12 -0700 |
| commit | 7bdfb134c6c1c4e3d4c5da61327e62bc38407c95 (patch) | |
| tree | 5c998b1ece8a293c55962d17fb61be8c7693cbd1 /src | |
| parent | 0937e177818843f24a9d6b17c06fadb21886d005 (diff) | |
| parent | a89321ea04ced76d06f60f5909be203cb654a830 (diff) | |
| download | android_packages_providers_DownloadProvider-7bdfb134c6c1c4e3d4c5da61327e62bc38407c95.tar.gz android_packages_providers_DownloadProvider-7bdfb134c6c1c4e3d4c5da61327e62bc38407c95.tar.bz2 android_packages_providers_DownloadProvider-7bdfb134c6c1c4e3d4c5da61327e62bc38407c95.zip | |
Merge "Fix and test handling of null/empty download fields." into gingerbread
Diffstat (limited to 'src')
| -rw-r--r-- | src/com/android/providers/downloads/DownloadProvider.java | 12 |
1 files changed, 10 insertions, 2 deletions
diff --git a/src/com/android/providers/downloads/DownloadProvider.java b/src/com/android/providers/downloads/DownloadProvider.java index 4fcae227..f6b091b1 100644 --- a/src/com/android/providers/downloads/DownloadProvider.java +++ b/src/com/android/providers/downloads/DownloadProvider.java @@ -415,8 +415,8 @@ public final class DownloadProvider extends ContentProvider { if (Binder.getCallingUid() == 0) { copyInteger(Constants.UID, values, filteredValues); } - copyString(Downloads.Impl.COLUMN_TITLE, values, filteredValues); - copyString(Downloads.Impl.COLUMN_DESCRIPTION, values, filteredValues); + copyStringWithDefault(Downloads.Impl.COLUMN_TITLE, values, filteredValues, ""); + copyStringWithDefault(Downloads.Impl.COLUMN_DESCRIPTION, values, filteredValues, ""); filteredValues.put(Downloads.Impl.COLUMN_TOTAL_BYTES, -1); if (isPublicApi) { @@ -986,6 +986,14 @@ public final class DownloadProvider extends ContentProvider { } } + private static final void copyStringWithDefault(String key, ContentValues from, + ContentValues to, String defaultValue) { + copyString(key, from, to); + if (!to.containsKey(key)) { + to.put(key, defaultValue); + } + } + private class ReadOnlyCursorWrapper extends CursorWrapper implements CrossProcessCursor { public ReadOnlyCursorWrapper(Cursor cursor) { super(cursor); |