Improve file error reporting + new detailed error messages in UI

* support new error code for "destination file already exists"
* improve error handling for various file error cases to return a more
  specific error code when appropriate
* make UI support more detailed error messages for some cases
* use Uri.getPath() instead of Uri.getSchemeSpecificPart() for file
  URIs

Change-Id: Icb01d4d3b47c7776be3ddcd8347212e950cd023e

1 files changed, 12 insertions, 3 deletions

diff --git a/src/com/android/providers/downloads/DownloadThread.java b/src/com/android/providers/downloads/DownloadThread.java
index b2353e16..57007f49 100644
--- a/src/com/android/providers/downloads/DownloadThread.java
+++ b/src/com/android/providers/downloads/DownloadThread.java
@@ -426,9 +426,18 @@ public class DownloadThread extends Thread {
                 }
                 return;
             } catch (IOException ex) {
-                if (mInfo.isOnCache()
-                        && Helpers.discardPurgeableFiles(mContext, Constants.BUFFER_SIZE)) {
-                    continue;
+                if (mInfo.isOnCache()) {
+                    if (Helpers.discardPurgeableFiles(mContext, Constants.BUFFER_SIZE)) {
+                        continue;
+                    }
+                } else if (!Helpers.isExternalMediaMounted()) {
+                    throw new StopRequest(Downloads.Impl.STATUS_DEVICE_NOT_FOUND_ERROR);
+                }
+
+                long availableBytes =
+                    Helpers.getAvailableBytes(Helpers.getFilesystemRoot(state.mFilename));
+                if (availableBytes < bytesRead) {
+                    throw new StopRequest(Downloads.Impl.STATUS_INSUFFICIENT_SPACE_ERROR, ex);
                 }
                 throw new StopRequest(Downloads.Impl.STATUS_FILE_ERROR, ex);
             }