Introduce a seam to ConnectivityManager and TelephonyManager

This change abstracts access to ConnectivityManager and
TelephonyManager behind methods on SystemFacade, moving the code from
Helpers into RealSystemFacade and adding fake implementations to
FakeSystemFacade.  This facilitates new connectivity tests.

Change-Id: Id6c6b861e1d4ca45b3c1572bfb8ae0aa26af756b

1 files changed, 8 insertions, 2 deletions

diff --git a/src/com/android/providers/downloads/DownloadReceiver.java b/src/com/android/providers/downloads/DownloadReceiver.java
index e8f10e7d..0b4a12da 100644
--- a/src/com/android/providers/downloads/DownloadReceiver.java
+++ b/src/com/android/providers/downloads/DownloadReceiver.java
@@ -38,7 +38,13 @@ import java.io.File;
  */
 public class DownloadReceiver extends BroadcastReceiver {
 
+    SystemFacade mSystemFacade = null;
+
     public void onReceive(Context context, Intent intent) {
+        if (mSystemFacade == null) {
+            mSystemFacade = new RealSystemFacade(context);
+        }
+
         if (intent.getAction().equals(Intent.ACTION_BOOT_COMPLETED)) {
             if (Constants.LOGVV) {
                 Log.v(Constants.TAG, "Receiver onBoot");
@@ -52,7 +58,7 @@ public class DownloadReceiver extends BroadcastReceiver {
                     intent.getParcelableExtra(ConnectivityManager.EXTRA_NETWORK_INFO);
             if (info != null && info.isConnected()) {
                 if (Constants.LOGX) {
-                    if (Helpers.isNetworkAvailable(context)) {
+                    if (Helpers.isNetworkAvailable(mSystemFacade)) {
                         Log.i(Constants.TAG, "Broadcast: Network Up");
                     } else {
                         Log.i(Constants.TAG, "Broadcast: Network Up, Actually Down");
@@ -61,7 +67,7 @@ public class DownloadReceiver extends BroadcastReceiver {
                 context.startService(new Intent(context, DownloadService.class));
             } else {
                 if (Constants.LOGX) {
-                    if (Helpers.isNetworkAvailable(context)) {
+                    if (Helpers.isNetworkAvailable(mSystemFacade)) {
                         Log.i(Constants.TAG, "Broadcast: Network Down, Actually Up");
                     } else {
                         Log.i(Constants.TAG, "Broadcast: Network Down");