diff options
author | Jeff Sharkey <jsharkey@android.com> | 2013-03-25 13:54:29 -0700 |
---|---|---|
committer | Jeff Sharkey <jsharkey@android.com> | 2013-03-25 13:54:29 -0700 |
commit | 703bc3a83056a878a83e263b992fb5331b84535f (patch) | |
tree | 314689a9bc53b284bacb1d257849d84de3ce7ff8 /src/com/android/providers/downloads/DownloadInfo.java | |
parent | 2c462097d100646ec7491b5fd5fa00ae7ff49200 (diff) | |
download | android_packages_providers_DownloadProvider-703bc3a83056a878a83e263b992fb5331b84535f.tar.gz android_packages_providers_DownloadProvider-703bc3a83056a878a83e263b992fb5331b84535f.tar.bz2 android_packages_providers_DownloadProvider-703bc3a83056a878a83e263b992fb5331b84535f.zip |
Reduce logging, dump stacks before wtf().
Most wtf() are looking like network timeouts, not threading bugs, so
disable verbose debugging and add more targeted thread logging before
calling wtf().
Bug: 8233041
Change-Id: I8e276bffd7880cfe13b65e7e81f5507cab627692
Diffstat (limited to 'src/com/android/providers/downloads/DownloadInfo.java')
-rw-r--r-- | src/com/android/providers/downloads/DownloadInfo.java | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/src/com/android/providers/downloads/DownloadInfo.java b/src/com/android/providers/downloads/DownloadInfo.java index e6ed059b..7a912d5a 100644 --- a/src/com/android/providers/downloads/DownloadInfo.java +++ b/src/com/android/providers/downloads/DownloadInfo.java @@ -247,7 +247,10 @@ public class DownloadInfo { * {@link #startDownloadIfReady(ExecutorService)}. */ @GuardedBy("this") - private Future<?> mActiveDownload; + private Future<?> mSubmittedTask; + + @GuardedBy("this") + private DownloadThread mTask; private final Context mContext; private final SystemFacade mSystemFacade; @@ -455,7 +458,7 @@ public class DownloadInfo { public boolean startDownloadIfReady(ExecutorService executor) { synchronized (this) { final boolean isReady = isReadyToDownload(); - final boolean isActive = mActiveDownload != null && !mActiveDownload.isDone(); + final boolean isActive = mSubmittedTask != null && !mSubmittedTask.isDone(); if (isReady && !isActive) { if (mStatus != Impl.STATUS_RUNNING) { mStatus = Impl.STATUS_RUNNING; @@ -464,9 +467,9 @@ public class DownloadInfo { mContext.getContentResolver().update(getAllDownloadsUri(), values, null, null); } - final DownloadThread task = new DownloadThread( + mTask = new DownloadThread( mContext, mSystemFacade, this, mStorageManager, mNotifier); - mActiveDownload = executor.submit(task); + mSubmittedTask = executor.submit(mTask); } return isReady; } |