| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Peek mode allows CV fragments to be visible but not marked viewed and
read. TPC keeps a global flag for whether the current conversation
should be peeked vs marked read. I have tried to manually reset the
flag in the 6 cases that cause the current conversation to change:
1. tap another conversation (don't peek)
2. swipe to another conversation (don't peek)
3. keyboard-advance to another conversation (peek)
4. auto-advance=newer|older (don't peek)
5. auto-advance=list (go older & peek)
6. empty CV and a list cursor has loaded (peek at i=0)
Swipe, in particular, required a new onConversationViewSwitched() call
in CPA because onPageSelected() is triggered both when swiping around in
the view pager AND when simply setting the initial page as part of
constructing a view pager.
Thankfully, there is only ever one copy of this peek flag in the app, in
TPC, since AAC/TPC is where all the work is done both to mark
conversations seen and to switch to new conversations.
Rotation to portrait on tablets now requires tearing down a ViewPager;
this code and thought process is documented here: http://go/xqaxk
TODO: selected indicator for transition from peek->read state in-place
TODO: touches in CVF should mark it read
Bug: 17291366
Change-Id: I24f71a2b7985773814d8caad9f3ab3fe5c3609c8
|
|
|
|
|
|
|
|
|
|
| |
Vacation responder and compose should look consistent in
terms of width and overall layout, so let's use the same
styles.
b/16131652
Change-Id: I08c62627ebf3917ba2bc72e816fa60f2a5c4ca55
|
|
|
|
|
|
|
|
|
|
|
| |
- instead of setting the title padding, simply set the
full width of the parent accordingly for two-pane land.
- only call onConversationListlayout in tablet landscape mode.
- change from visibility to alpha animation to ease the
transition.
- set the icon to not be clickable when invisible.
Change-Id: If992c97c96eff334a3de82c2583bcdd10e391ed6
|
|
|
|
|
|
|
|
|
|
|
| |
When in conversation view mode, we were not showing
any text on the title bar (setEmptyMode). Changed it to
be visible if in landscape by checking the
is_tablet_landscape boolean (renamed), which we currently
use with TwoPaneController.
Bug: 16985409
Change-Id: I9a35b3b46f024584e1c47936def5aa854c52813d
|
|
|
|
|
|
|
|
|
| |
Until I can find a better way to incorporate
the theme color, just set it to white.
b/17265213
Change-Id: Ib97d1abd98a9635e80374b2e7056533b178f1b59
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove search from the default menu items and add
the search button to a custom view so we can position
it ourselves. This involved extending the toolbar
class because custom views cover up the toolbar
title by default.
b/17070560
Change-Id: Iba7d127a58b8061d84228732fcadbd82665d0835
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I apologize in advance for this huge CL.
- New icons (yay!)
- Abandon framework search and handle in-app search
functionality ourselves. This is made possible because
we use Toolbar and can position any custom view on top.
- Remove all previous search related attributes, including
search providers, searchable, search authority, default
search menu item layout, etc.
- Cleaned up the recent history provider to contain only
the functionalities we need - query, add, and delete.
Instead of using the framework to add recent queries,
we directly insert into our database. Since the provider
no longer needs to extend ContentProvider, removed
some unnecessary callbacks such as onCreate.
- Custom quantum search views:
- Top search bar, this is inserted in a FrameLayout
on top of Toolbar. The search bar interacts with
the suggestion list and AbstractActivityController
via the QuantumSearchViewController interface.
- Suggestions list, this is inserted in the FrameLayout
that typically contains the main content pane for
either one-pane or two-pane layouts. Again, this
interacts with the action bar via the controller.
- Voice search, this is simply an implicit intent
that converts speech to text.
b/16518233
Change-Id: I589c40e6c6e3d8c719856b735d0c53e8db986e65
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently only for MailActivity, ComposeActivity,
and FolderSelectionActivity.
Any activity that inherits from ActionBarActivity must
use an Appcompat-derived style. Three styles currently
exist: UnifiedEmail.Appcompat, UnifiedEmail.Appcompat.Toolbar,
and ShortcutWidgetTheme are all based on appcompat.
go/appcompat-material-doc contains the full migration guide.
The fast version is:
All MenuItem-related work that relates to actions must use
the MenuItemCompat-equivalent.
Any theming should use the appcompat versions which don't require
a namespace prefix. For instance, use actionBarStyle instead of
android:actionBarStyle.
There are a few missing styles on views that can't use appcompat versions.
Those still use style overrides for v21 changes. All others use appcompat versions.
A few methods on activity should now use the support equivalents:
getSupportActionBar()
supportInvalidateOptionsMenu()
startSupportActionMode()
Change-Id: Ic6f5964f4115ab4bde49c19df5fe49c9086df965
|
|
|
|
|
|
|
|
|
| |
Tablet landscape paddings were off because it didn't
inherit the attributes from the default ComposeArea.
b/16383133
Change-Id: I9d21fa2fbb310481b8b066a21b0571914f8cb54e
|
|
|
|
|
|
|
|
|
| |
Temporarily using ic_forward_24dp as placeholder until
I get the correct asset for the dropdown buttons.
b/15934812
Change-Id: I760a1717a73f7c3ab1ad5a3368fac297e883231c
|
|
|
|
| |
Change-Id: I2ead2c64a7451e985f34b8bda210aa7dec3e8275
|
|
|
|
| |
Change-Id: I40b6fe884e551619b400484f7cc2e971a0e18fae
|
|
|
|
| |
Change-Id: I38b44bc518d58bee859a655cf68ec4f669063d78
|
|
|
|
| |
Change-Id: I191e58f33cb77cac1302c283eb4afebbfb99c06f
|
|
|
|
| |
Change-Id: I8bb38ac918f061cd9ed4ad21d9ed686672dbde15
|
|
|
|
|
|
|
| |
Death to constants.
Bug: 8872920
Change-Id: Ic90ddac4b741ec57dd59aadf4d3d426d9813e105
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added 'spacious' variant of NORMAL list item layout.
Because the determination of whether to use tight or spacious dimensions
isn't easy with resource qualifiers (think of 7" tablet, which uses
tight dimensions for 2-pane side-by-side layout, but spacious dimensions
in portrait), I just made a whole new layout for this permutation.
Please remember to maintain NORMAL, WIDE, and now NORMAL/spacious
variants!
Use WIDE mode + drawer on landscape 7" tablet.
Make 2-pane controller and layout drawer-aware. Pull up drawer code into
the common controller base class. 10" 2-pane continues to not use a
drawer.
Don't use a resource qualifier to decide between normal and wide item
layouts (same reason as spacious dimensions above). Use the actual item
width as a dimensional test (list_min_width_is_wide).
Use default drawer scrim color.
TODO:
the conversation-open animation is janky looking.
can't open the drawer in conv mode/7" landscape
Bug: 8578806
Change-Id: I1210b1d47d1756353f7c386873465751ca21f801
|
|
|
|
|
|
|
|
| |
Measure at runtime based on whether folders are showing, the font size,
the font weight, and the the max width of folders being drawn inline.
This does not affect wide mode.
Change-Id: Ia0293fd5036ba93f5bfc03e1693b5f4acbf33103
|
|
|
|
|
|
|
|
|
|
| |
from the array.
If not, default to conversation list length.
Fixes b/7960035 gmail crashes when searching
Change-Id: Ieaa472e8b79637615a103bf9a33ec08a3bdcd6e5
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
length for subject.
Also, a fix for:
b/7937635 Senders text displayed as "e": need to figure out why the single sender was being
marked as elided at all so leaving the issue open
Considering an option in which I divide the subject into 2 textviews and ellipsize based on
length...
Part of matching redlines.
Change-Id: I109001fb1d52c032d489bf7d3a0a6e925a9d7f1a
|
|
|
|
|
|
|
|
|
| |
Functional changes: compose.xml layout uses the ComposeArea style which causes
all portrait tablet orientations to have no margin and 80dip padding. This is
desirable.
Bug: 7382467
Change-Id: I45af05211b57d03b51b11895a098828d60f5df7b
|
|
|
|
|
|
|
|
|
| |
That way, we don't have to wait for 2 pane to complete layout
to know how wide to make it.
Fixes b/7267726 undo bar resizes on rotate
Change-Id: Ie442ad3772b9130fa5a368388a661cd343e7c8b6
|
|
|
|
|
|
|
| |
This means we don't have to override per mode, orientation, etc.
And we don't have to wait for a layout
Change-Id: Icd914791184b03e79a92d3b321e28d973cf86992
|
|
|
|
|
|
| |
Best would be to get the real width when i go to move it, but I keep
getting zero...thees an investigation for another time...
Change-Id: Icf67bc6c76a181233b25f770e0aa18b6d329453d
|
|
Mostly a port of Gmail1 code. New and noteworthy:
* when switching between ActionBar list nav vs. custom display,
toggle ActionBar.DISPLAY_SHOW_CUSTOM rather than messing with
custom view visibility
* This exposes something of a framework bug where collapsing
an action view will leave views for all inactive navigation
modes GONE, which I work around for now (b/6664203).
* ActionBar views were being inflated with system default Holo
theme due to application vs. ActionBar context (wrong theme on
the application context). Fixed that and un-inverted some
existing styles.
* SnippetTextView: save off the last measurespec rather than
inventing one as before.
* bring back an existing excellent behavior: since
PagerAdapter.setPrimaryItem reacts too slowly to nicely
change the action bar subject when paging, listen for
OnPageChangeListener.onPageSelected in addition.
Bug: 6384157
Change-Id: I45d995a472d4b3c71f1371dc7b993923423b7cf7
|