Fade in/out the search bar

When showing/hiding the search bar, fade it in/out instead of
simply setting the visibility.

Other changes:
- remove the check for state change inside showSearchActionBar because
  we previously assumed that a given state will always look the same.
  However, this is no longer true as ONLY_ACTIONBAR looks different
  on tablet landscape verses portrait (landscape shows the transparent
  background while portrait always shows the white search bar).

b/17546831

Change-Id: I9120afd3ff89a4c6611b3b4510c2d8427285f3d8

1 files changed, 2 insertions, 2 deletions

diff --git a/src/com/android/mail/ui/OnePaneController.java b/src/com/android/mail/ui/OnePaneController.java
index fb6c0c835..582daeeac 100644
--- a/src/com/android/mail/ui/OnePaneController.java
+++ b/src/com/android/mail/ui/OnePaneController.java
@@ -547,8 +547,8 @@ public final class OnePaneController extends AbstractActivityController {
     }
 
     @Override
-    public boolean shouldShowSearchBarByDefault() {
-        return mViewMode.getMode() == ViewMode.SEARCH_RESULTS_LIST;
+    public boolean shouldShowSearchBarByDefault(int viewMode) {
+        return viewMode == ViewMode.SEARCH_RESULTS_LIST;
     }
 
     @Override