summaryrefslogtreecommitdiffstats
path: root/src/com/android/mail/browse/ConversationPagerController.java
diff options
context:
space:
mode:
authorAndy Huang <ath@google.com>2012-09-05 19:41:44 -0700
committerAndy Huang <ath@google.com>2012-09-05 19:41:53 -0700
commit7d64612104fd861474a09994f13768360f92041d (patch)
treea434b94ab852c635aeec8e8772dd36e7a43e0717 /src/com/android/mail/browse/ConversationPagerController.java
parent79d51d2a70bdbb40b526d640215fbea16834b475 (diff)
downloadandroid_packages_apps_UnifiedEmail-7d64612104fd861474a09994f13768360f92041d.tar.gz
android_packages_apps_UnifiedEmail-7d64612104fd861474a09994f13768360f92041d.tar.bz2
android_packages_apps_UnifiedEmail-7d64612104fd861474a09994f13768360f92041d.zip
avoid doing fragment work during pager swipe
Pager swipe was triggering immediate fragment transactions via mark-read, so just don't call onConversationSeen so early. All that really needs to happen immediately when swiping is: a) subject-in-actionbar should be updated, and b) conversation list highlight should change. Do both of those now in AAC.setCurrentConversation, and do only that. Bug: 6976876 Change-Id: I1f679627b36d25faabc27eb7dc9dac191aab1d7b
Diffstat (limited to 'src/com/android/mail/browse/ConversationPagerController.java')
-rw-r--r--src/com/android/mail/browse/ConversationPagerController.java25
1 files changed, 1 insertions, 24 deletions
diff --git a/src/com/android/mail/browse/ConversationPagerController.java b/src/com/android/mail/browse/ConversationPagerController.java
index 2de3a5dfd..e2692f549 100644
--- a/src/com/android/mail/browse/ConversationPagerController.java
+++ b/src/com/android/mail/browse/ConversationPagerController.java
@@ -17,10 +17,8 @@
package com.android.mail.browse;
-import android.app.Fragment;
import android.app.FragmentManager;
import android.support.v4.view.ViewPager;
-import android.support.v4.view.ViewPager.OnPageChangeListener;
import android.view.View;
import com.android.mail.R;
@@ -52,7 +50,7 @@ import com.android.mail.utils.LogUtils;
* lifetime.
*
*/
-public class ConversationPagerController implements OnPageChangeListener {
+public class ConversationPagerController {
private ViewPager mPager;
private ConversationPagerAdapter mPagerAdapter;
@@ -110,8 +108,6 @@ public class ConversationPagerController implements OnPageChangeListener {
mPagerAdapter.setPager(mPager);
LogUtils.d(LOG_TAG, "IN CPC.show, adapter=%s", mPagerAdapter);
- mPager.setOnPageChangeListener(this);
-
LogUtils.d(LOG_TAG, "init pager adapter, count=%d initial=%s", mPagerAdapter.getCount(),
initialConversation.subject);
mPager.setAdapter(mPagerAdapter);
@@ -142,7 +138,6 @@ public class ConversationPagerController implements OnPageChangeListener {
LogUtils.d(LOG_TAG, "IN CPC.hide, clearing adapter and unregistering list observer");
mPager.setAdapter(null);
- mPager.setOnPageChangeListener(null);
cleanup();
}
@@ -170,24 +165,6 @@ public class ConversationPagerController implements OnPageChangeListener {
}
}
- @Override
- public void onPageScrolled(int position, float positionOffset, int positionOffsetPixels) {
- // no-op
- }
-
- @Override
- public void onPageSelected(int position) {
- final Fragment f = mPagerAdapter.getFragmentAt(position);
- if (f != null) {
- mPagerAdapter.setItemVisible(f, true);
- }
- }
-
- @Override
- public void onPageScrollStateChanged(int state) {
- // no-op
- }
-
/**
* Stops listening to changes to the adapter. This must be followed immediately by
* {@link #hide(boolean)}.