From ee82b035dbaf0cba73ffd856ddc97d092728dc34 Mon Sep 17 00:00:00 2001 From: Tony Wickham Date: Thu, 13 Apr 2017 15:31:37 -0700 Subject: Ensure system shortcut icons always appear in correct order - Remove "|| true" that I accidentally left in from testing on a different CL - Always reverse system shortcut icons that appear in the header of the ShortcutsItemView, so they are in priority order from right to left Bug: 35766387 Change-Id: Ia7ac5a72eb2f6d3795e35bd044c426ef46fc0ccc --- src/com/android/launcher3/popup/PopupContainerWithArrow.java | 2 +- src/com/android/launcher3/shortcuts/ShortcutsItemView.java | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/com/android/launcher3/popup/PopupContainerWithArrow.java b/src/com/android/launcher3/popup/PopupContainerWithArrow.java index 99c7e754c..d2512def5 100644 --- a/src/com/android/launcher3/popup/PopupContainerWithArrow.java +++ b/src/com/android/launcher3/popup/PopupContainerWithArrow.java @@ -193,7 +193,7 @@ public class PopupContainerWithArrow extends AbstractFloatingView implements Dra : mShortcutsItemView.getDeepShortcutViews(reverseOrder); List systemShortcutViews = mShortcutsItemView == null ? Collections.EMPTY_LIST - : mShortcutsItemView.getSystemShortcutViews(reverseOrder || true); + : mShortcutsItemView.getSystemShortcutViews(reverseOrder); if (mNotificationItemView != null) { BadgeInfo badgeInfo = mLauncher.getPopupDataProvider() .getBadgeInfoForItem(originalItemInfo); diff --git a/src/com/android/launcher3/shortcuts/ShortcutsItemView.java b/src/com/android/launcher3/shortcuts/ShortcutsItemView.java index ef6365b63..1f90bb023 100644 --- a/src/com/android/launcher3/shortcuts/ShortcutsItemView.java +++ b/src/com/android/launcher3/shortcuts/ShortcutsItemView.java @@ -151,7 +151,9 @@ public class ShortcutsItemView extends PopupItemView implements View.OnLongClick } public List getSystemShortcutViews(boolean reverseOrder) { - if (reverseOrder) { + // Always reverse system shortcut icons (in the header) + // so they are in priority order from right to left. + if (reverseOrder || mSystemShortcutIcons != null) { Collections.reverse(mSystemShortcutViews); } return mSystemShortcutViews; -- cgit v1.2.3