From 8c87cd83e09cd361c68069c84940dbaf20e9860d Mon Sep 17 00:00:00 2001 From: Winson Chung Date: Tue, 23 Jul 2013 16:20:10 -0700 Subject: Fixing issue where the page was reset to 0 on rotation. - We needed to defer setting the restore page until the first onLayout Change-Id: I6b7b4c0a6401ab6ab2caaea0dac0a7261ff831e8 --- src/com/android/launcher3/Launcher.java | 2 +- src/com/android/launcher3/PagedView.java | 16 +++++++++++++++- 2 files changed, 16 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/com/android/launcher3/Launcher.java b/src/com/android/launcher3/Launcher.java index 359204542..321c4e712 100644 --- a/src/com/android/launcher3/Launcher.java +++ b/src/com/android/launcher3/Launcher.java @@ -990,7 +990,7 @@ public class Launcher extends Activity int currentScreen = savedState.getInt(RUNTIME_STATE_CURRENT_SCREEN, -1); if (currentScreen > -1) { - mWorkspace.setCurrentPage(currentScreen); + mWorkspace.setRestorePage(currentScreen); } final long pendingAddContainer = savedState.getLong(RUNTIME_STATE_PENDING_ADD_CONTAINER, -1); diff --git a/src/com/android/launcher3/PagedView.java b/src/com/android/launcher3/PagedView.java index aaff58886..ed88ea90d 100644 --- a/src/com/android/launcher3/PagedView.java +++ b/src/com/android/launcher3/PagedView.java @@ -104,6 +104,7 @@ public abstract class PagedView extends ViewGroup implements ViewGroup.OnHierarc protected boolean mFirstLayout = true; protected int mCurrentPage; + protected int mRestorePage = -1; protected int mChildCountOnLastLayout; protected int mNextPage = INVALID_PAGE; @@ -506,6 +507,14 @@ public abstract class PagedView extends ViewGroup implements ViewGroup.OnHierarc invalidate(); } + /** + * The restore page will be set in place of the current page at the next (likely first) + * layout. + */ + void setRestorePage(int restorePage) { + mRestorePage = restorePage; + } + protected void notifyPageSwitchListener() { if (mPageSwitchListener != null) { mPageSwitchListener.onPageSwitch(getPageAt(mCurrentPage), mCurrentPage); @@ -870,7 +879,12 @@ public abstract class PagedView extends ViewGroup implements ViewGroup.OnHierarc if (mScroller.isFinished() && mChildCountOnLastLayout != getChildCount() && !mDeferringForDelete) { - setCurrentPage(getNextPage()); + if (mRestorePage > -1) { + setCurrentPage(mRestorePage); + mRestorePage = -1; + } else { + setCurrentPage(getNextPage()); + } } mChildCountOnLastLayout = getChildCount(); } -- cgit v1.2.3