From 5108bc0fd9f7e30c87c223fbb75f024e271b2103 Mon Sep 17 00:00:00 2001 From: Adam Cohen Date: Fri, 20 Sep 2013 17:04:51 -0700 Subject: More folder cleanup -> Eliminating out ring -> Fixing the cursor color -> Using "nolip" asset appropriately Change-Id: Ie0e341e865298555dcb0fcb5644e1f3e6b5e39e6 --- src/com/android/launcher3/CellLayout.java | 33 +++++++++++++++---------------- src/com/android/launcher3/FolderIcon.java | 5 ++++- src/com/android/launcher3/Workspace.java | 1 - 3 files changed, 20 insertions(+), 19 deletions(-) (limited to 'src/com/android') diff --git a/src/com/android/launcher3/CellLayout.java b/src/com/android/launcher3/CellLayout.java index 901f42bdf..661685b42 100644 --- a/src/com/android/launcher3/CellLayout.java +++ b/src/com/android/launcher3/CellLayout.java @@ -491,31 +491,30 @@ public class CellLayout extends ViewGroup { for (int i = 0; i < mFolderOuterRings.size(); i++) { FolderRingAnimator fra = mFolderOuterRings.get(i); - // Draw outer ring - Drawable d = FolderRingAnimator.sSharedOuterRingDrawable; - int width = (int) (fra.getOuterRingSize() * getChildrenScale()); - int height = width; + Drawable d; + int width, height; cellToPoint(fra.mCellX, fra.mCellY, mTempLocation); View child = getChildAt(fra.mCellX, fra.mCellY); + int centerX = mTempLocation[0] + mCellWidth / 2; + int centerY = mTempLocation[1] + previewOffset / 2 + + child.getPaddingTop() + grid.folderBackgroundOffset; if (child != null) { - int centerX = mTempLocation[0] + mCellWidth / 2; - int centerY = mTempLocation[1] + previewOffset / 2 + - child.getPaddingTop() + grid.folderBackgroundOffset; - - canvas.save(); - canvas.translate(centerX - width / 2, centerY - height / 2); - d.setBounds(0, 0, width, height); - d.draw(canvas); - canvas.restore(); + // Draw outer ring, if it exists + if (FolderIcon.HAS_OUTER_RING) { + d = FolderRingAnimator.sSharedOuterRingDrawable; + width = (int) (fra.getOuterRingSize() * getChildrenScale()); + height = width; + canvas.save(); + canvas.translate(centerX - width / 2, centerY - height / 2); + d.setBounds(0, 0, width, height); + d.draw(canvas); + canvas.restore(); + } // Draw inner ring d = FolderRingAnimator.sSharedInnerRingDrawable; width = (int) (fra.getInnerRingSize() * getChildrenScale()); height = width; - - centerX = mTempLocation[0] + mCellWidth / 2; - centerY = mTempLocation[1] + previewOffset / 2 + - child.getPaddingTop() + grid.folderBackgroundOffset; canvas.save(); canvas.translate(centerX - width / 2, centerY - width / 2); d.setBounds(0, 0, width, height); diff --git a/src/com/android/launcher3/FolderIcon.java b/src/com/android/launcher3/FolderIcon.java index c00c9f850..433e9037a 100644 --- a/src/com/android/launcher3/FolderIcon.java +++ b/src/com/android/launcher3/FolderIcon.java @@ -73,6 +73,9 @@ public class FolderIcon extends LinearLayout implements FolderListener { // The amount of vertical spread between items in the stack [0...1] private static final float PERSPECTIVE_SHIFT_FACTOR = 0.24f; + // Flag as to whether or not to draw an outer ring. Currently none is designed. + public static final boolean HAS_OUTER_RING = false; + // The degree to which the item in the back of the stack is scaled [0...1] // (0 means it's not scaled at all, 1 means it's scaled to nothing) private static final float PERSPECTIVE_SCALE_FACTOR = 0.35f; @@ -201,7 +204,7 @@ public class FolderIcon extends LinearLayout implements FolderListener { sPreviewSize = grid.folderIconSizePx; sPreviewPadding = res.getDimensionPixelSize(R.dimen.folder_preview_padding); sSharedOuterRingDrawable = res.getDrawable(R.drawable.portal_ring_outer_holo); - sSharedInnerRingDrawable = res.getDrawable(R.drawable.portal_ring_inner_holo); + sSharedInnerRingDrawable = res.getDrawable(R.drawable.portal_ring_inner_nolip_holo); sSharedFolderLeaveBehind = res.getDrawable(R.drawable.portal_ring_rest); sStaticValuesDirty = false; } diff --git a/src/com/android/launcher3/Workspace.java b/src/com/android/launcher3/Workspace.java index 4dca5997a..67d66f4c3 100644 --- a/src/com/android/launcher3/Workspace.java +++ b/src/com/android/launcher3/Workspace.java @@ -991,7 +991,6 @@ public class Workspace extends SmoothPagedView clearChildrenCache(); } - if (mDragController.isDragging()) { if (isSmall()) { // If we are in springloaded mode, then force an event to check if the current touch -- cgit v1.2.3