From 3f8175a86e24b3568d1f5b12e1d3d5efcc57d691 Mon Sep 17 00:00:00 2001 From: Daniel Sandler Date: Tue, 25 May 2010 11:48:32 -0400 Subject: Mask bitmap creation errors while dragging shortcuts. If we're unable to create a bitmap for the drag, e.g. due to memory pressure, give up. Bug: 2650809 Change-Id: I5d7360dbb1bd736a629451467e93cccdfc255b67 --- src/com/android/launcher2/DragController.java | 9 +++++++++ 1 file changed, 9 insertions(+) (limited to 'src/com/android') diff --git a/src/com/android/launcher2/DragController.java b/src/com/android/launcher2/DragController.java index daabbcc4c..b4f972bb2 100644 --- a/src/com/android/launcher2/DragController.java +++ b/src/com/android/launcher2/DragController.java @@ -163,6 +163,11 @@ public class DragController { Bitmap b = getViewBitmap(v); + if (b == null) { + // out of memory? + return; + } + int[] loc = mCoordinatesTemp; v.getLocationOnScreen(loc); int screenX = loc[0]; @@ -249,6 +254,10 @@ public class DragController { } v.buildDrawingCache(); Bitmap cacheBitmap = v.getDrawingCache(); + if (cacheBitmap == null) { + Log.e(TAG, "failed getViewBitmap(" + v + ")", new RuntimeException()); + return null; + } Bitmap bitmap = Bitmap.createBitmap(cacheBitmap); -- cgit v1.2.3