From 5f06401807ef408a4b56a127bef1f0b55b0adcf6 Mon Sep 17 00:00:00 2001 From: Sunny Goyal Date: Mon, 8 Aug 2016 10:10:01 -0700 Subject: Fixing potential ConcurrentModificationException mBgDeepShortcutMap is only accessed on the background thread. But the same instance of list of values was getting passed to the UI thread, instead of being cloned. Change-Id: Ie7d0442d895304489ce9323ea872b9091d668ae5 --- src/com/android/launcher3/util/MultiHashMap.java | 32 ++++++++++++++++++++++++ 1 file changed, 32 insertions(+) (limited to 'src/com/android/launcher3/util') diff --git a/src/com/android/launcher3/util/MultiHashMap.java b/src/com/android/launcher3/util/MultiHashMap.java index f54ab8840..b7275c1f7 100644 --- a/src/com/android/launcher3/util/MultiHashMap.java +++ b/src/com/android/launcher3/util/MultiHashMap.java @@ -1,3 +1,19 @@ +/* + * Copyright (C) 2016 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + package com.android.launcher3.util; import java.util.ArrayList; @@ -7,6 +23,13 @@ import java.util.HashMap; * A utility map from keys to an ArrayList of values. */ public class MultiHashMap extends HashMap> { + + public MultiHashMap() { } + + public MultiHashMap(int size) { + super(size); + } + public void addToList(K key, V value) { ArrayList list = get(key); if (list == null) { @@ -17,4 +40,13 @@ public class MultiHashMap extends HashMap> { list.add(value); } } + + @Override + public MultiHashMap clone() { + MultiHashMap map = new MultiHashMap<>(size()); + for (Entry> entry : entrySet()) { + map.put(entry.getKey(), new ArrayList(entry.getValue())); + } + return map; + } } -- cgit v1.2.3