From 1ef2123ccdf35f2e20ab180111bfa76c46c997e3 Mon Sep 17 00:00:00 2001 From: Winson Chung Date: Mon, 26 Nov 2012 14:08:38 -0800 Subject: Fixing NPE in updateCurrentPageScroll (Bug 7465970) Change-Id: I71d2b01518f3f736f6787ff6a503271b9ea7b04b --- src/com/android/launcher2/PagedView.java | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) (limited to 'src/com/android/launcher2/PagedView.java') diff --git a/src/com/android/launcher2/PagedView.java b/src/com/android/launcher2/PagedView.java index 2cb943d7d..6d5d151f8 100644 --- a/src/com/android/launcher2/PagedView.java +++ b/src/com/android/launcher2/PagedView.java @@ -297,9 +297,13 @@ public abstract class PagedView extends ViewGroup implements ViewGroup.OnHierarc * the previous tab page. */ protected void updateCurrentPageScroll() { - int offset = getChildOffset(mCurrentPage); - int relOffset = getRelativeChildOffset(mCurrentPage); - int newX = offset - relOffset; + // If the current page is invalid, just reset the scroll position to zero + int newX = 0; + if (0 <= mCurrentPage && mCurrentPage < getPageCount()) { + int offset = getChildOffset(mCurrentPage); + int relOffset = getRelativeChildOffset(mCurrentPage); + newX = offset - relOffset; + } scrollTo(newX, 0); mScroller.setFinalX(newX); mScroller.forceFinished(true); -- cgit v1.2.3