From 1f3f07d47c29cba3b70bcd15ebb65a077f55a558 Mon Sep 17 00:00:00 2001 From: Sunny Goyal Date: Fri, 10 Feb 2017 16:52:16 -0800 Subject: Simplifying some launcher themes > Replacing some colors with theme attributes > Simplifying styles definition by removing unnecessary inheritance and inlining some definitions Change-Id: Ifa167515cae6a7fd3720f1a52ff9ce11abb4495f --- res/drawable/all_apps_divider.xml | 2 +- res/drawable/all_apps_search_hint.xml | 2 +- res/drawable/bg_pill_focused.xml | 5 +- res/drawable/deep_shortcuts_drag_handle.xml | 5 +- res/drawable/ic_setting.xml | 2 +- res/drawable/ic_wallpaper.xml | 2 +- res/drawable/ic_widget.xml | 2 +- res/drawable/quantum_panel.xml | 22 ------- res/drawable/quantum_panel_shape.xml | 22 ------- res/layout/all_apps.xml | 9 ++- res/layout/all_apps_button.xml | 4 +- res/layout/all_apps_empty_search.xml | 3 +- res/layout/all_apps_icon.xml | 9 +-- res/layout/app_icon.xml | 4 +- res/layout/deep_shortcut.xml | 24 +++++--- res/layout/folder_application.xml | 9 ++- res/layout/folder_icon.xml | 3 +- res/layout/notification_main.xml | 12 +++- res/layout/qsb_default_view.xml | 6 +- res/layout/user_folder.xml | 10 +-- res/layout/user_folder_icon_normalized.xml | 10 +-- res/values-sw720dp/styles.xml | 1 + res/values-v26/styles.xml | 7 +++ res/values/colors.xml | 12 +--- res/values/dimens.xml | 3 - res/values/styles.xml | 95 ++++++++--------------------- 26 files changed, 102 insertions(+), 183 deletions(-) delete mode 100644 res/drawable/quantum_panel.xml delete mode 100644 res/drawable/quantum_panel_shape.xml (limited to 'res') diff --git a/res/drawable/all_apps_divider.xml b/res/drawable/all_apps_divider.xml index 3fe529556..4bd274dd4 100644 --- a/res/drawable/all_apps_divider.xml +++ b/res/drawable/all_apps_divider.xml @@ -15,6 +15,6 @@ --> - + \ No newline at end of file diff --git a/res/drawable/all_apps_search_hint.xml b/res/drawable/all_apps_search_hint.xml index 36a0f0373..b2ff7a428 100644 --- a/res/drawable/all_apps_search_hint.xml +++ b/res/drawable/all_apps_search_hint.xml @@ -15,6 +15,6 @@ limitations under the License. --> - + \ No newline at end of file diff --git a/res/drawable/bg_pill_focused.xml b/res/drawable/bg_pill_focused.xml index 37afad037..54075d92c 100644 --- a/res/drawable/bg_pill_focused.xml +++ b/res/drawable/bg_pill_focused.xml @@ -16,9 +16,8 @@ - - + + diff --git a/res/drawable/deep_shortcuts_drag_handle.xml b/res/drawable/deep_shortcuts_drag_handle.xml index 99d2b07a5..82e844d2d 100644 --- a/res/drawable/deep_shortcuts_drag_handle.xml +++ b/res/drawable/deep_shortcuts_drag_handle.xml @@ -18,9 +18,10 @@ android:width="@dimen/deep_shortcut_drag_handle_size" android:height="@dimen/deep_shortcut_drag_handle_size" android:viewportWidth="24.0" - android:viewportHeight="24.0"> + android:viewportHeight="24.0" + android:tint="?android:attr/textColorHint" > + android:fillColor="@android:color/white" /> \ No newline at end of file diff --git a/res/drawable/ic_setting.xml b/res/drawable/ic_setting.xml index 8a50c0c78..e89c158c8 100644 --- a/res/drawable/ic_setting.xml +++ b/res/drawable/ic_setting.xml @@ -19,6 +19,6 @@ Copyright (C) 2016 The Android Open Source Project android:viewportWidth="48.0" android:viewportHeight="48.0"> diff --git a/res/drawable/ic_wallpaper.xml b/res/drawable/ic_wallpaper.xml index 7af4b2afc..b7fcfbf55 100644 --- a/res/drawable/ic_wallpaper.xml +++ b/res/drawable/ic_wallpaper.xml @@ -19,6 +19,6 @@ Copyright (C) 2016 The Android Open Source Project android:viewportWidth="48.0" android:viewportHeight="48.0"> diff --git a/res/drawable/ic_widget.xml b/res/drawable/ic_widget.xml index 3e7bd7b51..97706e36d 100644 --- a/res/drawable/ic_widget.xml +++ b/res/drawable/ic_widget.xml @@ -19,6 +19,6 @@ Copyright (C) 2016 The Android Open Source Project android:viewportWidth="48.0" android:viewportHeight="48.0"> diff --git a/res/drawable/quantum_panel.xml b/res/drawable/quantum_panel.xml deleted file mode 100644 index fda100370..000000000 --- a/res/drawable/quantum_panel.xml +++ /dev/null @@ -1,22 +0,0 @@ - - - diff --git a/res/drawable/quantum_panel_shape.xml b/res/drawable/quantum_panel_shape.xml deleted file mode 100644 index 108361576..000000000 --- a/res/drawable/quantum_panel_shape.xml +++ /dev/null @@ -1,22 +0,0 @@ - - - - - - \ No newline at end of file diff --git a/res/layout/all_apps.xml b/res/layout/all_apps.xml index 5f5b38b46..d6bdac2f0 100644 --- a/res/layout/all_apps.xml +++ b/res/layout/all_apps.xml @@ -22,7 +22,7 @@ android:layout_width="match_parent" android:layout_height="match_parent" android:orientation="vertical" - launcher:revealBackground="@drawable/quantum_panel_shape"> + launcher:revealBackground="@drawable/round_rect_primary"> + android:paddingEnd="@dimen/container_fastscroll_thumb_max_width" /> @@ -95,11 +94,11 @@ \ No newline at end of file diff --git a/res/layout/all_apps_button.xml b/res/layout/all_apps_button.xml index 68cc10932..4bc780a70 100644 --- a/res/layout/all_apps_button.xml +++ b/res/layout/all_apps_button.xml @@ -14,6 +14,4 @@ limitations under the License. --> - + diff --git a/res/layout/all_apps_empty_search.xml b/res/layout/all_apps_empty_search.xml index e1635d638..463adac0c 100644 --- a/res/layout/all_apps_empty_search.xml +++ b/res/layout/all_apps_empty_search.xml @@ -25,7 +25,6 @@ android:paddingRight="16dp" android:fontFamily="sans-serif-medium" android:textSize="14sp" - android:textColor="#212121" - android:alpha="0.56" + android:textColor="?android:attr/textColorTertiary" android:focusable="false" /> diff --git a/res/layout/all_apps_icon.xml b/res/layout/all_apps_icon.xml index 3d4bef70c..1e83041d5 100644 --- a/res/layout/all_apps_icon.xml +++ b/res/layout/all_apps_icon.xml @@ -16,12 +16,13 @@ + launcher:centerVertically="true" + android:paddingLeft="4dp" + android:paddingRight="4dp" + android:drawablePadding="@dimen/dynamic_grid_icon_drawable_padding" /> diff --git a/res/layout/app_icon.xml b/res/layout/app_icon.xml index 831cee5b0..fa6eb8910 100644 --- a/res/layout/app_icon.xml +++ b/res/layout/app_icon.xml @@ -14,6 +14,4 @@ limitations under the License. --> - + diff --git a/res/layout/deep_shortcut.xml b/res/layout/deep_shortcut.xml index 1f67682b8..6c1d4da91 100644 --- a/res/layout/deep_shortcut.xml +++ b/res/layout/deep_shortcut.xml @@ -16,18 +16,28 @@ + android:background="@drawable/bg_white_pill" > - + android:background="@drawable/bg_pill_focused" + android:gravity="start|center_vertical" + android:textAlignment="viewStart" + android:paddingStart="@dimen/bg_pill_height" + android:paddingEnd="@dimen/deep_shortcut_padding_end" + android:drawableEnd="@drawable/deep_shortcuts_drag_handle" + android:drawablePadding="@dimen/deep_shortcut_drawable_padding" + android:textSize="14sp" + android:fontFamily="sans-serif" + launcher:layoutHorizontal="true" + launcher:iconDisplay="shortcut_popup" + launcher:iconSizeOverride="@dimen/deep_shortcut_icon_size" + android:elevation="@dimen/deep_shortcuts_elevation" /> - + diff --git a/res/layout/folder_icon.xml b/res/layout/folder_icon.xml index 9eb8c9a67..ccc6b01ea 100644 --- a/res/layout/folder_icon.xml +++ b/res/layout/folder_icon.xml @@ -21,8 +21,9 @@ android:orientation="vertical" android:focusable="true" > diff --git a/res/layout/notification_main.xml b/res/layout/notification_main.xml index efb74b0f7..84827f114 100644 --- a/res/layout/notification_main.xml +++ b/res/layout/notification_main.xml @@ -21,7 +21,6 @@ android:layout_height="match_parent" android:orientation="horizontal" android:focusable="true" - android:background="@drawable/bg_pill_focused" android:elevation="@dimen/notification_elevation" > diff --git a/res/layout/qsb_default_view.xml b/res/layout/qsb_default_view.xml index 82bdea5e8..3075f803f 100644 --- a/res/layout/qsb_default_view.xml +++ b/res/layout/qsb_default_view.xml @@ -23,7 +23,7 @@ android:layout_height="48dp" android:layout_margin="16dp" android:layout_gravity="center_vertical" - android:background="@drawable/quantum_panel_shape" + android:background="@drawable/round_rect_primary" android:elevation="2dp" android:orientation="horizontal"> @@ -35,7 +35,7 @@ android:gravity="center_vertical" android:paddingStart="16dp" android:text="@string/abandoned_search" - android:textColor="@color/quantum_panel_text_color" + android:textColor="?android:attr/textColorSecondary" android:textAppearance="?android:textAppearanceMedium" android:clickable="true" android:background="?android:attr/selectableItemBackground" /> @@ -46,7 +46,7 @@ android:visibility="gone" android:layout_height="match_parent" android:src="@drawable/ic_setting" - android:tint="@color/quantum_panel_text_color" + android:tint="?android:attr/textColorSecondary" android:contentDescription="@string/gadget_setup_text" android:padding="8dp" android:background="?android:attr/selectableItemBackground" /> diff --git a/res/layout/user_folder.xml b/res/layout/user_folder.xml index da2a861d8..cde654096 100644 --- a/res/layout/user_folder.xml +++ b/res/layout/user_folder.xml @@ -18,7 +18,7 @@ xmlns:launcher="http://schemas.android.com/apk/res-auto" android:layout_width="wrap_content" android:layout_height="wrap_content" - android:background="@drawable/quantum_panel" + android:background="@drawable/round_rect_primary" android:elevation="5dp" android:orientation="vertical" > @@ -46,7 +46,7 @@ android:layout_height="wrap_content" android:layout_gravity="center_vertical" android:layout_weight="1" - android:background="#00000000" + android:background="@android:color/transparent" android:fontFamily="sans-serif-condensed" android:gravity="center_horizontal" android:hint="@string/folder_hint_text" @@ -54,10 +54,10 @@ android:paddingBottom="@dimen/folder_label_padding_bottom" android:paddingTop="@dimen/folder_label_padding_top" android:singleLine="true" - android:textColor="#ff777777" + android:textColor="?android:attr/textColorTertiary" android:includeFontPadding="false" - android:textColorHighlight="#ffCCCCCC" - android:textColorHint="#ff808080" + android:textColorHighlight="?android:attr/colorControlHighlight" + android:textColorHint="?android:attr/textColorHint" android:textSize="@dimen/folder_label_text_size" /> @@ -46,7 +46,7 @@ android:layout_height="wrap_content" android:layout_gravity="center_vertical" android:layout_weight="1" - android:background="#00000000" + android:background="@android:color/transparent" android:fontFamily="sans-serif-condensed" android:textStyle="bold" android:gravity="center_horizontal" @@ -55,9 +55,9 @@ android:paddingBottom="@dimen/folder_label_padding_bottom" android:paddingTop="@dimen/folder_label_padding_top" android:singleLine="true" - android:textColor="#EE777777" - android:textColorHighlight="#ffCCCCCC" - android:textColorHint="#ff808080" + android:textColor="?android:attr/textColorTertiary" + android:textColorHighlight="?android:attr/colorControlHighlight" + android:textColorHint="?android:attr/textColorHint" android:textSize="@dimen/folder_label_text_size" /> true true true + ?android:attr/textColorSecondary diff --git a/res/values-v26/styles.xml b/res/values-v26/styles.xml index 6877623d6..cb184094d 100644 --- a/res/values-v26/styles.xml +++ b/res/values-v26/styles.xml @@ -21,4 +21,11 @@ + + + + diff --git a/res/values/colors.xml b/res/values/colors.xml index d166a7925..a02df16e1 100644 --- a/res/values/colors.xml +++ b/res/values/colors.xml @@ -26,21 +26,11 @@ #80c6c5c5 #FFF - #FFFFFFFF - #FF757575 - #FFDDDDDD - #FF666666 - #FFF5F5F5 + #FF000000 #FFFFFFFF - #1E000000 - #FFFFFFFF - #22000000 - #FFF2F2F2 - #28000000 - #AAF2F2F2 #40FFFFFF #FFF diff --git a/res/values/dimens.xml b/res/values/dimens.xml index 70f5b32c7..f5bede909 100644 --- a/res/values/dimens.xml +++ b/res/values/dimens.xml @@ -120,9 +120,6 @@ 1dp - - 4dp - 6dp diff --git a/res/values/styles.xml b/res/values/styles.xml index 879c7d8d6..8a46e839f 100644 --- a/res/values/styles.xml +++ b/res/values/styles.xml @@ -24,11 +24,17 @@ @null true true + #FF757575 - + + - - - - - - - - - - - - - - - @@ -133,11 +86,11 @@ 7.5dp 16dp 16dp - #FFFFFFFF + @color/workspace_icon_text_color @dimen/drop_target_text_size true end - #FF000000 + @color/default_shadow_color_no_alpha 0.0 1.0 4.0 -- cgit v1.2.3