From da1dfa32d0dd56c8c9b4667ebd75d847329285b6 Mon Sep 17 00:00:00 2001 From: Sunny Goyal Date: Wed, 26 Apr 2017 22:34:49 -0700 Subject: Creating a custom drawable to customize shadow. > Fixing DrapTargetBar set to visible (with alpha = 0) in the start causing unnecessary draw Bug: 37616877 Change-Id: Iaaff96099910f504f6e2f81c9376ddacde50ff6a --- proguard.flags | 4 + res/drawable-hdpi/ic_info_launcher.png | Bin 1372 -> 0 bytes res/drawable-hdpi/ic_remove_launcher.png | Bin 832 -> 0 bytes res/drawable-hdpi/ic_uninstall_launcher.png | Bin 552 -> 0 bytes res/drawable-mdpi/ic_info_launcher.png | Bin 689 -> 0 bytes res/drawable-mdpi/ic_remove_launcher.png | Bin 473 -> 0 bytes res/drawable-mdpi/ic_uninstall_launcher.png | Bin 378 -> 0 bytes res/drawable-v24/ic_info_shadow.xml | 18 ++ res/drawable-v24/ic_remove_shadow.xml | 18 ++ res/drawable-v24/ic_uninstall_shadow.xml | 18 ++ res/drawable-xhdpi/ic_info_launcher.png | Bin 2056 -> 0 bytes res/drawable-xhdpi/ic_remove_launcher.png | Bin 965 -> 0 bytes res/drawable-xhdpi/ic_uninstall_launcher.png | Bin 730 -> 0 bytes res/drawable-xxhdpi/ic_info_launcher.png | Bin 3596 -> 0 bytes res/drawable-xxhdpi/ic_remove_launcher.png | Bin 1694 -> 0 bytes res/drawable-xxhdpi/ic_uninstall_launcher.png | Bin 1058 -> 0 bytes res/drawable-xxxhdpi/ic_info_launcher.png | Bin 3276 -> 0 bytes res/drawable-xxxhdpi/ic_remove_launcher.png | Bin 1726 -> 0 bytes res/drawable-xxxhdpi/ic_uninstall_launcher.png | Bin 1042 -> 0 bytes res/drawable/ic_info_no_shadow.xml | 5 +- res/drawable/ic_remove_no_shadow.xml | 25 +++ res/drawable/ic_uninstall_no_shadow.xml | 25 +++ res/layout/drop_target_bar_horz.xml | 1 + res/layout/drop_target_bar_vert.xml | 1 + res/values/attrs.xml | 6 +- res/values/dimens.xml | 1 + res/values/drawables.xml | 20 +++ src/com/android/launcher3/DeleteDropTarget.java | 2 +- src/com/android/launcher3/InfoDropTarget.java | 6 +- src/com/android/launcher3/UninstallDropTarget.java | 7 +- .../android/launcher3/graphics/ShadowDrawable.java | 191 +++++++++++++++++++++ 31 files changed, 338 insertions(+), 10 deletions(-) delete mode 100644 res/drawable-hdpi/ic_info_launcher.png delete mode 100644 res/drawable-hdpi/ic_remove_launcher.png delete mode 100644 res/drawable-hdpi/ic_uninstall_launcher.png delete mode 100644 res/drawable-mdpi/ic_info_launcher.png delete mode 100644 res/drawable-mdpi/ic_remove_launcher.png delete mode 100644 res/drawable-mdpi/ic_uninstall_launcher.png create mode 100644 res/drawable-v24/ic_info_shadow.xml create mode 100644 res/drawable-v24/ic_remove_shadow.xml create mode 100644 res/drawable-v24/ic_uninstall_shadow.xml delete mode 100644 res/drawable-xhdpi/ic_info_launcher.png delete mode 100644 res/drawable-xhdpi/ic_remove_launcher.png delete mode 100644 res/drawable-xhdpi/ic_uninstall_launcher.png delete mode 100644 res/drawable-xxhdpi/ic_info_launcher.png delete mode 100644 res/drawable-xxhdpi/ic_remove_launcher.png delete mode 100644 res/drawable-xxhdpi/ic_uninstall_launcher.png delete mode 100644 res/drawable-xxxhdpi/ic_info_launcher.png delete mode 100644 res/drawable-xxxhdpi/ic_remove_launcher.png delete mode 100644 res/drawable-xxxhdpi/ic_uninstall_launcher.png create mode 100644 res/drawable/ic_remove_no_shadow.xml create mode 100644 res/drawable/ic_uninstall_no_shadow.xml create mode 100644 res/values/drawables.xml create mode 100644 src/com/android/launcher3/graphics/ShadowDrawable.java diff --git a/proguard.flags b/proguard.flags index 6cbab08e2..2ad9cacf2 100644 --- a/proguard.flags +++ b/proguard.flags @@ -82,6 +82,10 @@ *; } +-keep class com.android.launcher3.graphics.ShadowDrawable { + public (...); +} + # Proguard will strip methods required for talkback to properly scroll to # next row when focus is on the last item of last row when using a RecyclerView # Keep optimized and shrunk proguard to prevent issues like this when using diff --git a/res/drawable-hdpi/ic_info_launcher.png b/res/drawable-hdpi/ic_info_launcher.png deleted file mode 100644 index 11162e1e7..000000000 Binary files a/res/drawable-hdpi/ic_info_launcher.png and /dev/null differ diff --git a/res/drawable-hdpi/ic_remove_launcher.png b/res/drawable-hdpi/ic_remove_launcher.png deleted file mode 100644 index ad2b9af24..000000000 Binary files a/res/drawable-hdpi/ic_remove_launcher.png and /dev/null differ diff --git a/res/drawable-hdpi/ic_uninstall_launcher.png b/res/drawable-hdpi/ic_uninstall_launcher.png deleted file mode 100644 index 426683c6d..000000000 Binary files a/res/drawable-hdpi/ic_uninstall_launcher.png and /dev/null differ diff --git a/res/drawable-mdpi/ic_info_launcher.png b/res/drawable-mdpi/ic_info_launcher.png deleted file mode 100644 index 6fbe5e395..000000000 Binary files a/res/drawable-mdpi/ic_info_launcher.png and /dev/null differ diff --git a/res/drawable-mdpi/ic_remove_launcher.png b/res/drawable-mdpi/ic_remove_launcher.png deleted file mode 100644 index 2bb281d59..000000000 Binary files a/res/drawable-mdpi/ic_remove_launcher.png and /dev/null differ diff --git a/res/drawable-mdpi/ic_uninstall_launcher.png b/res/drawable-mdpi/ic_uninstall_launcher.png deleted file mode 100644 index bfcbc6dfa..000000000 Binary files a/res/drawable-mdpi/ic_uninstall_launcher.png and /dev/null differ diff --git a/res/drawable-v24/ic_info_shadow.xml b/res/drawable-v24/ic_info_shadow.xml new file mode 100644 index 000000000..9bd7e16d0 --- /dev/null +++ b/res/drawable-v24/ic_info_shadow.xml @@ -0,0 +1,18 @@ + + + diff --git a/res/drawable-v24/ic_remove_shadow.xml b/res/drawable-v24/ic_remove_shadow.xml new file mode 100644 index 000000000..16a630e5f --- /dev/null +++ b/res/drawable-v24/ic_remove_shadow.xml @@ -0,0 +1,18 @@ + + + diff --git a/res/drawable-v24/ic_uninstall_shadow.xml b/res/drawable-v24/ic_uninstall_shadow.xml new file mode 100644 index 000000000..2532157ab --- /dev/null +++ b/res/drawable-v24/ic_uninstall_shadow.xml @@ -0,0 +1,18 @@ + + + diff --git a/res/drawable-xhdpi/ic_info_launcher.png b/res/drawable-xhdpi/ic_info_launcher.png deleted file mode 100644 index 041f2b3c0..000000000 Binary files a/res/drawable-xhdpi/ic_info_launcher.png and /dev/null differ diff --git a/res/drawable-xhdpi/ic_remove_launcher.png b/res/drawable-xhdpi/ic_remove_launcher.png deleted file mode 100644 index ff94eb8e9..000000000 Binary files a/res/drawable-xhdpi/ic_remove_launcher.png and /dev/null differ diff --git a/res/drawable-xhdpi/ic_uninstall_launcher.png b/res/drawable-xhdpi/ic_uninstall_launcher.png deleted file mode 100644 index 2c7ab56e9..000000000 Binary files a/res/drawable-xhdpi/ic_uninstall_launcher.png and /dev/null differ diff --git a/res/drawable-xxhdpi/ic_info_launcher.png b/res/drawable-xxhdpi/ic_info_launcher.png deleted file mode 100644 index 8e602da02..000000000 Binary files a/res/drawable-xxhdpi/ic_info_launcher.png and /dev/null differ diff --git a/res/drawable-xxhdpi/ic_remove_launcher.png b/res/drawable-xxhdpi/ic_remove_launcher.png deleted file mode 100644 index 78ca0804c..000000000 Binary files a/res/drawable-xxhdpi/ic_remove_launcher.png and /dev/null differ diff --git a/res/drawable-xxhdpi/ic_uninstall_launcher.png b/res/drawable-xxhdpi/ic_uninstall_launcher.png deleted file mode 100644 index 43aba6ec0..000000000 Binary files a/res/drawable-xxhdpi/ic_uninstall_launcher.png and /dev/null differ diff --git a/res/drawable-xxxhdpi/ic_info_launcher.png b/res/drawable-xxxhdpi/ic_info_launcher.png deleted file mode 100644 index 3540de1a1..000000000 Binary files a/res/drawable-xxxhdpi/ic_info_launcher.png and /dev/null differ diff --git a/res/drawable-xxxhdpi/ic_remove_launcher.png b/res/drawable-xxxhdpi/ic_remove_launcher.png deleted file mode 100644 index 418d81ad6..000000000 Binary files a/res/drawable-xxxhdpi/ic_remove_launcher.png and /dev/null differ diff --git a/res/drawable-xxxhdpi/ic_uninstall_launcher.png b/res/drawable-xxxhdpi/ic_uninstall_launcher.png deleted file mode 100644 index 724437a2a..000000000 Binary files a/res/drawable-xxxhdpi/ic_uninstall_launcher.png and /dev/null differ diff --git a/res/drawable/ic_info_no_shadow.xml b/res/drawable/ic_info_no_shadow.xml index 5f145c9f1..91a3a565a 100644 --- a/res/drawable/ic_info_no_shadow.xml +++ b/res/drawable/ic_info_no_shadow.xml @@ -17,8 +17,9 @@ android:width="24dp" android:height="24dp" android:viewportWidth="24.0" - android:viewportHeight="24.0"> + android:viewportHeight="24.0" + android:tint="?android:attr/textColorPrimary" > diff --git a/res/drawable/ic_remove_no_shadow.xml b/res/drawable/ic_remove_no_shadow.xml new file mode 100644 index 000000000..ef538a611 --- /dev/null +++ b/res/drawable/ic_remove_no_shadow.xml @@ -0,0 +1,25 @@ + + + + + diff --git a/res/drawable/ic_uninstall_no_shadow.xml b/res/drawable/ic_uninstall_no_shadow.xml new file mode 100644 index 000000000..5bab4222e --- /dev/null +++ b/res/drawable/ic_uninstall_no_shadow.xml @@ -0,0 +1,25 @@ + + + + + diff --git a/res/layout/drop_target_bar_horz.xml b/res/layout/drop_target_bar_horz.xml index fcbb54e39..ed18192c5 100644 --- a/res/layout/drop_target_bar_horz.xml +++ b/res/layout/drop_target_bar_horz.xml @@ -20,6 +20,7 @@ android:theme="@style/HomeScreenElementTheme" android:layout_width="match_parent" android:layout_height="@dimen/dynamic_grid_drop_target_size" + android:visibility="invisible" android:layout_gravity="center_horizontal|top" android:focusable="false"> diff --git a/res/layout/drop_target_bar_vert.xml b/res/layout/drop_target_bar_vert.xml index 54d9dfe3a..e2a65d4a5 100644 --- a/res/layout/drop_target_bar_vert.xml +++ b/res/layout/drop_target_bar_vert.xml @@ -21,6 +21,7 @@ android:orientation="vertical" android:layout_height="match_parent" android:layout_gravity="left" + android:visibility="invisible" android:focusable="false" android:paddingTop="@dimen/vert_drop_target_vertical_gap" > diff --git a/res/values/attrs.xml b/res/values/attrs.xml index 18f409f34..18759f817 100644 --- a/res/values/attrs.xml +++ b/res/values/attrs.xml @@ -16,7 +16,7 @@ */ --> - + @@ -111,4 +111,8 @@ + + + + diff --git a/res/values/dimens.xml b/res/values/dimens.xml index 75618b894..7dd9e5315 100644 --- a/res/values/dimens.xml +++ b/res/values/dimens.xml @@ -146,6 +146,7 @@ 2dp 4dp 2dp + 2dp 8dp diff --git a/res/values/drawables.xml b/res/values/drawables.xml new file mode 100644 index 000000000..fea17b153 --- /dev/null +++ b/res/values/drawables.xml @@ -0,0 +1,20 @@ + + + + @drawable/ic_info_no_shadow + @drawable/ic_remove_no_shadow + @drawable/ic_uninstall_no_shadow + \ No newline at end of file diff --git a/src/com/android/launcher3/DeleteDropTarget.java b/src/com/android/launcher3/DeleteDropTarget.java index 9097ed23d..975675a6f 100644 --- a/src/com/android/launcher3/DeleteDropTarget.java +++ b/src/com/android/launcher3/DeleteDropTarget.java @@ -40,7 +40,7 @@ public class DeleteDropTarget extends ButtonDropTarget { // Get the hover color mHoverColor = getResources().getColor(R.color.delete_target_hover_tint); - setDrawable(R.drawable.ic_remove_launcher); + setDrawable(R.drawable.ic_remove_shadow); } @Override diff --git a/src/com/android/launcher3/InfoDropTarget.java b/src/com/android/launcher3/InfoDropTarget.java index 2f61a01ed..7b3bded17 100644 --- a/src/com/android/launcher3/InfoDropTarget.java +++ b/src/com/android/launcher3/InfoDropTarget.java @@ -40,12 +40,10 @@ public class InfoDropTarget extends UninstallDropTarget { } @Override - protected void onFinishInflate() { - super.onFinishInflate(); + protected void setupUi() { // Get the hover color mHoverColor = Themes.getColorAccent(getContext()); - - setDrawable(R.drawable.ic_info_launcher); + setDrawable(R.drawable.ic_info_shadow); } @Override diff --git a/src/com/android/launcher3/UninstallDropTarget.java b/src/com/android/launcher3/UninstallDropTarget.java index 0fac29f30..45c14d6bb 100644 --- a/src/com/android/launcher3/UninstallDropTarget.java +++ b/src/com/android/launcher3/UninstallDropTarget.java @@ -28,10 +28,13 @@ public class UninstallDropTarget extends ButtonDropTarget { @Override protected void onFinishInflate() { super.onFinishInflate(); + setupUi(); + } + + protected void setupUi() { // Get the hover color mHoverColor = getResources().getColor(R.color.uninstall_target_hover_tint); - - setDrawable(R.drawable.ic_uninstall_launcher); + setDrawable(R.drawable.ic_uninstall_shadow); } @Override diff --git a/src/com/android/launcher3/graphics/ShadowDrawable.java b/src/com/android/launcher3/graphics/ShadowDrawable.java new file mode 100644 index 000000000..5e76649ca --- /dev/null +++ b/src/com/android/launcher3/graphics/ShadowDrawable.java @@ -0,0 +1,191 @@ +/* + * Copyright (C) 2017 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package com.android.launcher3.graphics; + +import android.content.res.Resources; +import android.content.res.TypedArray; +import android.graphics.Bitmap; +import android.graphics.BlurMaskFilter; +import android.graphics.Canvas; +import android.graphics.Color; +import android.graphics.ColorFilter; +import android.graphics.Paint; +import android.graphics.PixelFormat; +import android.graphics.Rect; +import android.graphics.drawable.Drawable; +import android.util.AttributeSet; + +import com.android.launcher3.R; +import com.android.launcher3.Utilities; + +import org.xmlpull.v1.XmlPullParser; +import org.xmlpull.v1.XmlPullParserException; + +import java.io.IOException; + +/** + * A drawable which adds shadow around a child drawable. + */ +public class ShadowDrawable extends Drawable { + + private final Paint mPaint = new Paint(Paint.ANTI_ALIAS_FLAG | Paint.FILTER_BITMAP_FLAG); + + private final ShadowDrawableState mState; + + public ShadowDrawable() { + this(new ShadowDrawableState()); + } + + private ShadowDrawable(ShadowDrawableState state) { + mState = state; + } + + @Override + public void draw(Canvas canvas) { + Rect bounds = getBounds(); + if (bounds.isEmpty()) { + return; + } + if (mState.mLastDrawnBitmap == null) { + regenerateBitmapCache(); + } + canvas.drawBitmap(mState.mLastDrawnBitmap, null, bounds, mPaint); + } + + @Override + public void setAlpha(int alpha) { + mPaint.setAlpha(alpha); + invalidateSelf(); + } + + @Override + public void setColorFilter(ColorFilter colorFilter) { + mPaint.setColorFilter(colorFilter); + invalidateSelf(); + } + + @Override + public ConstantState getConstantState() { + return mState; + } + + @Override + public int getOpacity() { + return PixelFormat.TRANSLUCENT; + } + + @Override + public int getIntrinsicHeight() { + return mState.mIntrinsicHeight; + } + + @Override + public int getIntrinsicWidth() { + return mState.mIntrinsicWidth; + } + + /** + * Sets the color for the generated shadow + */ + public void setShadowColor(int color) { + if (mState.mShadowColor != color) { + mState.mShadowColor = color; + mState.mLastDrawnBitmap = null; + invalidateSelf(); + } + } + + private void regenerateBitmapCache() { + Bitmap bitmap = Bitmap.createBitmap(mState.mIntrinsicWidth, mState.mIntrinsicHeight, + Bitmap.Config.ARGB_8888); + Canvas canvas = new Canvas(bitmap); + + // Call mutate, so that the pixel allocation by the underlying vector drawable is cleared. + Drawable d = mState.mChildState.newDrawable().mutate(); + d.setBounds(mState.mShadowSize, mState.mShadowSize, + mState.mIntrinsicWidth - mState.mShadowSize, + mState.mIntrinsicHeight - mState.mShadowSize); + d.draw(canvas); + + Paint paint = new Paint(Paint.ANTI_ALIAS_FLAG | Paint.FILTER_BITMAP_FLAG); + paint.setMaskFilter(new BlurMaskFilter(mState.mShadowSize, BlurMaskFilter.Blur.NORMAL)); + int[] offset = new int[2]; + Bitmap shadow = bitmap.extractAlpha(paint, offset); + + paint.setMaskFilter(null); + paint.setColor(mState.mShadowColor); + bitmap.eraseColor(Color.TRANSPARENT); + canvas.drawBitmap(shadow, offset[0], offset[1], paint); + d.draw(canvas); + + if (Utilities.isAtLeastO()) { + bitmap = bitmap.copy(Bitmap.Config.HARDWARE, false); + } + mState.mLastDrawnBitmap = bitmap; + } + + @Override + public void inflate(Resources r, XmlPullParser parser, AttributeSet attrs, + Resources.Theme theme) throws XmlPullParserException, IOException { + super.inflate(r, parser, attrs, theme); + + final TypedArray a = theme == null + ? r.obtainAttributes(attrs, R.styleable.ShadowDrawable) + : theme.obtainStyledAttributes(attrs, R.styleable.ShadowDrawable, 0, 0); + + try { + Drawable d = a.getDrawable(R.styleable.ShadowDrawable_android_src); + if (d == null) { + throw new XmlPullParserException("missing src attribute"); + } + mState.mShadowColor = a.getColor( + R.styleable.ShadowDrawable_android_shadowColor, Color.BLACK); + mState.mShadowSize = r.getDimensionPixelSize(R.dimen.drawable_shadow_size); + + mState.mIntrinsicHeight = d.getIntrinsicHeight() + 2 * mState.mShadowSize; + mState.mIntrinsicWidth = d.getIntrinsicWidth() + 2 * mState.mShadowSize; + mState.mChangingConfigurations = d.getChangingConfigurations(); + + mState.mChildState = d.getConstantState(); + } finally { + a.recycle(); + } + } + + private static class ShadowDrawableState extends ConstantState { + + int mChangingConfigurations; + int mIntrinsicWidth; + int mIntrinsicHeight; + + int mShadowColor; + int mShadowSize; + + Bitmap mLastDrawnBitmap; + ConstantState mChildState; + + @Override + public Drawable newDrawable() { + return new ShadowDrawable(this); + } + + @Override + public int getChangingConfigurations() { + return mChangingConfigurations; + } + } +} -- cgit v1.2.3