From 8e19cf22a4ab86f982b08e7d10b86ea7be56accc Mon Sep 17 00:00:00 2001 From: Jason Monk Date: Thu, 20 Mar 2014 15:06:57 -0400 Subject: Fix missing stack trace on checkItemInfoLocked call Just put this change into Launcher2, now adding to Launcher3 The call to checkItemInfoLocked from addItemToDatabase was missing a stack trace so that if the check failed, the stack trace did not contain what triggered the add. Change-Id: Ia2e2aae20b16d4adadfe1da53b49e93073fab55c --- src/com/android/launcher3/LauncherModel.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/com/android/launcher3/LauncherModel.java b/src/com/android/launcher3/LauncherModel.java index 145d225dc..e5eca625b 100644 --- a/src/com/android/launcher3/LauncherModel.java +++ b/src/com/android/launcher3/LauncherModel.java @@ -971,6 +971,7 @@ public class LauncherModel extends BroadcastReceiver { values.put(LauncherSettings.Favorites._ID, item.id); item.updateValuesWithCoordinates(values, item.cellX, item.cellY); + final StackTraceElement[] stackTrace = new Throwable().getStackTrace(); Runnable r = new Runnable() { public void run() { cr.insert(notify ? LauncherSettings.Favorites.CONTENT_URI : @@ -978,7 +979,7 @@ public class LauncherModel extends BroadcastReceiver { // Lock on mBgLock *after* the db operation synchronized (sBgLock) { - checkItemInfoLocked(item.id, item, null); + checkItemInfoLocked(item.id, item, stackTrace); sBgItemsIdMap.put(item.id, item); switch (item.itemType) { case LauncherSettings.Favorites.ITEM_TYPE_FOLDER: -- cgit v1.2.3